From: Tanguy Le Carrour <tanguy@bioneland.org>
To: Mathieu Othacehe <othacehe@gnu.org>
Cc: 42792-done@debbugs.gnu.org
Subject: [bug#42792] [PATCH] gnu: Add python-pydantic.
Date: Tue, 11 Aug 2020 11:00:18 +0200 [thread overview]
Message-ID: <20200811090018.2tlkd2k4ken7r637@melmoth> (raw)
In-Reply-To: <87h7t9y3yv.fsf@gnu.org>
Hi Mathieu,
Le 08/11, Mathieu Othacehe a écrit :
> Hey Tanguy,
>
> >> (uri (git-reference
> >> (url "https://github.com/samuelcolvin/pydantic")
> >> - (commit (string-append "v" version))))
> >> + (commit (string-append "v" version))))
> >> (file-name (git-file-name name version))
> >> - (sha256 (base32 "1380s9k77g6q15by9fkxndczjk89q6xpz09jdrqip535xws2z3j8"))))
> >> + (sha256
> >> + (base32 "1380s9k77g6q15by9fkxndczjk89q6xpz09jdrqip535xws2z3j8"))))
> >
> > Thanks for paying attention to every details!!
> > Actually, those things have been bothering me for quiet a while…
> > They are not reported by `./pre-inst-env guix lint python-pydantic` or
> > fixed by `emacs --script etc/indent-code.el gnu/packages/python-xyz.scm python-pydantic`. :-(
>
> The first diff is fixed when running "./etc/indent-code.el
> gnu/packages/python-xyz.scm python-pydantic" for me.
>
> >
> > Would the following have been acceptable?
> >
> > ```
> >> + (sha256 (base32
> >> + "1380s9k77g6q15by9fkxndczjk89q6xpz09jdrqip535xws2z3j8"))))
> > ```
>
> It is acceptable but the convention is to put "base32" on the next line.
>
> >
> > And what about this? (2-space indent instead of 1, like `add-before` below)
> >
> > ```
> >> + (sha256
> >> + (base32 "1380s9k77g6q15by9fkxndczjk89q6xpz09jdrqip535xws2z3j8"))))
> > ```
>
> No only one space here, this is also handled by the indent script for me.
Actually, I think there might be a problem with the way I use the
script, because it does not fix anything!? :-(
And before you say it, I know, I should be using Emacs and not Vim! ;-)
I've considered moving to Emacs as my dev environment (not as my text editor),
but there are so many things I have to set up to feel at home: evil,
python, fuzzy file search… I hope I'll have some time to work on this
later this month.
> >> (build-system python-build-system)
> >> (arguments
> >> '(#:phases
> >> (modify-phases %standard-phases
> >> - ;; Reported upstream: <https://github.com/samuelcolvin/pydantic/issues/1580>
> >> - ;; Not sure how to apply the suggested fix!?
> >> + ;; Reported upstream:
> >> + ;; <https://github.com/samuelcolvin/pydantic/issues/1580>.
> >> + ;; Disable the faulty test as the fix is unclear.
> >
> > Much better, thanks!
> > In retrospect, I realize that I should have put the question in the
> > commit message for a maintainer to read, not in the package definition.
> > Would that have been better?!
>
> No it's perfectly fine in the package declaration :)
>
> Hope I'm not bothering you to much with this boring syntactic stuff :p
Not at all! I actually very much appreciate the fact that people take the
time to review and discuss contributions!
Regards
--
Tanguy
prev parent reply other threads:[~2020-08-11 9:03 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-10 8:43 [bug#42792] [PATCH] gnu: Add python-pydantic Tanguy Le Carrour
2020-08-10 10:05 ` bug#42792: " Mathieu Othacehe
2020-08-10 14:19 ` [bug#42792] " Tanguy Le Carrour
2020-08-11 8:35 ` Mathieu Othacehe
2020-08-11 9:00 ` Tanguy Le Carrour [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200811090018.2tlkd2k4ken7r637@melmoth \
--to=tanguy@bioneland.org \
--cc=42792-done@debbugs.gnu.org \
--cc=othacehe@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.