From: Tanguy Le Carrour <tanguy@bioneland.org>
To: Mathieu Othacehe <othacehe@gnu.org>
Cc: 42792-done@debbugs.gnu.org
Subject: [bug#42792] [PATCH] gnu: Add python-pydantic.
Date: Mon, 10 Aug 2020 16:19:11 +0200 [thread overview]
Message-ID: <20200810141911.jtpjdeylftxiyk6q@rafflesia> (raw)
In-Reply-To: <87wo26g6ji.fsf@gnu.org>
Hi Mathieu,
Le 08/10, Mathieu Othacehe a écrit :
> > * gnu/packages/python-xyz.scm (python-pydantic): New variable.
>
> Applied with the following diff:
>
> diff --git a/gnu/packages/python-xyz.scm b/gnu/packages/python-xyz.scm
> index a36e99aa32..4102902465 100644
> --- a/gnu/packages/python-xyz.scm
> +++ b/gnu/packages/python-xyz.scm
> @@ -3829,30 +3829,32 @@ Language (TOML) configuration files.")
> (method git-fetch)
> (uri (git-reference
> (url "https://github.com/samuelcolvin/pydantic")
> - (commit (string-append "v" version))))
> + (commit (string-append "v" version))))
> (file-name (git-file-name name version))
> - (sha256 (base32 "1380s9k77g6q15by9fkxndczjk89q6xpz09jdrqip535xws2z3j8"))))
> + (sha256
> + (base32 "1380s9k77g6q15by9fkxndczjk89q6xpz09jdrqip535xws2z3j8"))))
Thanks for paying attention to every details!!
Actually, those things have been bothering me for quiet a while…
They are not reported by `./pre-inst-env guix lint python-pydantic` or
fixed by `emacs --script etc/indent-code.el gnu/packages/python-xyz.scm python-pydantic`. :-(
Would the following have been acceptable?
```
> + (sha256 (base32
> + "1380s9k77g6q15by9fkxndczjk89q6xpz09jdrqip535xws2z3j8"))))
```
And what about this? (2-space indent instead of 1, like `add-before` below)
```
> + (sha256
> + (base32 "1380s9k77g6q15by9fkxndczjk89q6xpz09jdrqip535xws2z3j8"))))
```
> (build-system python-build-system)
> (arguments
> '(#:phases
> (modify-phases %standard-phases
> - ;; Reported upstream: <https://github.com/samuelcolvin/pydantic/issues/1580>
> - ;; Not sure how to apply the suggested fix!?
> + ;; Reported upstream:
> + ;; <https://github.com/samuelcolvin/pydantic/issues/1580>.
> + ;; Disable the faulty test as the fix is unclear.
Much better, thanks!
In retrospect, I realize that I should have put the question in the
commit message for a maintainer to read, not in the package definition.
Would that have been better?!
> (add-before 'check 'disable-test
> (lambda _
> (substitute* "tests/test_validators.py"
> (("test_assert_raises_validation_error")
> - "_test_assert_raises_validation_error"))
> + "_test_assert_raises_validation_error"))
> #t))
> (replace 'check
> (lambda _ (invoke "pytest" "-vv" "tests"))))))
> (native-inputs
> `(("python-pytest" ,python-pytest)))
> (home-page "https://github.com/samuelcolvin/pydantic")
> - (synopsis "Data validation and settings management using python type hinting")
> + (synopsis "Python data validation and settings management")
Sorry, I still suck at synopsis! :-(
> (description
> - "Pydantic enforces type hints at runtime, and provides user friendly errors
> -when data is invalid.")
> + "Pydantic enforces type hints at runtime, and provides user friendly
> +errors when data is invalid.")
> (license license:expat)))
Thanks!
--
Tanguy
next prev parent reply other threads:[~2020-08-10 14:20 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-10 8:43 [bug#42792] [PATCH] gnu: Add python-pydantic Tanguy Le Carrour
2020-08-10 10:05 ` bug#42792: " Mathieu Othacehe
2020-08-10 14:19 ` Tanguy Le Carrour [this message]
2020-08-11 8:35 ` [bug#42792] " Mathieu Othacehe
2020-08-11 9:00 ` Tanguy Le Carrour
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200810141911.jtpjdeylftxiyk6q@rafflesia \
--to=tanguy@bioneland.org \
--cc=42792-done@debbugs.gnu.org \
--cc=othacehe@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.