From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id 6OrPIKPIIl8fUgAA0tVLHw (envelope-from ) for ; Thu, 30 Jul 2020 13:18:27 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id iIymHKPIIl/MPgAAbx9fmQ (envelope-from ) for ; Thu, 30 Jul 2020 13:18:27 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 43D709403E7 for ; Thu, 30 Jul 2020 13:18:27 +0000 (UTC) Received: from localhost ([::1]:44834 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1k18S2-0007Wa-9X for larch@yhetil.org; Thu, 30 Jul 2020 09:18:26 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:39074) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k18Rm-0007Ve-I6 for guix-devel@gnu.org; Thu, 30 Jul 2020 09:18:10 -0400 Received: from relay11.mail.gandi.net ([217.70.178.231]:46287) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k18Rk-00053L-Ha; Thu, 30 Jul 2020 09:18:10 -0400 Received: from localhost (176-159-32-89.abo.bbox.fr [176.159.32.89]) (Authenticated sender: tanguy@bioneland.org) by relay11.mail.gandi.net (Postfix) with ESMTPSA id D915C10000A; Thu, 30 Jul 2020 13:18:05 +0000 (UTC) Date: Thu, 30 Jul 2020 15:18:05 +0200 From: Tanguy Le Carrour To: Marius Bakke Subject: Re: [PATCH 0/X] gnu: poetry: Fix broken dependency after dependency's version update. Message-ID: <20200730131805.f3lqoiszb456jx4y@rafflesia> References: <20200728154816.zcuysdktcu3me3nv@rafflesia> <875za6q6yt.fsf@gnu.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <875za6q6yt.fsf@gnu.org> Received-SPF: none client-ip=217.70.178.231; envelope-from=tanguy@bioneland.org; helo=relay11.mail.gandi.net X-detected-operating-system: by eggs.gnu.org: First seen = 2020/07/30 09:18:06 X-ACL-Warn: Detected OS = Linux 3.11 and newer X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_NONE=0.001, SPF_NONE=0.001, URIBL_BLOCKED=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: guix-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Guix Errors-To: guix-devel-bounces+larch=yhetil.org@gnu.org Sender: "Guix-devel" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-devel-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-devel-bounces@gnu.org X-Spam-Score: -0.51 X-TUID: o7rBOdplN2oy Hi Marius, Le 07/30, Marius Bakke a écrit : > Tanguy Le Carrour writes: > > Few days ago, I submitted a patch to update `python-tomlkit`. It was pushed > > to master and, after I upgraded my packages today, I realised that `poetry` > > (and possibly other python packages) was broken! > > > > The "problem" is that Poetry depends on `tomlkit = "^0.5.11"`. This > > translates to `>=0.5.11,<0.6.0`. And I updated `python-tomlkit` to… 0.6.0! > > > > In SemVer [1], minor releases are supposed to "add functionality > > in a backwards compatible manner", so this "<0.6.0" seems, IMHO, wrong. > > But that's not the point… > > > > [1]: https://semver.org/ > > > > Now, I have to fix Poetry and I have 2 options: > > - modify poetry `setup.py` and substitute `>=0.5.11,<0.7.0` to `>=0.5.11,<0.6.0`; > > - add a new `python-tomlkit-0.5` and use it in the propagated inputs. > > > > Any suggestion on the one I should implement? > > I haven't looked into it, but if the tomlkit API really is compatible, > the first suggestion sounds good to me. It would be good to notify > upstream about the unreasonable "pinning" in that case. Problem reported upstream: . > Otherwise the second suggestion sounds good too. There is plenty of > precedence for both solutions in Guix and is really something that needs > to be decided on a case-by-case basis. I decided to implement the "quick fix": . I'll implement the `python-tomlkit-0.5` solution if upstream does not see this as a problem. Regards -- Tanguy