From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id oBjVOtG/GF8BGQAA0tVLHw (envelope-from ) for ; Wed, 22 Jul 2020 22:38:09 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id wIGqNtG/GF8CJgAAB5/wlQ (envelope-from ) for ; Wed, 22 Jul 2020 22:38:09 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 6FC9B9403A3 for ; Wed, 22 Jul 2020 22:38:09 +0000 (UTC) Received: from localhost ([::1]:40424 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jyNNI-0004rT-3E for larch@yhetil.org; Wed, 22 Jul 2020 18:38:08 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:40754) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jyNNB-0004rA-Vq for guix-patches@gnu.org; Wed, 22 Jul 2020 18:38:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:60035) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jyNNB-0006Q7-MU for guix-patches@gnu.org; Wed, 22 Jul 2020 18:38:01 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jyNNB-000869-KK for guix-patches@gnu.org; Wed, 22 Jul 2020 18:38:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#42339] [PATCH core-updates] gnu: glibc-intermediate: Fixup the pre-configure phase. Resent-From: Jakub =?UTF-8?Q?K=C4=85dzio=C5=82ka?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 22 Jul 2020 22:38:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 42339 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: 42339@debbugs.gnu.org Received: via spool by 42339-submit@debbugs.gnu.org id=B42339.159545744831087 (code B ref 42339); Wed, 22 Jul 2020 22:38:01 +0000 Received: (at 42339) by debbugs.gnu.org; 22 Jul 2020 22:37:28 +0000 Received: from localhost ([127.0.0.1]:43348 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jyNMd-00085L-Vb for submit@debbugs.gnu.org; Wed, 22 Jul 2020 18:37:28 -0400 Received: from pat.zlotemysli.pl ([37.59.186.212]:42460) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jyNMa-00085A-JA for 42339@debbugs.gnu.org; Wed, 22 Jul 2020 18:37:26 -0400 Received: (qmail 29514 invoked by uid 1009); 23 Jul 2020 00:37:22 +0200 Received: from user-94-254-154-173.play-internet.pl (kuba@kadziolka.net@user-94-254-154-173.play-internet.pl) by pat.zlotemysli.pl (envelope-from , uid 1002) with qmail-scanner-2.08st (clamdscan: 0.98.6/25880. spamassassin: 3.4.0. perlscan: 2.08st. Clear:RC:1(94.254.154.173):. Processed in 0.068077 secs); 22 Jul 2020 22:37:22 -0000 Received: from user-94-254-154-173.play-internet.pl (HELO gravity) (kuba@kadziolka.net@94.254.154.173) by pat.zlotemysli.pl with SMTP; 23 Jul 2020 00:37:22 +0200 Date: Thu, 23 Jul 2020 00:37:21 +0200 From: Jakub =?UTF-8?Q?K=C4=85dzio=C5=82ka?= Message-ID: <20200722223721.upm7cf2gnghfv2pp@gravity> References: <20200712234039.17871-1-kuba@kadziolka.net> <874kpzgqh5.fsf@gnu.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="hxfjp2rds47b22yn" Content-Disposition: inline In-Reply-To: <874kpzgqh5.fsf@gnu.org> X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -1.0 (-) X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Spam-Score: -2.61 X-TUID: fNmO3wnIyJIF --hxfjp2rds47b22yn Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Jul 23, 2020 at 12:00:22AM +0200, Ludovic Court=C3=A8s wrote: > Hello, >=20 > Jakub K=C4=85dzio=C5=82ka skribis: >=20 > > * gnu/packages/commencement.scm > > (glibc-final-with-bootstrap-bash)[arguments]: Don't patch sunrpc, > > as it's no longer required. Tweak C_INCLUDE_PATH and > > CPLUS_INCLUDE_PATH instead of CPATH. > > --- > > > > Hi Guix, > > > > I have stumbled upon this phase while I was working on making substitute > > not fail silently. Turns out this substitution is no longer necessary > > since we aren't building with --enable-obsolete-rpc anymore. I'm not > > sure about the unsetenv parts, though. Switching them to > > {C,CPLUS}_INCLUDE_PATH, which is where the header paths actually are > > right now, did not change how `guix graph --type=3Dreferences` looks for > > glibc-final (nor glibc-final-with-bootstrap-bash, for that matter). > > > > The phase itself was introduced in... > > > > commit 1c93be5600fb90a64cbbdf7a55061902d2ff150a > > Author: Ludovic Court=C3=A8s > > Date: Sat Jun 7 17:23:53 2014 +0200 > > > > gnu: glibc: Make sure the bootstrap libc is not in $CPATH. > > > > This fixes a bug whereby the bootstrap-glibc headers could be picke= d up > > when building libc.so, which could be noticed by the fact that the > > .debug files contained references to bootstrap-glibc. > > > > * gnu/packages/base.scm (glibc-final-with-bootstrap-bash)[arguments= ]: > > Add 'pre-configure' phase. > > [inputs]: Remove 'alist-delete' call. > > > > The debug output does not refer to a bootstrap glibc anymore whether th= e phase > > is there or not, though it does refer to gcc-cross-boot0:lib. Does this > > mean that the phase is simply obsolete, and only the hurd parts should > > remain, or is the reference to gcc a bug? Perhaps gcc should have a > > separate output for the includes it provides (stdarg and such) so that > > this reference doesn't bring in the whole mesboot tree? This would > > improve the closure of gcc-toolchain:debug... >=20 > Oooh, nice. LGTM! Thanks for your review! > Please confirm that nothing breaks (everything builds at least up to > =E2=80=98gcc-final=E2=80=99) and you can push to =E2=80=98core-updates=E2= =80=99. I have confirmed that hello builds both natively and cross-built. On a similar topic, the same test succeeded for removing the native-gcc input. As the comment suggests, it was only being used for --enable-obsolete-rpc. I am thus considering a v2 that also removes said input. Does that make sense? Regards, Jakub K=C4=85dzio=C5=82ka --hxfjp2rds47b22yn Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEE5Xa/ss9usT31cTO54xWnWEYTFWQFAl8Yv6AACgkQ4xWnWEYT FWQVcg/8Daopa7etOE3jME3v7Yt6+4GfShS4XPcSvSYOu6PqxM7aVwk6wsg4Fo/X zC7yI/ar/T6zd0uBJRAL1Q9QI8mr5hEQ7aCH1QQMEVNE/PsVSFFFGBdyOk8rlsI3 sZw2H2GTUdDNDQ9pA4iU1ETPOZlBqWprFkYc3USfE2sNcu4Y2ZJgKdmUUObdeCST HQhMo9E3fpm0CORANM3wDHOTI7mGZVdLi2i6OzqVRzYczVXatsFMAAm9XhwW8J2y FKt0KUKKEBEseb6R2ir9PISAZx6oBpP/b6RAnSzy/vM3BUU7vVvqhjmGM+m4NunF V/0+4jc+VJ1BD12X+Z/wHcfTFh6pI0sJCAdj1oKSgEuhoGzJ+5LLLRrLgyBUcuxy kWFM7bEP154duFUqahaLnNnUcjCs/SpV+R7UDJSUFT+NSs9pyXK31O783pLtPuxz iyoMozQTlkmyqHvxuoLxT1dhCMa5fc5J87Cx5nTQB3HFO0UMUcHwAYYRLRSHVlh5 xw0AF/4UdzyA9c72mJCOgcSP4FixDnus9p5+Eq1gxedu/GpRuNjacF+mhdClgX/A afBpjq2VKXxtNJA/vVwD4FYn5/FIka7ylyWusHKAIGQIEluBeDZ9G/vfE7UYFaFi GQgbJs6cq2K+U50v+tB+pclUK2ycRCoXtpAgwGNlU4oaqJihX+Y= =sNVr -----END PGP SIGNATURE----- --hxfjp2rds47b22yn--