From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id 2IJIIHFeF19PIAAA0tVLHw (envelope-from ) for ; Tue, 21 Jul 2020 21:30:25 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id IMtSHHFeF18bYgAAB5/wlQ (envelope-from ) for ; Tue, 21 Jul 2020 21:30:25 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 28F2C94077B for ; Tue, 21 Jul 2020 21:30:25 +0000 (UTC) Received: from localhost ([::1]:56398 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jxzqC-0006RK-4P for larch@yhetil.org; Tue, 21 Jul 2020 17:30:24 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:54902) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jxzpq-0006Qx-F5 for guix-patches@gnu.org; Tue, 21 Jul 2020 17:30:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:57247) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jxzpq-0007vX-5Y for guix-patches@gnu.org; Tue, 21 Jul 2020 17:30:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jxzpq-0001mY-0K for guix-patches@gnu.org; Tue, 21 Jul 2020 17:30:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#42335] [PATCH guix-past] Add old versions of RGBDS Resent-From: Jakub =?UTF-8?Q?K=C4=85dzio=C5=82ka?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 21 Jul 2020 21:30:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 42335 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: 42335@debbugs.gnu.org Received: via spool by 42335-submit@debbugs.gnu.org id=B42335.15953669486760 (code B ref 42335); Tue, 21 Jul 2020 21:30:01 +0000 Received: (at 42335) by debbugs.gnu.org; 21 Jul 2020 21:29:08 +0000 Received: from localhost ([127.0.0.1]:40557 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jxzoy-0001kx-DK for submit@debbugs.gnu.org; Tue, 21 Jul 2020 17:29:08 -0400 Received: from pat.zlotemysli.pl ([37.59.186.212]:49574) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jxzow-0001kn-5M for 42335@debbugs.gnu.org; Tue, 21 Jul 2020 17:29:06 -0400 Received: (qmail 2558 invoked by uid 1009); 21 Jul 2020 23:29:04 +0200 Received: from user-94-254-206-182.play-internet.pl (kuba@kadziolka.net@user-94-254-206-182.play-internet.pl) by pat.zlotemysli.pl (envelope-from , uid 1002) with qmail-scanner-2.08st (clamdscan: 0.98.6/25879. spamassassin: 3.4.0. perlscan: 2.08st. Clear:RC:1(94.254.206.182):. Processed in 0.072445 secs); 21 Jul 2020 21:29:04 -0000 Received: from user-94-254-206-182.play-internet.pl (HELO gravity) (kuba@kadziolka.net@94.254.206.182) by pat.zlotemysli.pl with SMTP; 21 Jul 2020 23:29:04 +0200 Date: Tue, 21 Jul 2020 23:29:01 +0200 From: Jakub =?UTF-8?Q?K=C4=85dzio=C5=82ka?= Message-ID: <20200721212901.62cphwttdurjdyda@gravity> References: <20200712160206.6768-1-kuba@kadziolka.net> <87v9ign7zy.fsf@gnu.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="hxr6qpw5hcan26xr" Content-Disposition: inline In-Reply-To: <87v9ign7zy.fsf@gnu.org> X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -1.0 (-) X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Spam-Score: -2.61 X-TUID: kbIgaUvhMYrr --hxr6qpw5hcan26xr Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Jul 21, 2020 at 06:33:05PM +0200, Ludovic Court=C3=A8s wrote: > Hi Jakub, >=20 > Jakub K=C4=85dzio=C5=82ka skribis: >=20 > > * modules/past/packages/assembly.scm: New file. > > --- > > > > This patch adds quite a few old versions of RGBDS. The project has quite > > a history of small, possibly accidental breaking changes. As a > > measurement of the necessity of this many different versions, I looked > > into the git history of the Game Boy homebrew project that inspired this > > addition. > > > > The repository (which is unfortunately private) goes back to the days > > of 0.2.5, and for almost all versions in that time range, there exists > > a git commit that requires it. > > > > I am on the fence on including versions 0.3.4 and 0.3.6. Their changelog > > on GitHub was updated to warn of silent bugs with miscompilation > > potential, and are what the 'almost' above accounts for ;) > > I decided to omit them in the patch, hoping that this will prevent a > > lost soul or two from tripping over those dangerous (in terms of > > potential time loss) bugs. > > > > I did not include versions 0.1.0 and 0.1.1, as they fail to compile and > > I have no idea why. > > > > This is my first patch for guix-past, so any review remarks specific to > > pastraising are very much appreciated :) >=20 > Nothing to say, this LGTM, nice work! Thanks! > You should now have a gitlab.inria.fr account. We need to add you to > =E2=80=98.guix-authorizations=E2=80=99; will you use the same OpenPGP key= as in Guix? Nice! Yeah, I'll use the same key. Regards, Jakub K=C4=85dzio=C5=82ka --hxr6qpw5hcan26xr Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEE5Xa/ss9usT31cTO54xWnWEYTFWQFAl8XXhUACgkQ4xWnWEYT FWR1DBAAz8H75pLHtyMIQ0LAsjcnME3lx8qLyzZ/n0pvXUzmvPAmX3jG+yvSW/Dn HTX53LtmPboGbtBNYWWB0D48pTUIBHN58/mJIXkFZDH9Ry4HJPbSQ4pDcQ3iNl0M BQRdUSD+vRRt3RxPBVqlxs1JcKcJqLgoJavWYO5/znutWHyUPcbsfrxK+PtLivQ3 ZEDG5OhXhSEBAmabnkr/1FZioOmumAZzP2Cl/6qeBJIgJSMuAkUYUPKkzxFU0NUb H4N8ONXy5WiXMQL5xfv7WVAeppqVdPleyvOfaQkK81IwTmvdopNKTWLqywMa0cZ9 sMBYOYuFdZVzIEjNn/z+6BqFLXR9Kqhzgsnl0v2yB8fZ7q+B/2LVK/kpILFHNNtD HmwxWvdjbvbEIfXaJ6LPCFnR8sTc6SLC7nZUTUU9xsYoFd66VLEnlVq117AV52z9 GhFYZsBupQr3OD0GrtMYa/A2dKTDM1LIuT26JmSdZoyyUAzX7fp8BHOrNuo/kLqh WDK7J562B/Au4iudtDmBDj0eVZwZ/ZTkPWHdb6nEUsIp0cRNISDt+BQtOxe5vASy tNzQitJ1oRHpPt6YR10/bDV5IRdGTP1kAGZKfMZBP6WQZZHOpJa8h/8f4WBktWKE XYmTsyXiQBP5ycAbPh4OaP+ftwosHSBwlOmIBDccmn3DRecHjsc= =DQXs -----END PGP SIGNATURE----- --hxr6qpw5hcan26xr--