From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id YDyIA1xpFV/aNAAA0tVLHw (envelope-from ) for ; Mon, 20 Jul 2020 09:52:28 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id 8EgsO1tpFV/xbQAA1q6Kng (envelope-from ) for ; Mon, 20 Jul 2020 09:52:27 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 2D5389403C9 for ; Mon, 20 Jul 2020 09:52:27 +0000 (UTC) Received: from localhost ([::1]:40746 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jxSTC-0007E6-4j for larch@yhetil.org; Mon, 20 Jul 2020 05:52:26 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:34822) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jxSSo-0007Dn-PL for bug-guix@gnu.org; Mon, 20 Jul 2020 05:52:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:50567) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jxSSo-0006Kx-Fw for bug-guix@gnu.org; Mon, 20 Jul 2020 05:52:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jxSSo-0003b7-Eq for bug-guix@gnu.org; Mon, 20 Jul 2020 05:52:02 -0400 X-Loop: help-debbugs@gnu.org Subject: bug#41702: `guix environment` performance issues Resent-From: Lars-Dominik Braun Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Mon, 20 Jul 2020 09:52:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 41702 X-GNU-PR-Package: guix X-GNU-PR-Keywords: patch To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Received: via spool by 41702-submit@debbugs.gnu.org id=B41702.159523867013717 (code B ref 41702); Mon, 20 Jul 2020 09:52:02 +0000 Received: (at 41702) by debbugs.gnu.org; 20 Jul 2020 09:51:10 +0000 Received: from localhost ([127.0.0.1]:33864 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jxSRy-0003Z9-4r for submit@debbugs.gnu.org; Mon, 20 Jul 2020 05:51:10 -0400 Received: from mail-wm1-f51.google.com ([209.85.128.51]:35382) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jxSRv-0003Yi-4X for 41702@debbugs.gnu.org; Mon, 20 Jul 2020 05:51:08 -0400 Received: by mail-wm1-f51.google.com with SMTP id l2so24554276wmf.0 for <41702@debbugs.gnu.org>; Mon, 20 Jul 2020 02:51:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=leibniz-psychology-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=ob4xu2FSoalsz6iiOGLUWCFQEW2nGyZf/aFqadauDw4=; b=F++IhODkPCX5glsN1QLZBLKLB89Mv1JWedl1vbJ8E6aRwOX2AQ9WHkqMbeIjPd6lwL jXHM10559IRExgUyIDHMgsddAjA0ijiv6cIXjA256lbm35ZqNQh7OdpTvulKPAn3IBkK UlPvlwr/XEmheaTwqMYrVts9XQoWEfosipxrHp86Lwhfg1QPR5En/yPRNIXHQOe/NL2N sIYHkXmIM+IfPoM8mVW/YoJsu0Rlts3ABKVHCsaCygWJPyuRLHucV9Ds2djMM8BbNJOp H/iLUrUZ+YEgoG1wU8EIqpu9sK1MtAUpnncHb+lcJAq7tIGYvctt2fL4SS2OVf7+VZck JDwg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=ob4xu2FSoalsz6iiOGLUWCFQEW2nGyZf/aFqadauDw4=; b=Q0NUnJyzNeTM1niuAoFy+hGV/yWayCaQmN7f4Bh7MCWatkuTo7JfdbefqMEOoJylQb kP9WyyKJ0dxm6HQC9xInktlnlh5A5g0dKYfBnKoj8CmyNEYN6L/eW3/DQWHJmw2fF/4i 9nRsyC3eIp1IJcJWz62Vs0ul1DWKsqXhUPikLkl9o3x5mAaEbGgBlj6pTUtH/O/+qrN6 pBgQxd4TyHt4O4mEO4wWMDxJcMKjww/Aze/x2xs26WAh9zzkcso8vOI41suk8ElOpyG7 ED1IVequDQl4gxdj5Ya3KQZkdnjbkYphNPQlXggzhA7K9Sku7xYqcgRmDE3v9Co9ZLl6 90Ew== X-Gm-Message-State: AOAM533bU9vf6Bsje5nry7tJ0tlcsGbSM3F/PVGnXK/0xvCUXdcS6woy oijflgF7xDUjyAl+KCmqtHM/uD7zzfrsfDvW8Clu13oWhFXoXPzwMvdW3x12ph4FE9jYlwUADiH bfUGlpW2MeBEsB5nHEQEF3R2AJ0lze50nilOiQgZ6QjH4TlcTXF/plNTGnvgdiGBwjX0W5tNOv5 uVM5Me873P X-Google-Smtp-Source: ABdhPJwtWIaPBZBgi2I7ov9rMPdo01Jnf7LMtTRR8V+16cHfQgdDPpBEWg2LduYf+OvPDtgQbNT0BA== X-Received: by 2002:a7b:c94a:: with SMTP id i10mr21837654wml.183.1595238661035; Mon, 20 Jul 2020 02:51:01 -0700 (PDT) Received: from localhost (dynamic-2a01-0c22-c82f-7100-d8d0-ddb1-e2de-8de9.c22.pool.telefonica.de. [2a01:c22:c82f:7100:d8d0:ddb1:e2de:8de9]) by smtp.gmail.com with ESMTPSA id n3sm21077077wre.29.2020.07.20.02.51.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Jul 2020 02:51:00 -0700 (PDT) Date: Mon, 20 Jul 2020 11:50:59 +0200 From: Lars-Dominik Braun Message-ID: <20200720095059.GB3143@zpidnp36> References: <87k10hp6ba.fsf@gnu.org> <20200609091522.GB8597@zpidnp36> <87wo3sjjdw.fsf@gnu.org> <87y2o3zf00.fsf@gnu.org> <20200701112453.GB25179@zpidnp36> <87eepuyk99.fsf@gnu.org> <20200702070000.GA4532@zpidnp36> <20200702120333.GB4532@zpidnp36> <87k0zhkoyf.fsf@gnu.org> <20200706125800.GA3176@zpidnp36> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="hYooF8G/hrfVAmum" Content-Disposition: inline In-Reply-To: <20200706125800.GA3176@zpidnp36> User-Agent: Mutt/1.10.1 (2018-07-13) X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -1.0 (-) X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: 41702@debbugs.gnu.org Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: "bug-Guix" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=fail (rsa verify failed) header.d=leibniz-psychology-org.20150623.gappssmtp.com header.s=20150623 header.b=F++IhODk; dmarc=none; spf=pass (aspmx1.migadu.com: domain of bug-guix-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=bug-guix-bounces@gnu.org X-Spam-Score: -0.11 X-TUID: AtuSQmlBh4K7 --hYooF8G/hrfVAmum Content-Type: multipart/mixed; boundary="JYK4vJDZwFMowpUq" Content-Disposition: inline --JYK4vJDZwFMowpUq Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi Ludo, a new version has been released, so here is the updated patchset. I=E2=80= =99m not sure if it=E2=80=99s possible to make the #:nodelay optional somehow, i.e. retai= ning compatibility with guile-ssh<0.13.0. For now there=E2=80=99s a hard feature= check. Lars --JYK4vJDZwFMowpUq Content-Type: text/x-diff; charset=us-ascii Content-Disposition: attachment; filename="0001-gnu-guile-ssh-Update-to-0.13.0.patch" Content-Transfer-Encoding: quoted-printable =46rom 42ff75c9d4da4eb2aeece96119ae5a65a9ccac82 Mon Sep 17 00:00:00 2001 =46rom: Lars-Dominik Braun Date: Mon, 20 Jul 2020 11:27:35 +0200 Subject: [PATCH 1/2] gnu: guile-ssh: Update to 0.13.0. * gnu/packages/ssh.scm (guile-ssh): Update to 0.13.0. --- gnu/packages/ssh.scm | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/gnu/packages/ssh.scm b/gnu/packages/ssh.scm index a612b9dd15..50316ea1be 100644 --- a/gnu/packages/ssh.scm +++ b/gnu/packages/ssh.scm @@ -297,7 +297,7 @@ Additionally, various channel-specific options can be n= egotiated.") (define-public guile-ssh (package (name "guile-ssh") - (version "0.12.0") + (version "0.13.0") (home-page "https://github.com/artyom-poptsov/guile-ssh") (source (origin (method git-fetch) @@ -307,7 +307,7 @@ Additionally, various channel-specific options can be n= egotiated.") (file-name (string-append name "-" version ".tar.gz")) (sha256 (base32 - "054hd9rzfhb48gc1hw3rphhp0cnnd4bs5qmidy5ygsyvy9ravlad")) + "1q96h98p6x7ah6nc0d2wfx503fmsj36riv9ka9s79z3lzwaf0k26")) (modules '((guix build utils))))) (build-system gnu-build-system) (outputs '("out" "debug")) --=20 2.20.1 --JYK4vJDZwFMowpUq Content-Type: text/x-diff; charset=us-ascii Content-Disposition: attachment; filename="0002-guix-Speed-up-RPC-via-SSH-connections.patch" Content-Transfer-Encoding: quoted-printable =46rom 6a18c9a4533075d1ee9795777a998fde3e64030f Mon Sep 17 00:00:00 2001 =46rom: Lars-Dominik Braun Date: Mon, 20 Jul 2020 11:28:51 +0200 Subject: [PATCH 2/2] guix: Speed up RPC via SSH connections. See issue #41702 * guix/ssh.scm (open-ssh-session): Enable #:nodelay. * m4/guix.m4 (GUIX_CHECK_GUILE_SSH): Add feature check for this new paramet= er. --- guix/ssh.scm | 5 ++++- m4/guix.m4 | 6 ++++-- 2 files changed, 8 insertions(+), 3 deletions(-) diff --git a/guix/ssh.scm b/guix/ssh.scm index 2d7ca7d01d..3bffb0b525 100644 --- a/guix/ssh.scm +++ b/guix/ssh.scm @@ -129,7 +129,10 @@ Throw an error on failure." ;; We need lightweight compression when ;; exchanging full archives. #:compression compression - #:compression-level 3))) + #:compression-level 3 + + ;; Speed up RPC. + #:nodelay #t))) =20 ;; Honor ~/.ssh/config. (session-parse-config! session) diff --git a/m4/guix.m4 b/m4/guix.m4 index 7c27ae74df..cce03045db 100644 --- a/m4/guix.m4 +++ b/m4/guix.m4 @@ -142,14 +142,16 @@ dnl GUIX_CHECK_GUILE_SSH dnl dnl Check whether a recent-enough Guile-SSH is available. AC_DEFUN([GUIX_CHECK_GUILE_SSH], [ - dnl Check whether 'userauth-gssapi!' (introduced in 0.12.0) is present. + dnl Check whether '#:nodelay' paramater to 'make-session' (introduced in + dnl 0.13.0) is present. AC_CACHE_CHECK([whether Guile-SSH is available and recent enough], [guix_cv_have_recent_guile_ssh], [GUILE_CHECK([retval], [(and (@ (ssh channel) channel-send-eof) (@ (ssh popen) open-remote-pipe) (@ (ssh dist node) node-eval) - (@ (ssh auth) userauth-gssapi!))]) + (@ (ssh auth) userauth-gssapi!) + ((@ (ssh session) make-session) #:nodelay #t))]) if test "$retval" =3D 0; then guix_cv_have_recent_guile_ssh=3D"yes" else --=20 2.20.1 --JYK4vJDZwFMowpUq-- --hYooF8G/hrfVAmum Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEyk+M9DfXR4/aBV/UQhN3ARo3hEYFAl8VaQAACgkQQhN3ARo3 hEakuQwA0kCZuyAU1nBpZSQcTuvhuHwbgqIkX2JBGe9oasSkakBZ5XM5dVtARCer k7lZuyd7Z6QjgUU0+yvLQ2yY05++xGx7Bh+7Cazp7LtbNjKbfTxzVUUKKbqE+qnc 5XYWSHpB7XmuP6RfbBNUtBvw6SUgkNO3mCU1FgSRgVAzFpI8uNS4nTZ8Ise8/X3d zJRimFqs5qh7gGHI1zRju346c60MhUTexJwkFgxW4UfwlIuu7wZ2WSTTNbXfehrQ w9zqDCGG8MKftYPLDE9KG1CcB0XB00ssgI7NTf/mlpQOmAizpkLK3PsyV5Cmu4NV PBAIzn12XQBUCU0brelhfiLTE0t/ueJc3oen2D18KA+Etsjy6hzhFEpfNzLoWgqU r2niVSUBGvTrwSH2iAdbWL0c2g8PbBQtx6KYoaTORH0xAc7PJcR+pq0QzbM4PSD4 V7StAoQ3hAQOPd3FFXYv2XSZ/yv8VXkJ26y7pT9tFz9e+NsOgnD6JyYy3wK8LRWj CPdtRngb =eeqN -----END PGP SIGNATURE----- --hYooF8G/hrfVAmum--