From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id 0MlOOj80C1+pOAAA0tVLHw (envelope-from ) for ; Sun, 12 Jul 2020 16:03:11 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id cGASNj80C18odgAA1q6Kng (envelope-from ) for ; Sun, 12 Jul 2020 16:03:11 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 852BC940BC9 for ; Sun, 12 Jul 2020 16:03:09 +0000 (UTC) Received: from localhost ([::1]:43342 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jueRY-0000R5-Gm for larch@yhetil.org; Sun, 12 Jul 2020 12:03:08 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:40782) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jueRS-0000Qw-3z for guix-patches@gnu.org; Sun, 12 Jul 2020 12:03:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:35112) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jueRR-0004HJ-RH for guix-patches@gnu.org; Sun, 12 Jul 2020 12:03:01 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jueRR-0002qN-Oa for guix-patches@gnu.org; Sun, 12 Jul 2020 12:03:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#42335] [PATCH guix-past] Add old versions of RGBDS Resent-From: Jakub =?UTF-8?Q?K=C4=85dzio=C5=82ka?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 12 Jul 2020 16:03:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 42335 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 42335@debbugs.gnu.org X-Debbugs-Original-To: guix-patches@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.159456974910867 (code B ref -1); Sun, 12 Jul 2020 16:03:01 +0000 Received: (at submit) by debbugs.gnu.org; 12 Jul 2020 16:02:29 +0000 Received: from localhost ([127.0.0.1]:46651 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jueQv-0002pC-9t for submit@debbugs.gnu.org; Sun, 12 Jul 2020 12:02:29 -0400 Received: from lists.gnu.org ([209.51.188.17]:58858) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jueQs-0002p4-Kw for submit@debbugs.gnu.org; Sun, 12 Jul 2020 12:02:27 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:40696) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jueQs-0000L7-DV for guix-patches@gnu.org; Sun, 12 Jul 2020 12:02:26 -0400 Received: from pat.zlotemysli.pl ([37.59.186.212]:45432) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jueQn-0004B7-SA for guix-patches@gnu.org; Sun, 12 Jul 2020 12:02:26 -0400 Received: (qmail 16110 invoked by uid 1009); 12 Jul 2020 18:02:13 +0200 Received: from 188.123.215.55 (kuba@kadziolka.net@188.123.215.55) by pat.zlotemysli.pl (envelope-from , uid 1002) with qmail-scanner-2.08st (clamdscan: 0.98.6/25870. spamassassin: 3.4.0. perlscan: 2.08st. Clear:RC:1(188.123.215.55):. Processed in 0.065558 secs); 12 Jul 2020 16:02:13 -0000 Received: from unknown (HELO localhost.localdomain) (kuba@kadziolka.net@188.123.215.55) by pat.zlotemysli.pl with AES256-SHA encrypted SMTP; 12 Jul 2020 18:02:12 +0200 From: Jakub =?UTF-8?Q?K=C4=85dzio=C5=82ka?= Date: Sun, 12 Jul 2020 18:02:06 +0200 Message-Id: <20200712160206.6768-1-kuba@kadziolka.net> X-Mailer: git-send-email 2.27.0 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Received-SPF: none client-ip=37.59.186.212; envelope-from=kuba@kadziolka.net; helo=pat.zlotemysli.pl X-detected-operating-system: by eggs.gnu.org: First seen = 2020/07/12 12:02:13 X-ACL-Warn: Detected OS = Linux 3.11 and newer X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_PASS=-0.001, SPF_NONE=0.001, URIBL_BLOCKED=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -3.3 (---) X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Spam-Score: -0.01 X-TUID: 3mnt2kZZhl3E * modules/past/packages/assembly.scm: New file. --- This patch adds quite a few old versions of RGBDS. The project has quite a history of small, possibly accidental breaking changes. As a measurement of the necessity of this many different versions, I looked into the git history of the Game Boy homebrew project that inspired this addition. The repository (which is unfortunately private) goes back to the days of 0.2.5, and for almost all versions in that time range, there exists a git commit that requires it. I am on the fence on including versions 0.3.4 and 0.3.6. Their changelog on GitHub was updated to warn of silent bugs with miscompilation potential, and are what the 'almost' above accounts for ;) I decided to omit them in the patch, hoping that this will prevent a lost soul or two from tripping over those dangerous (in terms of potential time loss) bugs. I did not include versions 0.1.0 and 0.1.1, as they fail to compile and I have no idea why. This is my first patch for guix-past, so any review remarks specific to pastraising are very much appreciated :) Regards, Jakub Kądziołka modules/past/packages/assembly.scm | 157 +++++++++++++++++++++++++++++ 1 file changed, 157 insertions(+) create mode 100644 modules/past/packages/assembly.scm diff --git a/modules/past/packages/assembly.scm b/modules/past/packages/assembly.scm new file mode 100644 index 0000000..8b6e4e0 --- /dev/null +++ b/modules/past/packages/assembly.scm @@ -0,0 +1,157 @@ +;;; Guix Past --- Packages from the past for GNU Guix. +;;; Copyright © 2020 Jakub Kądziołka +;;; +;;; This file is part of Guix Past. +;;; +;;; Guix Past is free software; you can redistribute it and/or modify it +;;; under the terms of the GNU General Public License as published by +;;; the Free Software Foundation; either version 3 of the License, or (at +;;; your option) any later version. +;;; +;;; Guix Past is distributed in the hope that it will be useful, but +;;; WITHOUT ANY WARRANTY; without even the implied warranty of +;;; MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +;;; GNU General Public License for more details. +;;; +;;; You should have received a copy of the GNU General Public License +;;; along with Guix Past. If not, see . + +(define-module (past packages assembly) + #:use-module (guix) + #:use-module (guix git-download) + #:use-module ((guix licenses) #:prefix license:) + #:use-module (gnu packages assembly)) + +(define (rgbds-with-version version source-hash) + (package + (inherit rgbds) + (name "rgbds") + (version version) + (source (origin + (method git-fetch) + (uri (git-reference + (url "https://github.com/rednex/rgbds.git") + (commit (string-append "v" version)))) + (file-name (git-file-name name version)) + (sha256 (base32 source-hash)))))) + +;; The tests are failing for the 0.2 releases, the ones before 0.2.3 don't even +;; provide them +(define (without-tests base-rgbds) + (package + (inherit base-rgbds) + (arguments + (substitute-keyword-arguments (package-arguments base-rgbds) + ((#:phases phases) + `(modify-phases ,phases + (delete 'check))))))) + +;; RGBDS versions before 0.1.2 fail to build. + +(define-public rgbds-0.1.2 + (let ((base-rgbds + (rgbds-with-version + "0.1.2" "1haqswx50hsgfanz9j17y437ciwvbq8lpw445zfiqipawh45a415"))) + (package + (inherit (without-tests base-rgbds)) + (license (license:non-copyleft "file://LICENSE"))))) + +(define-public rgbds-0.2.0 + (let ((base-rgbds + (rgbds-with-version + "0.2.0" "1q9jci95jrvgc2cyzpsskx92l4m3sv3jyy59bmld3qhqh3nw6jwd"))) + (package + (inherit (without-tests base-rgbds)) + (license (license:non-copyleft "file://LICENSE"))))) + +(define-public rgbds-0.2.1 + (let ((base-rgbds + (rgbds-with-version + "0.2.1" "06hxdq4b9y4bd8c89x4baia18s34814jikgj86d0hjxkqx4ki204"))) + (package + (inherit (without-tests base-rgbds)) + (license (license:non-copyleft "file://LICENSE"))))) + +(define-public rgbds-0.2.2 + (let ((base-rgbds + (rgbds-with-version + "0.2.2" "0ga6myr737wxvbldm886chxca2d6i5jnbzqac0xakf87il1i6kb3"))) + (package + (inherit (without-tests base-rgbds)) + (license (license:non-copyleft "file://LICENSE"))))) + +(define-public rgbds-0.2.3 + (let ((base-rgbds + (rgbds-with-version + "0.2.3" "05fkqrn0fiins61aq3iwzmkm0ii5ihqskv2xv0wk8xd8fp4j2ga1"))) + (package + (inherit (without-tests base-rgbds)) + (license (license:non-copyleft "file://LICENSE"))))) + +(define-public rgbds-0.2.4 + (let ((base-rgbds + (rgbds-with-version + "0.2.4" "0dwq0p9g1lci8sm12a2rfk0g33z2vr75x78zdf1g84djwbz8ipc6"))) + (package + (inherit (without-tests base-rgbds)) + (license (license:non-copyleft "file://LICENSE"))))) + +(define-public rgbds-0.2.5 + (let ((base-rgbds + (rgbds-with-version + "0.2.5" "11lri6p1pr3byxrmbz542263587smb4czq46vr1kyn94lxa3ikbp"))) + (package + (inherit (without-tests base-rgbds)) + (license (license:non-copyleft "file://LICENSE"))))) + +(define-public rgbds-0.3.0 + (let ((base-rgbds + (rgbds-with-version + "0.3.0" "19gk9lakrpn46waxvd4v8fa86xig006r1xvhgqw2acdc50xnxqmk"))) + (package + (inherit base-rgbds) + (license (license:non-copyleft "file://LICENSE.md"))))) + +(define-public rgbds-0.3.1 + (let ((base-rgbds + (rgbds-with-version + "0.3.1" "1bx5yhdyp22q3k9x2kly54pmq78aikx8pmygbhz34mgv8n5w4qss"))) + (package + (inherit base-rgbds) + (license (license:non-copyleft "file://LICENSE.md"))))) + +(define-public rgbds-0.3.2 + (let ((base-rgbds + (rgbds-with-version + "0.3.2" "034l1xqp46h7yjgbvszyky2gmvyy8cq1fcqsnj9c92mbsv81g9qh"))) + (package + (inherit base-rgbds) + (license (license:non-copyleft "file://LICENSE.md"))))) + +(define-public rgbds-0.3.3 + (let ((base-rgbds + (rgbds-with-version + "0.3.3" "1dsw01ylbfqjbwv13n6yxjyakqmlfsvmlzv6h83df5mpix6mjfxv"))) + (package + (inherit base-rgbds) + (license (license:non-copyleft "file://LICENSE.md"))))) + +;; Skipping 0.3.4 and 0.3.6: potentially silent bugs mentioned in release notes, +;; and the releases are short-lived. + +(define-public rgbds-0.3.5 + (rgbds-with-version "0.3.5" "1wxrvqrwg72rys4jhsk7id7lmvv40gw6xpn4sg29f8alfpc2bsry")) + +(define-public rgbds-0.3.7 + (rgbds-with-version "0.3.7" "1bj082zi8lxrkkbsg5kvx6k1hkl156pqbxpblpidamk6qxqyssb9")) + +(define-public rgbds-0.3.8 + (rgbds-with-version "0.3.8" "0db37z886026svhj6qnc3wk56sndbnz1vi41gn2k3bl6ppbnjlpk")) + +;; Skipping 0.3.9 - from release notes: +;; This version is missing definitions of the `__RGBDS_MAJOR__` etc. symbols. +;; Please use 0.3.10 instead, which rectifies this problem (and does not +;; introduce additional changes). + +(define-public rgbds-0.3.10 + (rgbds-with-version "0.3.10" "0752fbffxgxyf3jw2iij88l05dqhppgcxy7dvk82hp4wdg4cflpq")) -- 2.27.0