From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id QBgEA9+e4l72dAAA0tVLHw (envelope-from ) for ; Thu, 11 Jun 2020 21:15:11 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id uKhpOt6e4l74YwAAbx9fmQ (envelope-from ) for ; Thu, 11 Jun 2020 21:15:10 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 60C0894036C for ; Thu, 11 Jun 2020 21:15:10 +0000 (UTC) Received: from localhost ([::1]:52176 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jjUXU-00079c-2K for larch@yhetil.org; Thu, 11 Jun 2020 17:15:08 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:43596) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jjUXO-00078B-8G for guix-patches@gnu.org; Thu, 11 Jun 2020 17:15:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:54953) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jjUXN-00042H-Ra for guix-patches@gnu.org; Thu, 11 Jun 2020 17:15:01 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jjUXN-0008MM-Mk for guix-patches@gnu.org; Thu, 11 Jun 2020 17:15:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#41804] ISO image & HFS+ tree Resent-From: Danny Milosavljevic Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 11 Jun 2020 21:15:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 41804 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: To: Mathieu Othacehe Cc: 41804@debbugs.gnu.org Received: via spool by 41804-submit@debbugs.gnu.org id=B41804.159191008732100 (code B ref 41804); Thu, 11 Jun 2020 21:15:01 +0000 Received: (at 41804) by debbugs.gnu.org; 11 Jun 2020 21:14:47 +0000 Received: from localhost ([127.0.0.1]:38266 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jjUX9-0008Lg-0Y for submit@debbugs.gnu.org; Thu, 11 Jun 2020 17:14:47 -0400 Received: from dd26836.kasserver.com ([85.13.145.193]:48742) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jjUX8-0008LY-8S for 41804@debbugs.gnu.org; Thu, 11 Jun 2020 17:14:46 -0400 Received: from localhost (80-110-127-207.cgn.dynamic.surfer.at [80.110.127.207]) by dd26836.kasserver.com (Postfix) with ESMTPSA id 3CE46336274D; Thu, 11 Jun 2020 23:14:45 +0200 (CEST) Date: Thu, 11 Jun 2020 23:14:42 +0200 From: Danny Milosavljevic Message-ID: <20200611212054.0197e959@scratchpost.org> In-Reply-To: <87mu59llxr.fsf@gnu.org> References: <87mu59llxr.fsf@gnu.org> X-Mailer: Claws Mail 3.17.5 (GTK+ 2.24.32; x86_64-unknown-linux-gnu) MIME-Version: 1.0 Content-Type: multipart/signed; boundary="Sig_/muLDbuaef8NRaJfRgO=Dvk."; protocol="application/pgp-signature"; micalg=pgp-sha512 X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -1.7 (-) X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Spam-Score: -1.11 X-TUID: yvwWIPinJeKX --Sig_/muLDbuaef8NRaJfRgO=Dvk. Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable Hi Mathieu, thanks for On Thu, 11 Jun 2020 16:24:48 +0200 Mathieu Othacehe wrote: > Here's a patch that disables HFS+ tree production, and the solves the > problem above. Thanks for the investigation and fix! What do you think about putting the comment into the source code? ;; Producing an HFS tree via "mbr_hfs" would fail if a directory has more t= han ;; 30720 files. The xorriso error message is: ;; xorriso : UPDATE : 434919 files added in 18 seconds ;; libisofs: FAILURE : HFS+ map nodes aren't implemented ;; libisofs: FAILURE : Too much files to mangle, cannot guarantee unique fi= le ;; names. ;; So we use "mbr_only" mode to make sure that no HFS+ tree is generated. '(("MKRESCUE_SED_MODE" . "mbr_only"))))))) You can remove it from the commit message, or not (I would). In any case I'd rather not have to read the source code *and* all commit messages once some problem appears. I think it's as important to know what not to do as it is to know what is possible--especially for something as obscure as that. So I for one would welcome a comment in the source code of what already caused problems, even re-adding the problem as a comment. Otherwise LGTM! --Sig_/muLDbuaef8NRaJfRgO=Dvk. Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEds7GsXJ0tGXALbPZ5xo1VCwwuqUFAl7insIACgkQ5xo1VCww uqU1Igf/bGzRC+Fp6dqyuVxrbz5hItkSHFojEjXDmTZVUYlCwFtYZi3BCJJddFu3 Wk5tzlNxSTVYz3YxA4JYBMoCFAUD2b/vIKPjjN4wvJjB0sq53YA5aiPFSonhL37h UVX0TBF9glGgrZD5QSx6pb/XgDCdLNHfHC7pY8caQxCDFoiCn8zyfbyQ88MGk+PY 6iAO2fC7/MscMXpL1bE3lQv7m5fgOJy4qPrkGbf5hLfiUbLy2iylHqhRO7dM5ipc tGblZAshfDViFpM3kzwrEen/fEjLrBugBMkL1FPz3wJFD68I2RnAoAITZ6QTA+mR GOK10yslJ4tC+ktaQTXFpmreIionAA== =kVmr -----END PGP SIGNATURE----- --Sig_/muLDbuaef8NRaJfRgO=Dvk.--