From: Danny Milosavljevic <dannym@scratchpost.org>
To: Mathieu Othacehe <othacehe@gnu.org>
Cc: 41804@debbugs.gnu.org
Subject: [bug#41804] ISO image & HFS+ tree
Date: Thu, 11 Jun 2020 23:14:42 +0200 [thread overview]
Message-ID: <20200611212054.0197e959@scratchpost.org> (raw)
In-Reply-To: <87mu59llxr.fsf@gnu.org>
[-- Attachment #1: Type: text/plain, Size: 1225 bytes --]
Hi Mathieu,
thanks for On Thu, 11 Jun 2020 16:24:48 +0200
Mathieu Othacehe <othacehe@gnu.org> wrote:
> Here's a patch that disables HFS+ tree production, and the solves the
> problem above.
Thanks for the investigation and fix!
What do you think about putting the comment into the source code?
;; Producing an HFS tree via "mbr_hfs" would fail if a directory has more than
;; 30720 files. The xorriso error message is:
;; xorriso : UPDATE : 434919 files added in 18 seconds
;; libisofs: FAILURE : HFS+ map nodes aren't implemented
;; libisofs: FAILURE : Too much files to mangle, cannot guarantee unique file
;; names.
;; So we use "mbr_only" mode to make sure that no HFS+ tree is generated.
'(("MKRESCUE_SED_MODE" . "mbr_only")))))))
You can remove it from the commit message, or not (I would).
In any case I'd rather not have to read the source code *and* all commit
messages once some problem appears.
I think it's as important to know what not to do as it is to know what is
possible--especially for something as obscure as that.
So I for one would welcome a comment in the source code of what already
caused problems, even re-adding the problem as a comment.
Otherwise LGTM!
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2020-06-11 21:15 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-11 14:24 [bug#41804] ISO image & HFS+ tree Mathieu Othacehe
2020-06-11 21:14 ` Danny Milosavljevic [this message]
2020-06-12 15:24 ` bug#41804: " Mathieu Othacehe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200611212054.0197e959@scratchpost.org \
--to=dannym@scratchpost.org \
--cc=41804@debbugs.gnu.org \
--cc=othacehe@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.