From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id 8AqQM1aV115bbAAA0tVLHw (envelope-from ) for ; Wed, 03 Jun 2020 12:19:34 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id SL5lL1aV115EZgAA1q6Kng (envelope-from ) for ; Wed, 03 Jun 2020 12:19:34 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 6D67E94042C for ; Wed, 3 Jun 2020 12:19:34 +0000 (UTC) Received: from localhost ([::1]:51270 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jgSMn-0007Q4-F6 for larch@yhetil.org; Wed, 03 Jun 2020 08:19:33 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:45300) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jgSMI-0006zW-8q for guix-patches@gnu.org; Wed, 03 Jun 2020 08:19:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:59038) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jgSMH-0001kp-V8 for guix-patches@gnu.org; Wed, 03 Jun 2020 08:19:01 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jgSMH-0001ux-RU for guix-patches@gnu.org; Wed, 03 Jun 2020 08:19:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#41637] [PATCH] gnu: Add hashcash. Resent-From: Jakub =?UTF-8?Q?K=C4=85dzio=C5=82ka?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 03 Jun 2020 12:19:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 41637 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Mathieu Othacehe Cc: 41637@debbugs.gnu.org Received: via spool by 41637-submit@debbugs.gnu.org id=B41637.15911866927311 (code B ref 41637); Wed, 03 Jun 2020 12:19:01 +0000 Received: (at 41637) by debbugs.gnu.org; 3 Jun 2020 12:18:12 +0000 Received: from localhost ([127.0.0.1]:42351 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jgSLT-0001tq-W8 for submit@debbugs.gnu.org; Wed, 03 Jun 2020 08:18:12 -0400 Received: from pat.zlotemysli.pl ([37.59.186.212]:33556) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jgSLS-0001tj-8l for 41637@debbugs.gnu.org; Wed, 03 Jun 2020 08:18:10 -0400 Received: (qmail 9039 invoked by uid 1009); 3 Jun 2020 14:18:07 +0200 Received: from 188.123.215.55 (kuba@kadziolka.net@188.123.215.55) by pat.zlotemysli.pl (envelope-from , uid 1002) with qmail-scanner-2.08st (clamdscan: 0.98.6/25831. spamassassin: 3.4.0. perlscan: 2.08st. Clear:RC:1(188.123.215.55):. Processed in 0.053749 secs); 03 Jun 2020 12:18:07 -0000 Received: from unknown (HELO gravity) (kuba@kadziolka.net@188.123.215.55) by pat.zlotemysli.pl with SMTP; 3 Jun 2020 14:18:07 +0200 Date: Wed, 3 Jun 2020 14:18:06 +0200 From: Jakub =?UTF-8?Q?K=C4=85dzio=C5=82ka?= Message-ID: <20200603121806.hynak7rp3o5jnhsy@gravity> References: <20200601004015.21684-1-kuba@kadziolka.net> <87blm07i50.fsf@gnu.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="ezggses3dzz3yzlk" Content-Disposition: inline In-Reply-To: <87blm07i50.fsf@gnu.org> X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -1.0 (-) X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Spam-Score: -2.61 X-TUID: gHTcI2Y04OiV --ezggses3dzz3yzlk Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Jun 03, 2020 at 08:55:39AM +0200, Mathieu Othacehe wrote: >=20 > Hey Jakub, >=20 > Thanks for fixing the cross-compilation, a full review this time :) >=20 > > + (let* ((outdir (assoc-ref outputs "out")) > > + (bindir (string-append outdir "/bin")) > > + (mandir (string-append outdir "/share/man/man1")) > > + (docdir (string-append outdir "/share/doc/hashcash= -" ,version))) > > + ;; make install assumes /usr and doesn't provide a way = to override it > > + (install-file "hashcash" bindir) > > + (install-file "hashcash.1" mandir) > > + (install-file "README" docdir) > > + (install-file "LICENSE" docdir) > > + (install-file "CHANGELOG" docdir) >=20 > I think you can set the variables INSTALL_PATH, MAN_INSTALL_PATH and > DOC_INSTALL_PATH instead. Unfortunately, the variables are defined with `=3D` instead of `?=3D`, so the Makefile always overwrites them. We would also want to skip installing the `sha1' tool like Debian does, since `sha1sum' is already a thing. > > + #t)))))) > > + (home-page "https://www.hashcash.org/") > > + (synopsis "Denial-of-service countermeasure") > > + (description "Hashcash is a proof-of-work algorithm, which has bee= n used > > +as a denial-of-service countermeasure technique in a number of systems. >=20 > You can remove "in a number of systems". >=20 > > +A hashcash stamp constitutes a proof-of-work which takes a parametriza= ble > > +amount of work to compute for the sender. The recipient can verify re= ceived > > +hashcash stamps efficiently. > > + > > +This package contains a command-line tool for computing and verifying = hashcash > > +stamps.") > > + (license license:public-domain))) >=20 > I'm also concerned by this line in the Makefile: >=20 > --8<---------------cut here---------------start------------->8--- > # request static link of -lcrypto only > LIBCRYPTO=3D/usr/lib/libcrypto.a > --8<---------------cut here---------------end--------------->8--- >=20 > We should maybe add "openssl" to the inputs and fix this variable > (that's what Nix does). =46rom what I've read, openssl is not used by default, but only when a target like `gnu-openssl' is used. I'll make a build with openssl and benchmark which is faster... Regards, Jakub K=C4=85dzio=C5=82ka --ezggses3dzz3yzlk Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEE5Xa/ss9usT31cTO54xWnWEYTFWQFAl7XlP0ACgkQ4xWnWEYT FWQCZg/+PUimgJlbpmBcHhDvathlTwEunBpjwxGERnYMq2U3oHOTAEALYFUs3pB/ iUtjbVS46dPUXaf1fe47WLn4yC2JucbBQz9h/jb3c4pHUUXhOgeld/H/q1+VpzrP VV4si6X3BoqCBLFdUK2dqknSzkGemVcERol+w3G2iODCcoYB8MoeVMgHn+V4m4f3 phwZZmPRCTtYIjwSUvPbX/2F5hp7Qdw1NHhZv4cWZOfsNTcGdHSC+yL3uc6t2cSv rATFr8zr4M9lfnqyoVw9tWK9F78sw9nZyI6ZK5bEYfG7hunpwyKGPV36DzorI1xW eZk/TAswp5KvDHu9v3KFguh0oMrrKAfyelZhln961JalYwiQdOigBRsqn0FcLkps FoD+8u2+MHg5yqbQJVEj3flP5RgJ7o0Qv9poofIJVN38gk8BDX23/VPYivBTg0dN gwSJz54A7iMGsmtuyttVNlpNXNSRqE7NhaJGeT/W1F0isKocC4+1bDJN1Ay3WJh9 6fl4jDzWTaZ7HAvh9E78oXBXT2f/XhAoHgOA8Z3N+SkvibUkgAnnVd28c2LSGdbt fW3BWOCpwZimErifh/IwpMDEe6cj3kE86GPTO5UzdoJRAmYiNIvQGilsfl3aWZGL sT7lJmcm+Od8h2FlS2EH5az7r4/s76ffYJty5GZJWQwW3ZcFreU= =j2k2 -----END PGP SIGNATURE----- --ezggses3dzz3yzlk--