all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: "Jakub Kądziołka" <kuba@kadziolka.net>
To: Mathieu Othacehe <othacehe@gnu.org>
Cc: 41637@debbugs.gnu.org
Subject: [bug#41637] [PATCH] gnu: Add hashcash.
Date: Tue, 2 Jun 2020 15:25:55 +0200	[thread overview]
Message-ID: <20200602132555.pkqo4cubxwfnbjbk@gravity> (raw)
In-Reply-To: <87o8q1wtt6.fsf@gnu.org>

[-- Attachment #1: Type: text/plain, Size: 691 bytes --]

On Tue, Jun 02, 2020 at 02:12:05PM +0200, Mathieu Othacehe wrote:
> 
> Hello Jakub,
> 
> > +     `(#:make-flags '("CC=gcc")
> 
> It would be better to use "cc-for-target" here. You can check if
> cross-compilation works by running something like:
> 
> --8<---------------cut here---------------start------------->8---
> guix build --target=aarch64-linux-gnu hashcash
> --8<---------------cut here---------------end--------------->8---

Thanks! I had no idea this affects cross-compilation... I have changed
that line to be

     `(#:make-flags (list (string-append "CC=" ,(cc-for-target)))

instead. Does the rest of the patch look alright?

Regards,
Jakub Kądziołka

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

  reply	other threads:[~2020-06-02 13:26 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-01  0:40 [bug#41637] [PATCH] gnu: Add hashcash Jakub Kądziołka
2020-06-02 12:12 ` Mathieu Othacehe
2020-06-02 13:25   ` Jakub Kądziołka [this message]
2020-06-03  6:55 ` Mathieu Othacehe
2020-06-03 12:18   ` Jakub Kądziołka
2020-06-03 12:30     ` Mathieu Othacehe
2020-06-06 14:39   ` Jakub Kądziołka
2020-06-20 21:29 ` bug#41637: Done: " Jakub Kądziołka

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200602132555.pkqo4cubxwfnbjbk@gravity \
    --to=kuba@kadziolka.net \
    --cc=41637@debbugs.gnu.org \
    --cc=othacehe@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.