From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id AAnVOmgL1F6lRAAA0tVLHw (envelope-from ) for ; Sun, 31 May 2020 19:54:16 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id KKCwNmgL1F5jcQAAB5/wlQ (envelope-from ) for ; Sun, 31 May 2020 19:54:16 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 6814B940058 for ; Sun, 31 May 2020 19:54:16 +0000 (UTC) Received: from localhost ([::1]:37704 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jfU2B-0005Ny-4C for larch@yhetil.org; Sun, 31 May 2020 15:54:15 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:46328) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jfTpB-0008OA-EF for guix-devel@gnu.org; Sun, 31 May 2020 15:40:49 -0400 Received: from relay12.mail.gandi.net ([217.70.178.232]:38751) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jfTp9-0004na-Mw for guix-devel@gnu.org; Sun, 31 May 2020 15:40:48 -0400 Received: from batista.in (unknown [201.6.152.211]) (Authenticated sender: andre@batista.in) by relay12.mail.gandi.net (Postfix) with ESMTPSA id 12992200002 for ; Sun, 31 May 2020 19:40:41 +0000 (UTC) Date: Sun, 31 May 2020 16:40:30 -0300 From: =?iso-8859-1?Q?Andr=E9?= Batista To: guix-devel@gnu.org Subject: Re: [PATCH] Add Tor client only package definition Message-ID: <20200531194030.GA30215@andel> References: <20200517031127.GA17209@andel> <87y2phys3f.fsf@gnu.org> <20200526145621.GA28490@andel> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="5I6of5zJg18YgZEa" Content-Disposition: inline In-Reply-To: <20200526145621.GA28490@andel> Received-SPF: pass client-ip=217.70.178.232; envelope-from=andre@batista.in; helo=relay12.mail.gandi.net X-detected-operating-system: by eggs.gnu.org: First seen = 2020/05/31 15:40:43 X-ACL-Warn: Detected OS = Linux 3.11 and newer X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-Mailman-Approved-At: Sun, 31 May 2020 15:54:07 -0400 X-BeenThere: guix-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+larch=yhetil.org@gnu.org Sender: "Guix-devel" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-devel-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-devel-bounces@gnu.org X-Spam-Score: -2.61 X-TUID: uGRFngXhnflB --5I6of5zJg18YgZEa Content-Type: multipart/mixed; boundary="DocE+STaALJfprDB" Content-Disposition: inline --DocE+STaALJfprDB Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi Ludo, ter 26 mai 2020 =C3=A0s 11:56:21 (1590504981), nandre@riseup.net enviou: > dom 24 mai 2020 =C3=A0s 22:51:16 (1590371476), ludo@gnu.org enviou: > > It looks good to me overall! Some nitpicking: > > > > We=E2=80=99d rather use =E2=80=98substitute-keyword-arguments=E2=80=99 = to augment > > #:configure-flags without touching the other keyword arguments (there > > are several examples in the source). > > .... > > > > We generally avoid concatenating text like this, for the reasons > > explained at: > >=20 > > https://guix.gnu.org/manual/en/html_node/Synopses-and-Descriptions.ht= ml > > .... > > > > Regarding the format of patches, you can take a look at this: > >=20 > > https://guix.gnu.org/manual/en/html_node/Submitting-Patches.html >=20 > I'll send a new patch taking your warnings into account. I'm a little bit short on time, so I couldn't do everything I was supposed to. I'm sending the attached patch for your consideration, just in case someone wants to try it out, though I still need to clone the git repo, try to build it on a pre-inst-env, and try to compile on archs other than i686 and x86_64. I've run './etc/indent-code.el', guix lint and there where no errors. It might take me some time to properly set up everything here and complete the remaining steps, so please do tell me if you think the reasoning on the previous email does not hold up or is not worth the trouble. This diff was taken upon commit 018cffc9c9e5a5855733f5f45a1c4d396bb6a321. --DocE+STaALJfprDB Content-Type: text/plain; charset=us-ascii Content-Description: 018cffc9c9e5a5855733f5f45a1c4d396bb6a321.diff Content-Disposition: inline; filename="tor.diff" Content-Transfer-Encoding: quoted-printable --- a/gnu/packages/tor.scm 2020-05-31 00:45:08.246476629 -0300 +++ b/gnu/packages/tor.scm 2020-05-31 16:36:57.355970253 -0300 @@ -27,6 +27,7 @@ (define-module (gnu packages tor) #:use-module ((guix licenses) #:prefix license:) #:use-module (guix packages) + #:use-module (guix utils) #:use-module (guix download) #:use-module (guix git-download) #:use-module (guix build-system gnu) @@ -85,11 +86,36 @@ web browsers, instant messaging clients, remote login, and other applications based on the TCP protocol. =20 +This package is the full featured @code{tor} which is needed for running +relays, bridges or directory authorities. If you just want to access the T= or +Network or to setup an onion service you may install @code{tor-client} +instead.") + (license license:bsd-3))) + +(define-public tor-client + (package + (inherit tor) + (name "tor-client") + (arguments + (substitute-keyword-arguments (package-arguments tor) + ((#:configure-flags flags) + `(list ,@(cdr flags) + "--disable-module-relay")))) + (synopsis "Client to the anonymous Tor network") + (description + "Tor protects you by bouncing your communications around a distributed +network of relays run by volunteers all around the world: it prevents +somebody watching your Internet connection from learning what sites you +visit, and it prevents the sites you visit from learning your physical +location. Tor works with many of your existing applications, including +web browsers, instant messaging clients, remote login, and other +applications based on the TCP protocol. + To @code{torify} applications (to take measures to ensure that an applicat= ion, which has not been designed for use with Tor such as ssh, will use only To= r for internet connectivity, and also ensures that there are no leaks from DNS, = UDP or -the application layer) you need to install @code{torsocks}.") - (license license:bsd-3))) +the application layer) you need to install @code{torsocks}. This package = only +provides a client to the Tor Network."))) =20 (define-public torsocks (package --DocE+STaALJfprDB-- --5I6of5zJg18YgZEa Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQI5BAABCgAjFiEEIBdLYNLH+F+MBdSrYrJ+WmBEwoIFAl7UCCsFgwPCZwAACgkQ YrJ+WmBEwoJZ6A//a34yDfjsliVNtk29qahM9J/91rYC6ThjdmpSTeQrW26l1lqx 410cGHQ1SBtTFm0bPqDe1t7kraAkmx4QV1krh2SoO7Pf956isfJ3k2EqBZWiuvZ8 adxQNkQCJnn+xibaWlWfFbUWXjgq/1GIflYPfkQT3r8yt0YqpJeDJvR4ATzKpcgk bXw5no1QDjj5DW15dAozzP5O8hiVj3OEBgtZIG7zCelnJr060cqslmgtLZ49kIkY /YVlYbxeOoMWEcm1t8wZIhC/kl1upoleNuah6xzNPXtWjCxhPCMRDAE3gxIOxtEV liIF7nmtj/+/EN8rbWVmkXmXyhv8fc9Wqkdk78Bh2xLHXS9n9YgjYk4WtKdcPFe9 pz0uALdksgk8IqHi5TAVBE80XU+cAc7K0J6YYQcoD4sTVD22OOYjOX/rqdhIm8hx +mGsyKIwaEML7OhThs/k8jhpJPj77qH+IJ35whHQfnDsGEgkd6Psk2OH+yXGaElS jHFzSdz+2zkObzfJtf8KpcULqmrvSezwB5m/03awwkAdbLWgdj+KKp0lJUcZNNUS vkBd3ZHScPfAJFYjSPLRmFxGNYSxP1InGMfg9prn16B8xG9SGHO6f85d53M6d2MK zFSWEzE8Ily3Kp6MBNTGFcNrNk3IufVR84LHvjkIgjoMa2oAaTGII8D9v5Y= =YTHF -----END PGP SIGNATURE----- --5I6of5zJg18YgZEa--