Jami bug investigation #2

Jami bug investigation #2

[Jan]

Hello,

I'm still trying to fix the bug, Jami devs are still busy doing other
things, so I decided to do an experiment.
I discovered tarballs published at
https://dl.jami.net/release/tarballs/ often have some faults - one time
it didn't contain client-gnome and lrc folders, and the most recent one
doesn't contain daemon/contrib folder. My idea is the automatically
generated tarballs contain some undiscovered yet faults that make our
package behave differently.

To check if it's true, I decided not to use these tarballs and use
git-fetch instead - I did it with Jami daemon and daemon client lib,
but I can't apply patches for pjproject - the patch command tells me
files are read-only. This is really strange, because I make the files
writable using "make-file-writable", which works on the current
Jami package and works for ffmpeg-jami (even after modifying jami
daemon and the procedures applying patches).

Is it possible that there's something wrong with permissions in the
pjproject repository, which makes it impossible to apply the patches?
I'm using the exact same pjproject version as Jami developers, yet
patching fails.

Any ideas?


Jan Wielkiewicz

Re: Jami bug investigation #2

[Pierre Neidhardt]

[-- Attachment #1: Type: text/plain, Size: 220 bytes --]

When do you apply patches?
If in (source ...), those patches are possibly applied before you make
the repository writable.

Please share the recipe, this will help :)

-- 
Pierre Neidhardt
https://ambrevar.xyz/

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]

Re: Jami bug investigation #2

[Jan]

On Fri, 22 May 2020 11:07:34 +0200
Pierre Neidhardt <mail@ambrevar.xyz> wrote:

> When do you apply patches?
> If in (source ...), those patches are possibly applied before you make
> the repository writable.
The patches are applied by the jami-apply-dependency-patches procedure
which is used in the modify-phases field. I even make sure the phases
run in order by using "add-after 'unpack 'make-git-checkout-writable"
and then "add-after 'make-git-checkout-writable 'apply-patches".

> Please share the recipe, this will help :)
> 

I'll post the code in my repo later this day - the change allowing Jami
to be built from git is 5 fat commits already.



Jan Wielkiewicz

Re: Jami bug investigation #2

[Jan]

On Fri, 22 May 2020 11:07:34 +0200
Pierre Neidhardt <mail@ambrevar.xyz> wrote:

> Please share the recipe, this will help :)
> 

Okay, here it is
https://gitlab.com/kromka_chleba/jami-package-and-other-things-for-guix/-/commits/wip-jami-from-git/
or just clone it from
https://gitlab.com/kromka_chleba/jami-package-and-other-things-for-guix.git
and go to the "wip-jami-from-git" branch.

Thanks for checking it.


Jan Wielkiewicz

Re: Jami bug investigation #2

[Jan]

Okay, so I fixed the patching problem using "--ignore-whitespace".


Jan Wielkiewicz