From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id 8MqPGak9vV5/AQAA0tVLHw (envelope-from ) for ; Thu, 14 May 2020 12:46:33 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id MHfbE6k9vV4+bgAAB5/wlQ (envelope-from ) for ; Thu, 14 May 2020 12:46:33 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id A5036940463 for ; Thu, 14 May 2020 12:46:30 +0000 (UTC) Received: from localhost ([::1]:36358 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jZDFv-0008NQ-Q0 for larch@yhetil.org; Thu, 14 May 2020 08:46:31 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:54026) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jZDDX-0004WL-D6 for guix-patches@gnu.org; Thu, 14 May 2020 08:44:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:49044) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jZDDX-0007vy-3N for guix-patches@gnu.org; Thu, 14 May 2020 08:44:03 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jZDDX-0001sF-1L for guix-patches@gnu.org; Thu, 14 May 2020 08:44:03 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#40677] [PATCH v4] gnu: Add ffmpeg-jami. Resent-From: Jan Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 14 May 2020 12:44:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 40677 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: To: Mathieu Othacehe Cc: 40677@debbugs.gnu.org Received: via spool by 40677-submit@debbugs.gnu.org id=B40677.15894602287162 (code B ref 40677); Thu, 14 May 2020 12:44:02 +0000 Received: (at 40677) by debbugs.gnu.org; 14 May 2020 12:43:48 +0000 Received: from localhost ([127.0.0.1]:60588 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jZDDF-0001rN-8G for submit@debbugs.gnu.org; Thu, 14 May 2020 08:43:48 -0400 Received: from smtpo.poczta.interia.pl ([217.74.65.155]:50736) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jZDDD-0001r8-6k for 40677@debbugs.gnu.org; Thu, 14 May 2020 08:43:43 -0400 X-Interia-R: Interia X-Interia-R-IP: 89.64.42.134 X-Interia-R-Helo: Received: from kompiuter (89-64-42-134.dynamic.chello.pl [89.64.42.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by poczta.interia.pl (INTERIA.PL) with ESMTPSA; Thu, 14 May 2020 14:43:36 +0200 (CEST) Date: Thu, 14 May 2020 14:43:24 +0200 From: Jan Message-ID: <20200514144324.346f0bc5@kompiuter> In-Reply-To: <87zhab2e00.fsf@gnu.org> References: <20200417015857.0650ff6a@interia.pl> <20200513181234.27548-1-tona_kosmicznego_smiecia@interia.pl> <87zhab2e00.fsf@gnu.org> X-Mailer: Claws Mail 3.14.1 (GTK+ 2.24.31; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Interia-Antivirus: OK DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=interia.pl; s=biztos; t=1589460217; bh=vpQlCAJ2ExEmtaqSIKhUH/NVaFQV2db9xHCqQr4narg=; h=X-Interia-R:X-Interia-R-IP:X-Interia-R-Helo:Date:From:To:Cc: Subject:Message-ID:In-Reply-To:References:X-Mailer:MIME-Version: Content-Type:Content-Transfer-Encoding:X-Interia-Antivirus; b=BhP19b4BU2rWIjFpy71RnqASoSpgI5xOI00Vq7Mmm+LqYCdJ0HIUj790scuzoPJaw BMtsThsPMMFfi3qj0vzT6aHJO+2wTDShaE1L37q/2GDhf6AfNyS7AmjV92zhKG/I72 atMdyh9ZrDvESLgWtMhz/XuNR+7jhPio4hXokgJo= X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -1.7 (-) X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Scanner: scn0 X-Spam-Score: 1.99 Authentication-Results: aspmx1.migadu.com; dkim=fail (rsa verify failed) header.d=interia.pl header.s=biztos header.b=BhP19b4B; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Scan-Result: default: False [1.99 / 13.00]; RCVD_VIA_SMTP_AUTH(0.00)[]; GENERIC_REPUTATION(0.00)[-0.53869713707698]; MX_INVALID(1.00)[cached]; TO_DN_SOME(0.00)[]; R_SPF_ALLOW(-0.20)[+ip4:209.51.188.0/24:c]; FREEMAIL_FROM(0.00)[interia.pl]; DWL_DNSWL_FAIL(0.00)[209.51.188.17:server fail]; R_DKIM_REJECT(1.00)[interia.pl:s=biztos]; IP_REPUTATION_HAM(0.00)[asn: 22989(0.05), country: US(-0.00), ip: 209.51.188.17(-0.54)]; DKIM_TRACE(0.00)[interia.pl:-]; RCPT_COUNT_TWO(0.00)[2]; MAILLIST(-0.20)[mailman]; FORGED_RECIPIENTS_MAILLIST(0.00)[]; RECEIVED_SPAMHAUS_PBL(0.00)[89.64.42.134:received]; MIME_TRACE(0.00)[0:+]; RCVD_TLS_LAST(0.00)[]; ASN(0.00)[asn:22989, ipnet:209.51.188.0/24, country:US]; TAGGED_FROM(0.00)[larch=yhetil.org]; FROM_NEQ_ENVFROM(0.00)[tona_kosmicznego_smiecia@interia.pl,guix-patches-bounces@gnu.org]; ARC_NA(0.00)[]; URIBL_BLOCKED(0.00)[gnu.org:email]; FROM_HAS_DN(0.00)[]; MIME_GOOD(-0.10)[text/plain]; DMARC_NA(0.00)[interia.pl]; HAS_LIST_UNSUB(-0.01)[]; DNSWL_BLOCKED(0.00)[209.51.188.17:from]; MID_RHS_NOT_FQDN(0.50)[]; RCVD_COUNT_SEVEN(0.00)[8]; FORGED_SENDER_MAILLIST(0.00)[] X-TUID: mloF3TO7ErBW On Thu, 14 May 2020 09:05:03 +0200 Mathieu Othacehe wrote: > Hello Jan, > > > It's better to avoid using "set!". > What should I use instead? > > + (system=? (lambda (s) > > + (string-prefix? %current-system s)))) > > This should be (%current-system), plus I think arguments should be > transposed. Okay > > + (if (string-contains %current-system "linux") > > + (begin (append-flags %ffmpeg-linux-configure-flags) > > + (cond ((or (system=? "i686") > > + (system=? "x86_64")) > > + (append-flags > > %ffmpeg-linux-x86-configure-flags)) > > + ((system=? "x86_64") > > + (append-flags '("--arch=x86_64"))) > > If the first branch of the cond succeeds, we will never add this flag. That's what happens when you code late in night :) I should sit down with a cup of coffee and read Guile's manual seriously this time. Sorry for making your code review harder. > Plus, it seems than ffmpeg is able to detect the running system. So I > would suggest to do this: > > --8<---------------cut here---------------start------------->8--- > ;; This procedure composes the configure flags list for ffmpeg-jami. > (define (ffmpeg-compose-configure-flags) > (define (system=? s) > (string-prefix? s (%current-system))) > > `(,@%ffmpeg-default-configure-flags > ;; Add Linux specific flags. > ,@(if (string-contains %current-system "linux") > %ffmpeg-linux-configure-flags > '()) > ,@(if (or (system=? "i686") (system=? "x86_64")) > %ffmpeg-linux-x86-configure-flags > '()))) > --8<---------------cut here---------------end--------------->8--- > > What do you think? I think %ffmpeg-linux-x86-configure-flags should be added only if linux is present, not just when on i686 or x86_64. I called it "%ffmpeg-linux-x86...", because it was inside of the "ifdef HAVE_LINUX" condition. But there was also a comment saying "Desktop Linux", which as always means very little. I'm not sure if it really requires the Linux kernel there or what. What about the output of the procedure? Is it okay for the list to be not proper? It will look something like this: ((flag1 flag2 ... flagN) (flag1 flag2 ... flagN)) Is it okay because everything is treated as a pair in a recursive manner? Other than this, it will be good. > Thanks, > > Mathieu