all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: "Jakub Kądziołka" <kuba@kadziolka.net>
To: Christopher Howard <christopher@librehacker.com>
Cc: 41033@debbugs.gnu.org
Subject: [bug#41033] [PATCH] gnu: libusb-0.1: fix build failure on newer gcc
Date: Sun, 3 May 2020 12:58:46 +0200	[thread overview]
Message-ID: <20200503105846.fvouqze7r5qhb5nf@gravity> (raw)
In-Reply-To: <1a3c1bf5091742ae78a5946c92a622206dcdf596.camel@librehacker.com>

[-- Attachment #1: Type: text/plain, Size: 791 bytes --]

On Sat, May 02, 2020 at 02:47:56PM -0800, Christopher Howard wrote:
> I need libusb-0.1 to build some older software, but libusb-0.1 build
> fails due to a warning from the current GCC version. (Evidently libusb-
> 0.1 is set to die on any warning.) The attached patch silences the
> warning.

Thanks for your patch! I'm wondering though, whether it wouldn't be more
resilient to add a -Wno-error flag instead. After all, the compiler is
going to get upgraded sooner or later, which will introduce new
warnings, and libusb 0.1 isn't getting any upgrades...

A quick grep suggests that this wouldn't be the first package to disable
Werror. Makes sense, since this mode is mostly useful to developers, and
not packagers.

What do you think?

Kind regards,
Jakub Kądziołka

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

  reply	other threads:[~2020-05-03 10:59 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-02 22:47 [bug#41033] [PATCH] gnu: libusb-0.1: fix build failure on newer gcc Christopher Howard
2020-05-03 10:58 ` Jakub Kądziołka [this message]
2020-05-03 16:13   ` Christopher Howard
2020-05-03 20:56     ` bug#41033: " Jakub Kądziołka

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200503105846.fvouqze7r5qhb5nf@gravity \
    --to=kuba@kadziolka.net \
    --cc=41033@debbugs.gnu.org \
    --cc=christopher@librehacker.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.