From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([209.51.188.92]:49654) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jTXrf-0007l7-6o for guix-patches@gnu.org; Tue, 28 Apr 2020 17:34:03 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.90_1) (envelope-from ) id 1jTXre-0005Px-GJ for guix-patches@gnu.org; Tue, 28 Apr 2020 17:34:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:58475) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jTXre-0005Ps-2m for guix-patches@gnu.org; Tue, 28 Apr 2020 17:34:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jTXrd-0005Vi-Vq for guix-patches@gnu.org; Tue, 28 Apr 2020 17:34:01 -0400 Subject: [bug#40950] [PATCH] mcron, create /var/cron/tabs on activation Resent-Message-ID: Received: from eggs.gnu.org ([2001:470:142:3::10]:49002) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jTXqv-0007Nj-Mb for guix-patches@gnu.org; Tue, 28 Apr 2020 17:33:26 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.90_1) (envelope-from ) id 1jTXoq-0001ia-H9 for guix-patches@gnu.org; Tue, 28 Apr 2020 17:33:17 -0400 Received: from mail.freearts.agency ([51.68.137.137]:36300) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jTXop-0001cf-9A for guix-patches@gnu.org; Tue, 28 Apr 2020 17:31:08 -0400 From: Marcin Karpezo Date: Tue, 28 Apr 2020 23:28:53 +0200 Message-Id: <20200428212852.19552-1-sirmacik@wioo.waw.pl> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: 40950@debbugs.gnu.org Cc: Marcin Karpezo --- Hi! With big rekado help I'm sending you a patch with at least partially fixes the issue of crontab -e reporting missing /var/cron/tabs directory. gnu/services/mcron.scm | 12 +++++++++++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/gnu/services/mcron.scm b/gnu/services/mcron.scm index d9627c6bd0..ca9a54a041 100644 --- a/gnu/services/mcron.scm +++ b/gnu/services/mcron.scm @@ -1,5 +1,6 @@ ;;; GNU Guix --- Functional package management for GNU ;;; Copyright © 2016, 2017, 2018, 2019, 2020 Ludovic Courtès +;;; Copyright © 2020 Marcin Karpezo ;;; ;;; This file is part of GNU Guix. ;;; @@ -128,6 +129,12 @@ files." (actions (list (shepherd-schedule-action mcron files))))))))) +(define (mcron-service-activation config) + (with-imported-modules '((guix build utils)) + #~(begin + (use-modules (guix build utils)) + (mkdir-p "/var/cron/tabs")))) + (define mcron-service-type (service-type (name 'mcron) (description @@ -137,7 +144,10 @@ files." mcron-shepherd-services) (service-extension profile-service-type (compose list - mcron-configuration-mcron)))) + mcron-configuration-mcron)) + (service-extension activation-service-type + mcron-service-activation))) + (compose concatenate) (extend (lambda (config jobs) (mcron-configuration -- 2.26.2