From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:470:142:3::10]:44222)
 by lists.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1jTCfT-0004DH-IT
 for guix-patches@gnu.org; Mon, 27 Apr 2020 18:56:03 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.90_1)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1jTCfS-00041L-St
 for guix-patches@gnu.org; Mon, 27 Apr 2020 18:56:03 -0400
Received: from debbugs.gnu.org ([209.51.188.43]:55069)
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
 (Exim 4.90_1) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
 id 1jTCfS-0003zK-GE
 for guix-patches@gnu.org; Mon, 27 Apr 2020 18:56:02 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1jTCfS-0005cn-Fa
 for guix-patches@gnu.org; Mon, 27 Apr 2020 18:56:02 -0400
Subject: [bug#40677] [PATCH 04/18] gnu: Add libnatpmp.
Resent-Message-ID: <handler.40677.B40677.158802812121561@debbugs.gnu.org>
Date: Tue, 28 Apr 2020 00:55:00 +0200
From: Jan <tona_kosmicznego_smiecia@interia.pl>
Message-ID: <20200428005500.7114c2b1@kompiuter>
In-Reply-To: <87blnjq392.fsf@gmail.com>
References: <20200421161032.1847-1-tona_kosmicznego_smiecia@interia.pl>
 <20200421161032.1847-4-tona_kosmicznego_smiecia@interia.pl>
 <87blnjq392.fsf@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/guix-patches>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Mathieu Othacehe <m.othacehe@gmail.com>
Cc: 40677@debbugs.gnu.org

On Wed, 22 Apr 2020 11:27:37 +0200
Mathieu Othacehe <m.othacehe@gmail.com> wrote:

> > +         (delete 'configure)
> > +         (delete 'check))  
> 
> Please add a ;no tests comment.
Done.

> I guess we are dealing with a raw Makefile here. This is bad news
> because it means that cross-compilation is almost always broken.
> 
> You can run:
> 
> --8<---------------cut here---------------start------------->8---
> guix build --target=aarch64-linux-gnu libnatpmp
> --8<---------------cut here---------------end--------------->8---

It was built successfully, it works then I guess.


> to check it. Then, you probably need to do something similar as what
> is done in package "iw" (set CC variable at least).
Where can I read about this CC thing more? Is it needed when
cross-compilation works? 
> 
> > +       #:make-flags
> > +       (list (string-append "PREFIX=" (assoc-ref %outputs
> > "out")))))
> > +    (home-page "http://miniupnp.free.fr/libnatpmp.html")
> > +    (synopsis "C library implementing NAT-PMP")
> > +    (description
> > +     "libnatpmp is a portable and asynchronous implementaiton of  
>            ^
>        @code{libnatpmp}                                    ^
>                                                           typo
Fixed.

> Thanks,
> 
> Mathieu


Jan Wielkiewicz