From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:470:142:3::10]:34678)
 by lists.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1jTBen-0007nT-Iw
 for guix-patches@gnu.org; Mon, 27 Apr 2020 17:51:18 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.90_1)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1jTBeY-000098-9d
 for guix-patches@gnu.org; Mon, 27 Apr 2020 17:51:17 -0400
Received: from debbugs.gnu.org ([209.51.188.43]:55002)
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
 (Exim 4.90_1) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
 id 1jTBeX-000092-Tz
 for guix-patches@gnu.org; Mon, 27 Apr 2020 17:51:01 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1jTBeX-0003rJ-RK
 for guix-patches@gnu.org; Mon, 27 Apr 2020 17:51:01 -0400
Subject: [bug#40810] [PATCH] gnu: Add kbdd.
Resent-Message-ID: <handler.40810.B.158802423314785@debbugs.gnu.org>
Received: from eggs.gnu.org ([2001:470:142:3::10]:34566)
 by lists.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <kuba@kadziolka.net>) id 1jTBe2-0007Oz-Fy
 for guix-patches@gnu.org; Mon, 27 Apr 2020 17:50:30 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.90_1)
 (envelope-from <kuba@kadziolka.net>) id 1jTBe1-00086l-5K
 for guix-patches@gnu.org; Mon, 27 Apr 2020 17:50:30 -0400
Received: from pat.zlotemysli.pl ([37.59.186.212]:50790)
 by eggs.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <kuba@kadziolka.net>) id 1jTBe0-00084h-GI
 for guix-patches@gnu.org; Mon, 27 Apr 2020 17:50:28 -0400
Date: Mon, 27 Apr 2020 23:50:17 +0200
From: Jakub =?UTF-8?Q?K=C4=85dzio=C5=82ka?= <kuba@kadziolka.net>
Message-ID: <20200427215017.qlrz5yi77cgsn26n@gravity>
References: <20200424072023.32416-1-boris.dekshteyn@google.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature"; boundary="pqwhhe7322hjgcvo"
Content-Disposition: inline
In-Reply-To: <20200424072023.32416-1-boris.dekshteyn@google.com>
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/guix-patches>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: "Boris A. Dekshteyn" <harlequin78@gmail.com>
Cc: boris.dekshteyn@google.com, 40810@debbugs.gnu.org


--pqwhhe7322hjgcvo
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Fri, Apr 24, 2020 at 07:20:23PM +1200, Boris A. Dekshteyn wrote:
> ---
>  gnu/packages/xdisorg.scm | 38 ++++++++++++++++++++++++++++++++++++++
>  1 file changed, 38 insertions(+)

In your future patches, please include a ChangeLog-style line in the
body of the commit message. You can look at the commit history for some
examples. In the case of new packages, it's customary to write

* gnu/packages/xdisorg.scm (kbdd): New variable.

> +(define-public kbdd
> +  (package
> +    (name "kbdd")
> +    (version "0.7.1")
> +    (source
> +     (origin
> +       (method url-fetch)
> +       (uri (string-append
> +             "https://github.com/qnikst/kbdd/archive/v"
> +             version ".tar.gz"))
> +       (sha256
> +        (base32 "0nhn7cx1z4k1kfll325xjr5a31zjc4h5h8q0wxa9svz8aihfxcqp"))
> +       (file-name (string-append "kbdd" version))))

It's generally a bad idea to use GitHub's autogenerated tarball, since
it is occasionally regenerated, which changes the hash. See point 13 of
"(guix)Submitting Patches". This is also pointed out by `guix lint`,
please make sure to run it on your packages.

> +    (build-system gnu-build-system)
> +    (arguments
> +     '(#:phases
> +       (modify-phases %standard-phases
> +         (add-before 'configure 'configure-fix
> +           (lambda* _
> +             (invoke "aclocal")
> +             (invoke "automake" "--add-missing")
> +             (invoke "autoreconf"))))))

I got surprised that this phase is necessary, as gnu-build-system
already includes the 'bootstrap phase. I tried removing it and the
package still builds. Was that not the case for you?

> +    (native-inputs
> +     `(("pkg-config" ,pkg-config)
> +       ("autoconf" ,autoconf)
> +       ("automake" ,automake)
> +       ("glib" ,glib "bin")))
> +    (inputs
> +     `(("glib" ,glib)
> +       ("dbus-glib", dbus-glib)
> +       ("libx11" ,libx11)))

Usually, alphabetical order is preferred unless there's a reason to
deviate.

> +    (description "Kbdd is a simple keyboard layout manager.
> ++ Features: WM / DE independant,  Written in plain C (only glib dependan=
t),=20
> ++ has optional dbus interface")

The leading pluses almost certainly shouldn't be there. The description
is written somewhat oddly. When you're out of inspiration for a
description, you can adapt Debian's. In fact, the description used by
Debian made it much more clear to me why I'd want to use the package:

    (synopsis "Per-window keyboard layout switching daemon for X")
    (description "@command{kbdd} is a simple keyboard layout switching
program, which is designed to run in an X11 session and remember
keyboard layouts on a per-window basis. That can be very handy for a
user of a non-US keyboard who does not want to jump through layouts back
and forth while typing in terminals (mostly in a latin alphabet) and
some kind of chat (in native language).

@command{kbdd} also supports D-Bus signals, which makes it possible to
create layout indicator widgets.")

Thanks for your contributions! Would you mind sending an updated patch?
(To the same bug number, 40810@debbugs.gnu.org. Also, please CC me, as I
don't subscribe to the guix-patches mailing list.)

Regards,
Jakub K=C4=85dzio=C5=82ka

--pqwhhe7322hjgcvo
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCAAdFiEE5Xa/ss9usT31cTO54xWnWEYTFWQFAl6nU5QACgkQ4xWnWEYT
FWTTNBAAmA58ejJuIZtjdhDsDGDtcCzrpaH3VHDaU4ea/E7KXM67iMW+Hj6UQ6fD
NNGpzAfobUvF+iUlcU81xkT2s9Zd7RUSXu6zn6+oiZkaLDTi96iF/FL1C9VuSsCc
k/9tiCVFXfTNHL5edTXFlXP2YqyTCb5Fn3bKR8oD2ly+qGcALOEcq5wrUrmV8zv6
AhdvLBHCLVynEWFp90zIbjRE3BdGtwgQvtTVPx2elDwS9h0LsH+R72l1Pb/p0bf+
lmq0LBYpEefuW9jdHvlXMiAScMHj6yPEu+z100sn6f88rWVU7+KjIk0YtsaNSPcZ
mllLLZqNwWDFNpWSk6YT+9e0CK4lL6xpX3EBMY9VZ2mM34hWeZ1muxCUTUuYmBX0
W7QGwNKIVcOlgMhlYLFl2PrFZvoMv72mSDSYS7+TsyaGI47P/CPGXo42lQEiztdw
1RMlMyz3iAbrMHn5LimjbhEYPJeDm+GtMHipXWisSFGk9bPpPnCu1VtdLpagAiCm
NO+vSxcCBmF064pSo1I6NxWTkEoJ+NNEFR0U0Rg1UsWrASAJHMW2BEb7eJk+WcPT
HiZ2A7OOwpIzJqTvCrkwjZwqcrPdQQA4RD5kAIF86ftIRg2UA35y8Cm0eFXIBAkJ
JNT/wT+dyE2irXSehEGsT9Ij7qc/+qehqrKtcov38SUYNJzj9kA=
=FjU/
-----END PGP SIGNATURE-----

--pqwhhe7322hjgcvo--