bug#40829: [core-updates] pdfpc-4.3.4 fails to build

bug#40829: [core-updates] pdfpc-4.3.4 fails to build

[Jack Hill]

Hi Guix,

Currently, pdfpc on core-updates fails to build with:

/tmp/guix-build-pdfpc-4.3.4.drv-0/source/src/classes/action/action_mapping.vala:51.9-51.28: error: Creation method of abstract class cannot be public.
         public ActionMapping() {
         ^^^^^^^^^^^^^^^^^^^^
/tmp/guix-build-pdfpc-4.3.4.drv-0/source/src/classes/drawings/storage.vala:38.9-38.19: error: Creation method of abstract class cannot be public.
         public Base(Metadata.Pdf metadata) {
         ^^^^^^^^^^^
/tmp/guix-build-pdfpc-4.3.4.drv-0/source/src/classes/renderer/cache/base.vala:40.9-40.19: error: Creation method of abstract class cannot be public.
         public Base(Metadata.Pdf metadata) {
         ^^^^^^^^^^^
/tmp/guix-build-pdfpc-4.3.4.drv-0/source/src/classes/timer_label.vala:98.9-98.25: error: Creation method of abstract class cannot be public.
         public TimerLabel(PresentationController controller, time_t start_time = 0) {
         ^^^^^^^^^^^^^^^^^
/tmp/guix-build-pdfpc-4.3.4.drv-0/source/src/classes/view/behaviour/base.vala:44.9-44.19: error: Creation method of abstract class cannot be public.
         public Base() {
         ^^^^^^^^^^^

Upgrading to the latest release, 4.4.0, solves the problem. I have 
prepared the following patch against core-updates that does that.

Best,
Jack

bug#40829: [PATCH core-updates] gnu: pdfpc: Upgrade to 4.4.0

[Jack Hill]

* gnu/packages/pdf.scm (pdfpc): Upgrade to 4.4.0.
---
 gnu/packages/pdf.scm | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/gnu/packages/pdf.scm b/gnu/packages/pdf.scm
index 8ccb133e1f..f4ffda7462 100644
--- a/gnu/packages/pdf.scm
+++ b/gnu/packages/pdf.scm
@@ -1232,7 +1232,7 @@ multiple files.")
 (define-public pdfpc
   (package
     (name "pdfpc")
-    (version "4.3.4")
+    (version "4.4.0")
     (source
      (origin
        (method git-fetch)
@@ -1241,7 +1241,7 @@ multiple files.")
              (commit (string-append "v" version))))
        (file-name (git-file-name name version))
        (sha256
-        (base32 "07aafsm4jzdgpahz83p0ajv40hry7gviyadqi13ahr8xdhhwy2sd"))))
+        (base32 "0vh2r32akvasdrghkaq7ard24r2qncp34jfiyshi3zxabm9bhfaa"))))
     (build-system cmake-build-system)
     (arguments '(#:tests? #f))          ; no test target
     (inputs
-- 
2.26.2

bug#40829: [core-updates] pdfpc-4.3.4 fails to build

[Marius Bakke]

[-- Attachment #1: Type: text/plain, Size: 1499 bytes --]

Jack Hill <jackhill@jackhill.us> writes:

> Hi Guix,
>
> Currently, pdfpc on core-updates fails to build with:
>
> /tmp/guix-build-pdfpc-4.3.4.drv-0/source/src/classes/action/action_mapping.vala:51.9-51.28: error: Creation method of abstract class cannot be public.
>          public ActionMapping() {
>          ^^^^^^^^^^^^^^^^^^^^
> /tmp/guix-build-pdfpc-4.3.4.drv-0/source/src/classes/drawings/storage.vala:38.9-38.19: error: Creation method of abstract class cannot be public.
>          public Base(Metadata.Pdf metadata) {
>          ^^^^^^^^^^^
> /tmp/guix-build-pdfpc-4.3.4.drv-0/source/src/classes/renderer/cache/base.vala:40.9-40.19: error: Creation method of abstract class cannot be public.
>          public Base(Metadata.Pdf metadata) {
>          ^^^^^^^^^^^
> /tmp/guix-build-pdfpc-4.3.4.drv-0/source/src/classes/timer_label.vala:98.9-98.25: error: Creation method of abstract class cannot be public.
>          public TimerLabel(PresentationController controller, time_t start_time = 0) {
>          ^^^^^^^^^^^^^^^^^
> /tmp/guix-build-pdfpc-4.3.4.drv-0/source/src/classes/view/behaviour/base.vala:44.9-44.19: error: Creation method of abstract class cannot be public.
>          public Base() {
>          ^^^^^^^^^^^
>
> Upgrading to the latest release, 4.4.0, solves the problem. I have 
> prepared the following patch against core-updates that does that.

Thanks!  I pushed the patch to the "master" branch: it will land on
"core-updates" shortly.


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]