From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:470:142:3::10]:35476)
 by lists.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1jRCrK-0007gF-PD
 for guix-patches@gnu.org; Wed, 22 Apr 2020 06:44:03 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.90_1)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1jRCrK-0002Ds-1l
 for guix-patches@gnu.org; Wed, 22 Apr 2020 06:44:02 -0400
Received: from debbugs.gnu.org ([209.51.188.43]:39832)
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
 (Exim 4.90_1) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
 id 1jRCrJ-0002DK-MA
 for guix-patches@gnu.org; Wed, 22 Apr 2020 06:44:01 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1jRCrJ-0000Kz-Ja
 for guix-patches@gnu.org; Wed, 22 Apr 2020 06:44:01 -0400
Subject: [bug#40677] [PATCH 01/18] gnu: jami: Move Jami and its dependencies
 to jami.scm.
Resent-Message-ID: <handler.40677.B40677.15875521961230@debbugs.gnu.org>
Date: Wed, 22 Apr 2020 12:42:53 +0200
From: Jan <tona_kosmicznego_smiecia@interia.pl>
Message-ID: <20200422124253.18543e01@kompiuter>
In-Reply-To: <87k127q4jo.fsf@gmail.com>
References: <20200417015857.0650ff6a@interia.pl>
 <20200421161032.1847-1-tona_kosmicznego_smiecia@interia.pl>
 <87k127q4jo.fsf@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/guix-patches>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Mathieu Othacehe <m.othacehe@gmail.com>
Cc: 40677@debbugs.gnu.org

On Wed, 22 Apr 2020 10:59:39 +0200
Mathieu Othacehe <m.othacehe@gmail.com> wrote:

> Hello Jan,
>=20
> Thanks for the updated serie. I see it has shrunk a bit, which is
> good! First two general remarks. As explained by Christopher, you
> need to make sure that you pass the version of the patchset to git.
I passed the "-v2", didn't it wrok?

> You also need to write commit messages respecting this
> https://www.gnu.org/prep/standards/html_node/Change-Logs.html#Change-Logs
> as I already told you.
I have to read it one more time then, it's a bit unintuitive and
complicated.

> > +;;; GNU Guix --- Functional package management for GNU
> > +;;; Copyright =C2=A9 2019 Pierre Neidhardt <mail@ambrevar.xyz> =20
>=20
> Why is Pierre copyright here?
As far as I know he was an original author or maintainer of the
packages.
Isn't it required when copying a copyrighted work?

> > +;;; Copyright =C2=A9 2019, 2020 Jan Wielkiewicz
> > <tona_kosmicznego_smiecia@interia.pl> =20
>=20
> I'm not sure what's the copyright policy when moving stuff to new
> files. Someone?
>=20
> Thanks,
>=20
> Mathieu


Jan Wielkiewicz