From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:470:142:3::10]:37023)
 by lists.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1jO6ER-0003P8-Dm
 for guix-patches@gnu.org; Mon, 13 Apr 2020 17:03:04 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1jO6EQ-0005lg-DF
 for guix-patches@gnu.org; Mon, 13 Apr 2020 17:03:03 -0400
Received: from debbugs.gnu.org ([209.51.188.43]:49375)
 by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
 (Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
 id 1jO6EQ-0005lY-85
 for guix-patches@gnu.org; Mon, 13 Apr 2020 17:03:02 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1jO6EQ-0003Sb-5X
 for guix-patches@gnu.org; Mon, 13 Apr 2020 17:03:02 -0400
Subject: [bug#40575] [PATCH] gnu: Add python-diceware.
Resent-Message-ID: <handler.40575.B40575.158681174013231@debbugs.gnu.org>
Date: Mon, 13 Apr 2020 17:02:09 -0400
From: Leo Famulari <leo@famulari.name>
Message-ID: <20200413210209.GA31853@jasmine.lan>
References: <20200412150036.6508-1-kraai@ftbfs.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20200412150036.6508-1-kraai@ftbfs.org>
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/guix-patches>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Matthew Kraai <kraai@ftbfs.org>
Cc: 40575@debbugs.gnu.org

On Sun, Apr 12, 2020 at 08:00:36AM -0700, Matthew Kraai wrote:
> * gnu/packages/python-xyz.scm (python-diceware, python2-diceware): New public
> variables.

Thanks! Overall LGTM...

> +(define-public python2-diceware
> +  (package-with-python2 python-diceware))

Do you have a use case for the Python 2 variant? We recently updated our
Python packaging standards to not add these variants unless we need
them:

https://git.savannah.gnu.org/cgit/guix.git/commit/?id=39356057bce20f74120b6d227567a943556717cc