From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:470:142:3::10]:34494) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jNiZL-0000I5-FW for guix-patches@gnu.org; Sun, 12 Apr 2020 15:47:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jNiZK-0007hC-EB for guix-patches@gnu.org; Sun, 12 Apr 2020 15:47:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:47383) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1jNiZK-0007h6-AG for guix-patches@gnu.org; Sun, 12 Apr 2020 15:47:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jNiZK-0001Kw-9E for guix-patches@gnu.org; Sun, 12 Apr 2020 15:47:02 -0400 Subject: [bug#40579] [RFC PATCH] add iPXE. Resent-Message-ID: Date: Sun, 12 Apr 2020 21:46:09 +0200 From: Danny Milosavljevic Message-ID: <20200412214609.57f92dcc@scratchpost.org> In-Reply-To: <87y2r0mthg.fsf@nckx> References: <87y2r0mthg.fsf@nckx> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="Sig_/h_3FvR.M_PewbezwDo6i4F="; protocol="application/pgp-signature"; micalg=pgp-sha256 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" Cc: 40579@debbugs.gnu.org, Tobias Geerinckx-Rice --Sig_/h_3FvR.M_PewbezwDo6i4F= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Hi, On Sun, 12 Apr 2020 20:47:23 +0200 Tobias Geerinckx-Rice via Guix-patches via wrote: > Could you elaborate? What's "interesting" about it? That all=20 > looks very boring and straightforward to me (which is good! :-) =E2=80=94= =20 > the result is GPL2-only, no? No, there are different makefile targets (rom output filenames) which will result in different parts of ipxe to be built and included in the output. There's special makefile targets for each of these targets to determine the license that applies to each of the latter targets, respectively. Unfortunately, there's no "all.license" target. > /bin is not the right place for these files. /lib/ipxe looks to=20 > be the standard; let's use that. I agree. > Let's, instead: >=20 > (add-after 'unpack 'enter-source-directory > (lambda _ (chdir "src") #t)) > > Don't worry, the state can't hurt you now. Now we can keep the=20 > standard build & install phases. I agree. > If you feel like it (there aren't that many files) you could list=20 > the licences for each output binary, but that's optional. The=20 > combined work appears to be GPL2. Does it? Did you try to make all of the targets' license targets? P.S. The following ROMs are not reproducible: 10222000.rom GPL2 10500940.rom GPL2=20 10ec8139.rom GPL2 15ad07b0.rom GPL2+ 1af41000.rom GPL2+ 8086100e.mrom GPL2+ 8086100f.mrom GPL2+ 808610d3.mrom GPL2+ 80861209.rom GPL2+ ipxe.iso license checker doesn't work rtl8139.rom GPL2 which are ALL of them except blib.a, ipxe.dsk, ipxe.lkrn, ipxe.pxe, ipxe.usb and undionly.kpxe (this one has GPL2+) (which are not roms). Note: Maybe also pass make-flags to overwrite those: ./Makefile.housekeeping:ECHO_E_BIN_ECHO :=3D /bin/echo ./Makefile.housekeeping:ECHO_E_BIN_ECHO_E :=3D /bin/echo -e --Sig_/h_3FvR.M_PewbezwDo6i4F= Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEds7GsXJ0tGXALbPZ5xo1VCwwuqUFAl6TcAEACgkQ5xo1VCww uqXvrgf/R/mL/THaLlYllEnmESXUoFroQSbaZqc+5/aLFYHUW9lVCfSmADrwiAyU AL5ETyRkmxfCQkQi1wyLLyNUFn/SCTptFR7BM8kddktlrpjwRIkb3uI6BkqPDTy6 S1Lx3eMmUNlhO6u/WvaV/iM/gKtPdkuo1dR1HjcyHOT79R9IVlMxYRQ6fIKbUv5m LPykekjlne4v95MgZDsQCB3F8ATf+kpvCJOYknKht+QnWRLUc+j+utmInTTp29rP /aLmIkJC93Fpv7I4FdtbzhFoT+n2x7vjsY1QVu/o1nugfqW+HkDycpA7oIE5N12W GWRquDfcXEearUg4icNryN+1MQ5rbQ== =nJd3 -----END PGP SIGNATURE----- --Sig_/h_3FvR.M_PewbezwDo6i4F=--