From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:470:142:3::10]:44529) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jMepE-0000Ij-NC for guix-patches@gnu.org; Thu, 09 Apr 2020 17:35:05 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jMepD-0007xg-N3 for guix-patches@gnu.org; Thu, 09 Apr 2020 17:35:04 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:43024) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1jMepC-0007xH-J4 for guix-patches@gnu.org; Thu, 09 Apr 2020 17:35:03 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jMepC-0004d3-HT for guix-patches@gnu.org; Thu, 09 Apr 2020 17:35:02 -0400 Subject: [bug#40514] [PATCH] vm: Transparently compress iso9660 images. Resent-Message-ID: Received: from eggs.gnu.org ([2001:470:142:3::10]:44484) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jMeos-00009D-OL for guix-patches@gnu.org; Thu, 09 Apr 2020 17:34:43 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jMeor-0007q8-Q6 for guix-patches@gnu.org; Thu, 09 Apr 2020 17:34:42 -0400 Received: from dd26836.kasserver.com ([85.13.145.193]:60764) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1jMeor-0007pu-Jg for guix-patches@gnu.org; Thu, 09 Apr 2020 17:34:41 -0400 Date: Thu, 9 Apr 2020 23:34:39 +0200 From: Danny Milosavljevic Message-ID: <20200409233439.69bf8943@scratchpost.org> In-Reply-To: <20200408210132.23612-1-me@tobias.gr> References: <87zhblofwk.fsf@nckx> <20200408210132.23612-1-me@tobias.gr> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="Sig_/o.l=6re66qZbv4Vw2Pirec8"; protocol="application/pgp-signature"; micalg=pgp-sha256 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: 40514@debbugs.gnu.org Cc: me@tobias.gr --Sig_/o.l=6re66qZbv4Vw2Pirec8 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Hi T G-R, On Wed, 8 Apr 2020 23:01:32 +0200 Tobias Geerinckx-Rice via Guix-patches via wrote: > * gnu/build/vm.scm (make-iso9660-image): Use the =E2=80=98--zisofs=E2=80= =99 xorriso > filter at the highest compression settings for supported directories. > --- > gnu/build/vm.scm | 18 ++++++++++++++++++ > 1 file changed, 18 insertions(+) >=20 > diff --git a/gnu/build/vm.scm b/gnu/build/vm.scm > index 79eed48c1f..972eb4bdf9 100644 > --- a/gnu/build/vm.scm > +++ b/gnu/build/vm.scm > @@ -533,6 +533,24 @@ GRUB configuration and OS-DRV as the stuff in it." > ;; Set all timestamps to 1. > "-volume_date" "all_file_dates" "=3D1" > =20 > + ;; =E2=80=98zisofs=E2=80=99 compression reduces the tota= l image size by ~60%. > + "-zisofs" "level=3D9:block_size=3D128k" ; highest compre= ssion > + ;; It's transparent to our Linux-Libre kernel but not to= GRUB. > + ;; Don't compress the kernel, initrd, and other files re= ad by > + ;; grub.cfg, as well as common already-compressed file n= ames. > + "-find" "/" "-type" "f" > + ;; XXX Even after "--" above, and despite documentation = claiming > + ;; otherwise, "-or" is stolen by grub-mkrescue which the= n chokes > + ;; on it (as =E2=80=98-o =E2=80=A6=E2=80=99) and dies. = Don't use "-or". > + "-not" "-wholename" "/boot/*" > + "-not" "-wholename" "/System/*" > + "-not" "-name" "unicode.pf2" > + "-not" "-name" "bzImage" > + "-not" "-name" "*.gz" ; initrd & all man pages > + "-not" "-name" "*.png" ; includes grub-image.png > + "-exec" "set_filter" "--zisofs" > + "--" > + > "-volid" (string-upcase volume-id) > (if volume-uuid > `("-volume_date" "uuid" LGTM! Tested it and it works, and I see no downside either. --Sig_/o.l=6re66qZbv4Vw2Pirec8 Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEds7GsXJ0tGXALbPZ5xo1VCwwuqUFAl6PlO8ACgkQ5xo1VCww uqVj+wgAkFhAurat+w5Q5wXLYbMiuAPHIKrYmcnztPYOogds4gA+8eEYxMCpQRI7 NQDDAYDsMSWof8hujpdUpGheinIsKwaWHkbBeJvL5J4lkdVoDX2+KWaWRH3q+2dw R1N0ch7MG9hiNS3eVeqLPaK1f93SkH1E+9Cd749v0OoKJwsjdyiWfjh9JHa2Np6W 80H6qfLlC2pEyBctq13fA1BDMtnrDvF0Wd9BqbE0f0z6t5b+EDWHOAyfMDHcr1SC JFc2eo922KMTD+RLie4uPsPADe9iKoSmOnu2Y7oi36ljFnC7maMVBJs0SQKQgE/h IwPUZ+SQzar5SXDThq6ShAyhcYJy9w== =pAhm -----END PGP SIGNATURE----- --Sig_/o.l=6re66qZbv4Vw2Pirec8--