From mboxrd@z Thu Jan 1 00:00:00 1970 From: Efraim Flashner Subject: bug#40528: 'guix lint' does not check whether propagated-inputs should be native Date: Fri, 10 Apr 2020 00:31:31 +0300 Message-ID: <20200409213131.GX1518@E5400> References: <87h7xsjqt2.fsf@devup.no> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="QxSStYAgvEtE+iQJ" Return-path: Received: from eggs.gnu.org ([2001:470:142:3::10]:44275) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jMenH-0008C4-66 for bug-guix@gnu.org; Thu, 09 Apr 2020 17:33:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jMenG-00078y-4P for bug-guix@gnu.org; Thu, 09 Apr 2020 17:33:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:43017) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1jMenG-00078r-0Y for bug-guix@gnu.org; Thu, 09 Apr 2020 17:33:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jMenF-0004Zn-UH for bug-guix@gnu.org; Thu, 09 Apr 2020 17:33:01 -0400 Sender: "Debbugs-submit" Resent-Message-ID: Content-Disposition: inline In-Reply-To: <87h7xsjqt2.fsf@devup.no> List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guix-bounces+gcggb-bug-guix=m.gmane-mx.org@gnu.org Sender: "bug-Guix" To: Marius Bakke Cc: 40528@debbugs.gnu.org --QxSStYAgvEtE+iQJ Content-Type: multipart/mixed; boundary="vDpQvD79HZx/5O2q" Content-Disposition: inline --vDpQvD79HZx/5O2q Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Apr 09, 2020 at 11:24:25PM +0200, Marius Bakke wrote: > 'guix lint -c inputs-should-be-native' only checks the 'inputs' field of > a package, not propagated-inputs. The attached patch should add the propagated inputs to the list of inputs to check. Do we want to start telling it to ignore some of them? gnu/packages/check.scm:2200:2: python-nose-timer@0.7.5: 'python-nose' shoul= d probably be a native input --=20 Efraim Flashner =D7=90=D7=A4=D7=A8=D7=99=D7=9D = =D7=A4=D7=9C=D7=A9=D7=A0=D7=A8 GPG key =3D A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351 Confidentiality cannot be guaranteed on emails sent or received unencrypted --vDpQvD79HZx/5O2q Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0001-lint-Check-for-inappropriate-inputs-in-propagated-in.patch" Content-Transfer-Encoding: quoted-printable =46rom 2ca0a385847c8dfcaffe4f32c5dbce7297086859 Mon Sep 17 00:00:00 2001 =46rom: Efraim Flashner Date: Fri, 10 Apr 2020 00:29:56 +0300 Subject: [PATCH] lint: Check for inappropriate inputs in propagated-inputs too. * guix/lint.scm (check-inputs-should-be-native): Also check the propagated inputs of the package. --- guix/lint.scm | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/guix/lint.scm b/guix/lint.scm index 72582cfffb..bda5c0cd77 100644 --- a/guix/lint.scm +++ b/guix/lint.scm @@ -7,7 +7,7 @@ ;;; Copyright =C2=A9 2016 Hartmut Goebel ;;; Copyright =C2=A9 2017 Alex Kost ;;; Copyright =C2=A9 2017 Tobias Geerinckx-Rice -;;; Copyright =C2=A9 2017, 2018 Efraim Flashner +;;; Copyright =C2=A9 2017, 2018, 2020 Efraim Flashner ;;; Copyright =C2=A9 2018, 2019 Arun Isaac ;;; ;;; This file is part of GNU Guix. @@ -286,7 +286,8 @@ of a package, and INPUT-NAMES, a list of package specif= ications such as (define (check-inputs-should-be-native package) ;; Emit a warning if some inputs of PACKAGE are likely to belong to its ;; native inputs. - (let ((inputs (package-inputs package)) + (let ((inputs (append (package-inputs package) + (package-propagated-inputs package))) (input-names '("pkg-config" "autoconf" --=20 2.26.0 --vDpQvD79HZx/5O2q-- --QxSStYAgvEtE+iQJ Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEoov0DD5VE3JmLRT3Qarn3Mo9g1EFAl6PlDIACgkQQarn3Mo9 g1Hagw//TxPUWE7nwX7YToJNseWcuHxs3ozRqIS53isJ7aXIulxjWooCCWHEXsUV mpQ210tINTr07nYu3c8NRAB6fhtEUscTNJ7UfcfjHqZh8A57FuZz4RRHgngLwXie D4t2veFHjTrCKC8VOdS0HzCd/R45WNTqfXaLRPBtyWkUSxCLVFiPEekg62Fgjukx 8UycNoS3nW8jBUNUNvHBmT1Gs4jO/Xm/6DtYFQMKe0u6s3tmXtWuDijLobi007el kq8EA+3YxpM0jsCgnkHwSwlxHD8if6lIbLo+44+rbWvsN5caGeLbl5gvnBPOnEUC F+LhMHKBnNl18y6A9E2H3PLIHZ1lXbWVddOpdz0Bj77Xc/HV/bkw94T6y+NGUkko jadv7PmJBwewh2sUz8mldGcDNXODiu7E4xOeq4wUPB2e8Q5AT/xBH48OIKLgIbMC LFUU4wZXk7+Ki0WHJXXFHljPxtjBKlzoGdVM/B/bnRsvIbeGYjrrSiCCLzF2BcBh AXiAYKAXOiW2NcJBg3G6hRzGP57QVKAdDIpFriajwN1SHhlU3on3/JJPEb3gZObB XNzgsuOXNKuKy7VML3BN2qZyV5UW9I9XWRlgieWr2BfvZ7ndzNfqjlItfbNbolsz y43XZytMbbtNBpcY+olvPgxvH2yedGGuwmm6HRiNf36k7PYYNYI= =HVk4 -----END PGP SIGNATURE----- --QxSStYAgvEtE+iQJ--