From: Leo Famulari <leo@famulari.name>
To: Alexandros Theodotou <alex@zrythm.org>
Cc: 40468@debbugs.gnu.org
Subject: [bug#40468] [PATCH 3/3] gnu: Add shiru-lv2.
Date: Wed, 8 Apr 2020 11:41:55 -0400 [thread overview]
Message-ID: <20200408154155.GA26684@jasmine.lan> (raw)
In-Reply-To: <1fe07e3677e852cd9d502b68e4659879fc21e6b0.camel@zrythm.org>
On Tue, Apr 07, 2020 at 09:04:40PM +0100, Alexandros Theodotou wrote:
> This is supposed to be merged after those changes. The first patch
> (40466) changes the install procedure in dragonfly-reverb, which is
> inherited here.
In general, I think that using syntactic inheritance to factorize build
phases is not the right way to go here. It can cause a big headache
later when the time comes to adjust things, and it removes the
advantages of Guix tools such as `guix graph` and `guix refresh`.
I think the better options are to create a new lv2-build-system that
inherits from gnu-build-system and replaces the install phase, or to
just copy and paste the code around. It depends on how many of these
packages we plan to add.
Let me know if you need help with any of that! The font-build-system is
a concise example of making a new build system based on the
gnu-build-system.
next prev parent reply other threads:[~2020-04-08 15:43 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-06 14:16 [bug#40468] [PATCH 3/3] gnu: Add shiru-lv2 Alexandros Theodotou
2020-04-06 21:28 ` Alexandros Theodotou
2020-04-07 18:25 ` Leo Famulari
2020-04-07 19:09 ` Alexandros Theodotou
2020-04-07 19:41 ` Leo Famulari
2020-04-07 20:04 ` Alexandros Theodotou
2020-04-07 20:08 ` Leo Famulari
2020-04-07 20:14 ` Alexandros Theodotou
2020-04-08 15:41 ` Leo Famulari [this message]
2020-04-08 15:58 ` Alexandros Theodotou
2020-04-08 16:34 ` Alexandros Theodotou
2020-05-29 1:41 ` bug#40468: " Leo Famulari
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200408154155.GA26684@jasmine.lan \
--to=leo@famulari.name \
--cc=40468@debbugs.gnu.org \
--cc=alex@zrythm.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.