From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:470:142:3::10]:39668)
 by lists.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1jLsvD-0001ok-2p
 for guix-patches@gnu.org; Tue, 07 Apr 2020 14:26:04 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1jLsvC-00011g-2l
 for guix-patches@gnu.org; Tue, 07 Apr 2020 14:26:03 -0400
Received: from debbugs.gnu.org ([209.51.188.43]:39316)
 by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
 (Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
 id 1jLsvB-00011I-VM
 for guix-patches@gnu.org; Tue, 07 Apr 2020 14:26:02 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1jLsvB-0006yG-Rk
 for guix-patches@gnu.org; Tue, 07 Apr 2020 14:26:01 -0400
Subject: [bug#40468] [PATCH 3/3] gnu: Add shiru-lv2.
Resent-Message-ID: <handler.40468.B40468.158628392126744@debbugs.gnu.org>
Date: Tue, 7 Apr 2020 14:25:11 -0400
From: Leo Famulari <leo@famulari.name>
Message-ID: <20200407182511.GA9039@jasmine.lan>
References: <053db596207697e4b7d32b55a965b2ba88beca75.camel@zrythm.org>
 <e43d20b120dd66887e587ac9d157dd7d7df4e411.camel@zrythm.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <e43d20b120dd66887e587ac9d157dd7d7df4e411.camel@zrythm.org>
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/guix-patches>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Alexandros Theodotou <alex@zrythm.org>
Cc: 40468@debbugs.gnu.org

On Mon, Apr 06, 2020 at 10:28:35PM +0100, Alexandros Theodotou wrote:
> * gnu/packages/music.scm (shiru-lv2): New variable.

Thanks!

> +(define-public shiru-lv2
> +  (let ((commit "08853f99140012234649e67e5647906fda74f6cc")
> +        (revision "1"))
> +    (package/inherit dragonfly-reverb

If inheriting, we should use the regular inherit procedure, like this:

(package
  (inherit dragonfly-reverb)
  ...)

package/inherit is for special cases related to grafting and replacement
packages. [0]

Anyways, it looks like the inherited fields are build-system,
native-inputs, and arguments. Is the idea that there is some build
complication common to the LV2 plugins that we don't want to copy
around? Maybe we could make a build system for them.

Does it work to inherit the custom install phase from dragonfly-reverb?
It seems like the install-file procedures would not apply here.

What do you think? Sorry if I've missed something.

[0]
https://guix.gnu.org/manual/en/html_node/Security-Updates.html