From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:470:142:3::10]:57857)
 by lists.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1jKLzS-00026p-0q
 for guix-patches@gnu.org; Fri, 03 Apr 2020 09:04:06 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1jKLzO-0005ES-Mk
 for guix-patches@gnu.org; Fri, 03 Apr 2020 09:04:05 -0400
Received: from debbugs.gnu.org ([209.51.188.43]:58057)
 by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
 (Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
 id 1jKLzO-0005EL-Ep
 for guix-patches@gnu.org; Fri, 03 Apr 2020 09:04:02 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1jKLzO-0007F7-8V
 for guix-patches@gnu.org; Fri, 03 Apr 2020 09:04:02 -0400
Subject: [bug#40274] [PATCH v4] gnu: Add kernel-module-loader-service.
Resent-Message-ID: <handler.40274.B40274.158591900027689@debbugs.gnu.org>
Date: Fri, 3 Apr 2020 15:03:16 +0200
From: "pelzflorian (Florian Pelz)" <pelzflorian@pelzflorian.de>
Message-ID: <20200403130316.ksrqtl6eq2amjmcl@pelzflorian.localdomain>
References: <20200328135908.2540-1-brice@waegenei.re>
 <20200331202340.10054-1-brice@waegenei.re>
 <20200401193458.evg46ygamtniby7k@pelzflorian.localdomain>
 <64e7eade2865209e84940a1cbca3313a@waegenei.re>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <64e7eade2865209e84940a1cbca3313a@waegenei.re>
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/guix-patches>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Brice Waegeneire <brice@waegenei.re>
Cc: 40274@debbugs.gnu.org

On Thu, Apr 02, 2020 at 12:40:00PM +0000, Brice Waegeneire wrote:
> On 2020-04-01 19:34, pelzflorian (Florian Pelz) wrote:
> > failed to load service: kernel-module-loader
> This a message saying it can't load that service, in this case because
> it's parameters weren't formatted correctly, this is not specific to
> this service that's how shepherd handle failing to load a service.
> Please open a new issue about it if you think (as I do) that shepherd
> should be more explicit when it fails to load a service.

I meant compilation could fail if the parameters are incorrect.  I do
not know how else Shepherd should fail.  But this is not very
important and applies to many other services as well.

Thank you for adding logging.  All this works well (in testing, I have
not read the code).

Regards,
Florian