* [bug#40383] [PATCH 0/5] Make some inputs native. @ 2020-04-01 23:20 Vincent Legoll 2020-04-01 23:22 ` [bug#40383] [PATCH 1/5] gnu: darktable: " Vincent Legoll ` (2 more replies) 0 siblings, 3 replies; 11+ messages in thread From: Vincent Legoll @ 2020-04-01 23:20 UTC (permalink / raw) To: 40383 This is the reworked patchset sent yesterday to guix-devel. I hope I did not miss any review comment. I dropped the cgit patch, reworded the commit messages, added perl to the native-inputs of darktable, guix linted all (graphviz still has some lint problems, looks like they moved to gitlab, I'll let that for another day) -- Vincent Legoll ^ permalink raw reply [flat|nested] 11+ messages in thread
* [bug#40383] [PATCH 1/5] gnu: darktable: Make some inputs native. 2020-04-01 23:20 [bug#40383] [PATCH 0/5] Make some inputs native Vincent Legoll @ 2020-04-01 23:22 ` Vincent Legoll 2020-04-01 23:22 ` [bug#40383] [PATCH 2/5] gnu: graphviz: " Vincent Legoll ` (3 more replies) 2020-04-02 9:16 ` [bug#40383] [PATCH 0/5] " Mathieu Othacehe 2020-04-02 17:44 ` [bug#40383] numerous rebuilds Vincent Legoll 2 siblings, 4 replies; 11+ messages in thread From: Vincent Legoll @ 2020-04-01 23:22 UTC (permalink / raw) To: 40383; +Cc: Vincent Legoll * gnu/packages/photo.scm (darktable)[inputs]: Move intltool, perl & pkg-config from here... [native-inputs]: ...to here. --- gnu/packages/photo.scm | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/gnu/packages/photo.scm b/gnu/packages/photo.scm index 585289daf1..7cb67dcbe6 100644 --- a/gnu/packages/photo.scm +++ b/gnu/packages/photo.scm @@ -7,6 +7,7 @@ ;;; Copyright © 2018, 2019 Tobias Geerinckx-Rice <me@tobias.gr> ;;; Copyright © 2018 Leo Famulari <leo@famulari.name> ;;; Copyright © 2020 Sebastian Schott <sschott@mailbox.org> +;;; Copyright © 2020 Vincent Legoll <vincent.legoll@gmail.com> ;;; ;;; This file is part of GNU Guix. ;;; @@ -483,6 +484,10 @@ photographic equipment.") (string-append (assoc-ref inputs "ilmbase") "/include/OpenEXR:" (or (getenv "CPATH") ""))) #t))))) + (native-inputs + `(("intltool" ,intltool) + ("perl" ,perl) + ("pkg-config" ,pkg-config))) (inputs `(("libxslt" ,libxslt) ("libxml2" ,libxml2) @@ -502,9 +507,6 @@ photographic equipment.") ("ilmbase" ,ilmbase) ("libsoup" ,libsoup) ("python-jsonschema" ,python-jsonschema) - ("intltool" ,intltool) - ("perl" ,perl) - ("pkg-config" ,pkg-config) ("libwebp" ,libwebp) ("lensfun" ,lensfun) ("librsvg" ,librsvg) -- 2.25.2 ^ permalink raw reply related [flat|nested] 11+ messages in thread
* [bug#40383] [PATCH 2/5] gnu: graphviz: Make some inputs native. 2020-04-01 23:22 ` [bug#40383] [PATCH 1/5] gnu: darktable: " Vincent Legoll @ 2020-04-01 23:22 ` Vincent Legoll 2020-04-01 23:22 ` [bug#40383] [PATCH 3/5] gnu: iwd: " Vincent Legoll ` (2 subsequent siblings) 3 siblings, 0 replies; 11+ messages in thread From: Vincent Legoll @ 2020-04-01 23:22 UTC (permalink / raw) To: 40383; +Cc: Vincent Legoll * gnu/packages/graphviz.scm (graphviz)[inputs]: Move swig from here... [native-inputs]: ...to here. --- gnu/packages/graphviz.scm | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/gnu/packages/graphviz.scm b/gnu/packages/graphviz.scm index 2d2bb11130..051089881a 100644 --- a/gnu/packages/graphviz.scm +++ b/gnu/packages/graphviz.scm @@ -7,6 +7,7 @@ ;;; Copyright © 2017 Gábor Boskovits <boskovits@gmail.com> ;;; Copyright © 2018 Mathieu Lirzin <mthl@gnu.org> ;;; Copyright © 2020 Marius Bakke <mbakke@fastmail.com> +;;; Copyright © 2020 Vincent Legoll <vincent.legoll@gmail.com> ;;; ;;; This file is part of GNU Guix. ;;; @@ -97,7 +98,6 @@ ("gts" ,gts) ("gd" ,gd) ; FIXME: Our GD is too old ("guile" ,guile-2.0) ;Guile bindings - ("swig" ,swig) ("pango" ,pango) ("fontconfig" ,fontconfig) ("freetype" ,freetype) @@ -108,6 +108,7 @@ ("libpng" ,libpng))) (native-inputs `(("bison" ,bison) + ("swig" ,swig) ("pkg-config" ,pkg-config))) (outputs '("out" "doc")) ; 5 MiB of html + pdfs (home-page "http://www.graphviz.org/") -- 2.25.2 ^ permalink raw reply related [flat|nested] 11+ messages in thread
* [bug#40383] [PATCH 3/5] gnu: iwd: Make some inputs native. 2020-04-01 23:22 ` [bug#40383] [PATCH 1/5] gnu: darktable: " Vincent Legoll 2020-04-01 23:22 ` [bug#40383] [PATCH 2/5] gnu: graphviz: " Vincent Legoll @ 2020-04-01 23:22 ` Vincent Legoll 2020-04-01 23:22 ` [bug#40383] [PATCH 4/5] gnu: mailutils: " Vincent Legoll 2020-04-01 23:22 ` [bug#40383] [PATCH 5/5] gnu: nethack: " Vincent Legoll 3 siblings, 0 replies; 11+ messages in thread From: Vincent Legoll @ 2020-04-01 23:22 UTC (permalink / raw) To: 40383; +Cc: Vincent Legoll * gnu/packages/networking.scm (iwd)[inputs]: Move libtool from here... [native-inputs]: ...to here. --- gnu/packages/networking.scm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gnu/packages/networking.scm b/gnu/packages/networking.scm index ec2f0b64bd..79b07e23f0 100644 --- a/gnu/packages/networking.scm +++ b/gnu/packages/networking.scm @@ -2712,13 +2712,13 @@ protocol daemons for BGP, IS-IS, LDP, OSPF, PIM, and RIP. ") (build-system gnu-build-system) (inputs `(("dbus" ,dbus) - ("libtool" ,libtool) ("ell" ,ell) ("readline" ,readline))) (native-inputs `(("asciidoc" ,asciidoc) ("autoconf" ,autoconf) ("automake" ,automake) + ("libtool" ,libtool) ("pkgconfig" ,pkg-config) ("python" ,python) ("openssl" ,openssl))) -- 2.25.2 ^ permalink raw reply related [flat|nested] 11+ messages in thread
* [bug#40383] [PATCH 4/5] gnu: mailutils: Make some inputs native. 2020-04-01 23:22 ` [bug#40383] [PATCH 1/5] gnu: darktable: " Vincent Legoll 2020-04-01 23:22 ` [bug#40383] [PATCH 2/5] gnu: graphviz: " Vincent Legoll 2020-04-01 23:22 ` [bug#40383] [PATCH 3/5] gnu: iwd: " Vincent Legoll @ 2020-04-01 23:22 ` Vincent Legoll 2020-04-01 23:22 ` [bug#40383] [PATCH 5/5] gnu: nethack: " Vincent Legoll 3 siblings, 0 replies; 11+ messages in thread From: Vincent Legoll @ 2020-04-01 23:22 UTC (permalink / raw) To: 40383; +Cc: Vincent Legoll * gnu/packages/mail.scm (mailutils)[inputs]: Move dejagnu from here... [native-inputs]: ...to here. --- gnu/packages/mail.scm | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/gnu/packages/mail.scm b/gnu/packages/mail.scm index 0cb3eddf15..ed14360066 100644 --- a/gnu/packages/mail.scm +++ b/gnu/packages/mail.scm @@ -29,6 +29,7 @@ ;;; Copyright © 2018 Gábor Boskovits <boskovits@gmail.com> ;;; Copyright © 2018, 2019, 2020 Ricardo Wurmus <rekado@elephly.net> ;;; Copyright © 2019 Tanguy Le Carrour <tanguy@bioneland.org> +;;; Copyright © 2020 Vincent Legoll <vincent.legoll@gmail.com> ;;; ;;; This file is part of GNU Guix. ;;; @@ -218,11 +219,11 @@ #:parallel-tests? #f)) (native-inputs - `(("perl" ,perl))) ;for 'gylwrap' - (inputs - `(("dejagnu" ,dejagnu) - ("m4" ,m4) + `(("perl" ,perl) ;for 'gylwrap' ("texinfo" ,texinfo) + ("dejagnu" ,dejagnu))) + (inputs + `(("m4" ,m4) ("guile" ,guile-2.2) ("gsasl" ,gsasl) ("gnutls" ,gnutls) -- 2.25.2 ^ permalink raw reply related [flat|nested] 11+ messages in thread
* [bug#40383] [PATCH 5/5] gnu: nethack: Make some inputs native. 2020-04-01 23:22 ` [bug#40383] [PATCH 1/5] gnu: darktable: " Vincent Legoll ` (2 preceding siblings ...) 2020-04-01 23:22 ` [bug#40383] [PATCH 4/5] gnu: mailutils: " Vincent Legoll @ 2020-04-01 23:22 ` Vincent Legoll 3 siblings, 0 replies; 11+ messages in thread From: Vincent Legoll @ 2020-04-01 23:22 UTC (permalink / raw) To: 40383; +Cc: Vincent Legoll * gnu/packages/games.scm (nethack)[inputs]: Move flex & bison from here... [native-inputs]: ...to this new field. --- gnu/packages/games.scm | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/gnu/packages/games.scm b/gnu/packages/games.scm index 8a24dad33d..4d4b2b0b05 100644 --- a/gnu/packages/games.scm +++ b/gnu/packages/games.scm @@ -50,6 +50,7 @@ ;;; Copyright © 2020 Naga Malleswari <nagamalli@riseup.net> ;;; Copyright © 2020 Vitaliy Shatrov <D0dyBo0D0dyBo0@protonmail.com> ;;; Copyright © 2020 Jack Hill <jackhill@jackhill.us> +;;; Copyright © 2020 Vincent Legoll <vincent.legoll@gmail.com> ;;; ;;; This file is part of GNU Guix. ;;; @@ -1293,10 +1294,11 @@ watch your CPU playing while enjoying a cup of tea!") (string-join (string-split version #\.) "") "-src.tgz")) (sha256 (base32 "1liyckjp34j354qnxc1zn9730lh1p2dabrg1hap24z6xnqx0rpng")))) + (native-inputs + `(("bison" ,bison) + ("flex" ,flex))) (inputs `(("ncurses" ,ncurses) - ("bison" ,bison) - ("flex" ,flex) ("less" ,less))) (build-system gnu-build-system) (arguments -- 2.25.2 ^ permalink raw reply related [flat|nested] 11+ messages in thread
* [bug#40383] [PATCH 0/5] Make some inputs native. 2020-04-01 23:20 [bug#40383] [PATCH 0/5] Make some inputs native Vincent Legoll 2020-04-01 23:22 ` [bug#40383] [PATCH 1/5] gnu: darktable: " Vincent Legoll @ 2020-04-02 9:16 ` Mathieu Othacehe 2020-04-02 16:01 ` Marius Bakke 2020-04-02 16:20 ` Mathieu Othacehe 2020-04-02 17:44 ` [bug#40383] numerous rebuilds Vincent Legoll 2 siblings, 2 replies; 11+ messages in thread From: Mathieu Othacehe @ 2020-04-02 9:16 UTC (permalink / raw) To: 40383; +Cc: mbakke Hello Vincent, > I hope I did not miss any review comment. > > I dropped the cgit patch, reworded the commit > messages, added perl to the native-inputs of > darktable, guix linted all (graphviz still has some > lint problems, looks like they moved to gitlab, I'll > let that for another day) Thanks for the updated serie. Some of these patches trigger a lot of rebuilds. If you read this page[1], point 8, you will see that there's a limit of 300 dependencies for pushing to master. Graphviz has 1370 dependencies, which makes it a candidate for core-updates branch that has been frozen recently. Maybe we can start a 'core-updates-next' branch. Marius, WDYT? Mailutils has 125 dependencies, which is under the 300 limit so I'll push it on master. The other patches are fine :) Thanks, Mathieu [1]: https://guix.gnu.org/manual/en/html_node/Submitting-Patches.html, ^ permalink raw reply [flat|nested] 11+ messages in thread
* [bug#40383] [PATCH 0/5] Make some inputs native. 2020-04-02 9:16 ` [bug#40383] [PATCH 0/5] " Mathieu Othacehe @ 2020-04-02 16:01 ` Marius Bakke 2020-04-02 16:18 ` Mathieu Othacehe 2020-04-02 16:20 ` Mathieu Othacehe 1 sibling, 1 reply; 11+ messages in thread From: Marius Bakke @ 2020-04-02 16:01 UTC (permalink / raw) To: Mathieu Othacehe; +Cc: 40383 [-- Attachment #1: Type: text/plain, Size: 625 bytes --] Mathieu Othacehe <m.othacehe@gmail.com> writes: > Graphviz has 1370 dependencies, which makes it a candidate for > core-updates branch that has been frozen recently. Maybe we can start a > 'core-updates-next' branch. Marius, WDYT? I've been meaning to rework the rebuild limits from the manual as a lot has changed since that was written. In particular I want to keep "mesa" on 'staging', but that has crept to almost 2000 rebuilds! Perhaps we need another tier in between staging and core-updates, or just aim for slower staging cycles (as has been de facto a while..). Anyway for now I think this can go to 'staging'. [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 487 bytes --] ^ permalink raw reply [flat|nested] 11+ messages in thread
* [bug#40383] [PATCH 0/5] Make some inputs native. 2020-04-02 16:01 ` Marius Bakke @ 2020-04-02 16:18 ` Mathieu Othacehe 0 siblings, 0 replies; 11+ messages in thread From: Mathieu Othacehe @ 2020-04-02 16:18 UTC (permalink / raw) To: Marius Bakke; +Cc: 40383 > I've been meaning to rework the rebuild limits from the manual as a lot > has changed since that was written. In particular I want to keep "mesa" > on 'staging', but that has crept to almost 2000 rebuilds! Yup, an updated documentation section would be great! > > Perhaps we need another tier in between staging and core-updates, or > just aim for slower staging cycles (as has been de facto a while..). > > Anyway for now I think this can go to 'staging'. Ok, pushed on staging, thanks for your help. Mathieu ^ permalink raw reply [flat|nested] 11+ messages in thread
* [bug#40383] [PATCH 0/5] Make some inputs native. 2020-04-02 9:16 ` [bug#40383] [PATCH 0/5] " Mathieu Othacehe 2020-04-02 16:01 ` Marius Bakke @ 2020-04-02 16:20 ` Mathieu Othacehe 1 sibling, 0 replies; 11+ messages in thread From: Mathieu Othacehe @ 2020-04-02 16:20 UTC (permalink / raw) To: 40383; +Cc: 40383-done I pushed the graphviz patch on the staging branch and the other ones on master. Thanks, Mathieu ^ permalink raw reply [flat|nested] 11+ messages in thread
* [bug#40383] numerous rebuilds 2020-04-01 23:20 [bug#40383] [PATCH 0/5] Make some inputs native Vincent Legoll 2020-04-01 23:22 ` [bug#40383] [PATCH 1/5] gnu: darktable: " Vincent Legoll 2020-04-02 9:16 ` [bug#40383] [PATCH 0/5] " Mathieu Othacehe @ 2020-04-02 17:44 ` Vincent Legoll 2 siblings, 0 replies; 11+ messages in thread From: Vincent Legoll @ 2020-04-02 17:44 UTC (permalink / raw) To: 40383 Mathieu, I knew about the rebuild limit, and told about it in the other thread: > The graphviz patch may not be for master > as it may force 2918 packages to be rebuilt. > The other ones should be OK. But it has been a long thread. I should have restated it here, in the repost... Thanks -- Vincent Legoll ^ permalink raw reply [flat|nested] 11+ messages in thread
end of thread, other threads:[~2020-04-02 17:46 UTC | newest] Thread overview: 11+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2020-04-01 23:20 [bug#40383] [PATCH 0/5] Make some inputs native Vincent Legoll 2020-04-01 23:22 ` [bug#40383] [PATCH 1/5] gnu: darktable: " Vincent Legoll 2020-04-01 23:22 ` [bug#40383] [PATCH 2/5] gnu: graphviz: " Vincent Legoll 2020-04-01 23:22 ` [bug#40383] [PATCH 3/5] gnu: iwd: " Vincent Legoll 2020-04-01 23:22 ` [bug#40383] [PATCH 4/5] gnu: mailutils: " Vincent Legoll 2020-04-01 23:22 ` [bug#40383] [PATCH 5/5] gnu: nethack: " Vincent Legoll 2020-04-02 9:16 ` [bug#40383] [PATCH 0/5] " Mathieu Othacehe 2020-04-02 16:01 ` Marius Bakke 2020-04-02 16:18 ` Mathieu Othacehe 2020-04-02 16:20 ` Mathieu Othacehe 2020-04-02 17:44 ` [bug#40383] numerous rebuilds Vincent Legoll
Code repositories for project(s) associated with this external index https://git.savannah.gnu.org/cgit/guix.git This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.