From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:470:142:3::10]:59533)
 by lists.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1jJFTz-0006vr-9J
 for guix-patches@gnu.org; Tue, 31 Mar 2020 07:55:04 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1jJFTy-0005X8-BR
 for guix-patches@gnu.org; Tue, 31 Mar 2020 07:55:03 -0400
Received: from debbugs.gnu.org ([209.51.188.43]:52356)
 by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
 (Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
 id 1jJFTy-0005Wx-7m
 for guix-patches@gnu.org; Tue, 31 Mar 2020 07:55:02 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1jJFTy-00081P-7Q
 for guix-patches@gnu.org; Tue, 31 Mar 2020 07:55:02 -0400
Subject: [bug#40209] [PATCH v3] gnu: Add qiv.
Resent-Message-ID: <handler.40209.B40209.158565565530744@debbugs.gnu.org>
Date: Tue, 31 Mar 2020 17:23:46 +0530
From: R Veera Kumar <vkor@vkten.in>
Message-ID: <20200331115346.GA11075@tulip>
References: <20200324093627.GB3208@tulip> <20200331110355.GA11085@tulip>
 <20200331131712.5b0c7414@scratchpost.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20200331131712.5b0c7414@scratchpost.org>
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/guix-patches>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Danny Milosavljevic <dannym@scratchpost.org>
Cc: 40209@debbugs.gnu.org

On Tue, Mar 31, 2020 at 01:17:12PM +0200, Danny Milosavljevic wrote:
> Hi Veera,
> 
> thanks!
> 
> > +       ;; make install runs the built qiv binary
> > +       ;; which fails as no X in build env
> 
> But that should mean that this package should fail to install.
> 
> Doesn't it?
> 

I am running the build in X environment (Mate DM).

Package builds fine. And installs fine. And works fine.

The Makefile has this:

	@if ./qiv -f ./intro.jpg ; \
        then echo "-- Test Passed --" ; \
        else echo "-- Test Failed --" ; \
        fi

It justs echos this in build log which I saw.

> Also, you can just start an X server. (search for the text "Xvfb" in gnu/packages)
>

Is it neccessary?

Am finding about it. 
 
> Everything else it fine.

Thanks,
R Veera Kumar