From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:470:142:3::10]:35110) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jJCxE-0002A4-W1 for guix-patches@gnu.org; Tue, 31 Mar 2020 05:13:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jJCxC-0004tM-QX for guix-patches@gnu.org; Tue, 31 Mar 2020 05:13:04 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:52197) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1jJCxC-0004tG-Mk for guix-patches@gnu.org; Tue, 31 Mar 2020 05:13:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jJCxC-0005q0-HJ for guix-patches@gnu.org; Tue, 31 Mar 2020 05:13:02 -0400 Subject: [bug#40320] [PATCH 1/2] gnu: Add libqalculate Resent-Message-ID: Date: Tue, 31 Mar 2020 14:42:24 +0530 From: R Veera Kumar Message-ID: <20200331091224.GA7226@tulip> References: <20200330124539.79f6568a@scratchpost.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200330124539.79f6568a@scratchpost.org> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Danny Milosavljevic Cc: 40320@debbugs.gnu.org On Mon, Mar 30, 2020 at 12:45:39PM +0200, Danny Milosavljevic wrote: > Hi Veera, > > thanks for the patch! > > I have a few suggestions: > > On Mon, 30 Mar 2020 10:52:23 +0530 > R Veera Kumar wrote: > > > + ("automake" ,automake) > > + ("autoconf" ,autoconf) > > It's unusual to need those in a release. Why are they necessary? > The github release tarball includes the configure script but the not the git clone checkout of tag version. It has only autogen.sh script. The website explicitly says that and I have also checked it. Thanks, R Veera Kumar India [OUTREACHY CONTRIB]