From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:470:142:3::10]:38856) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jFcv6-0007Wd-0z for guix-patches@gnu.org; Sat, 21 Mar 2020 08:08:05 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jFcv4-0007Mi-UO for guix-patches@gnu.org; Sat, 21 Mar 2020 08:08:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:40089) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1jFcv4-0007Ma-QJ for guix-patches@gnu.org; Sat, 21 Mar 2020 08:08:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jFcv4-0004TT-Ka for guix-patches@gnu.org; Sat, 21 Mar 2020 08:08:02 -0400 Subject: bug#40154: [PATCH] gnu: Add hash-extender. Resent-To: guix-patches@gnu.org Resent-Message-ID: Date: Sat, 21 Mar 2020 13:07:55 +0100 From: Jakub =?UTF-8?Q?K=C4=85dzio=C5=82ka?= Message-ID: <20200321120755.yzi6ktwlwcnm4k4p@gravity> References: <20200320193250.31290-1-kuba@kadziolka.net> <20200320202103.GA8474@jasmine.lan> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="b2rs6mt75gnae7lq" Content-Disposition: inline In-Reply-To: <20200320202103.GA8474@jasmine.lan> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Leo Famulari Cc: 40154-done@debbugs.gnu.org --b2rs6mt75gnae7lq Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Mar 20, 2020 at 04:21:03PM -0400, Leo Famulari wrote: > On Fri, Mar 20, 2020 at 08:32:49PM +0100, Jakub K=C4=85dzio=C5=82ka wrote: > > --- > > gnu/packages/crypto.scm | 39 +++++++++++++++++++ > > .../patches/hash-extender-test-suite.patch | 12 ++++++ >=20 > Remember to register the patch file in 'gnu/local.mk' and mention it in > the commit message. Ugh, I always forget to do this, even though I always notice it's missing when I'm *reviewing* patches. > > + (replace 'install > > + (lambda* (#:key outputs #:allow-other-keys) > > + (let* ((outdir (assoc-ref outputs "out")) > > + (bindir (string-append outdir "/bin"))) > > + (install-file "hash_extender" bindir))))))) >=20 > Can you install the README.md too? It would go under something like: > (string-append "share/doc/hash-extender" ,version "/") >=20 > ... so that it fits correctly in the user's profile. Huh. For a moment I thought the version is pointless here, but then I noticed the LICENSE file. I did as suggested, though with a dash before the version. > > diff --git a/gnu/packages/patches/hash-extender-test-suite.patch b/gnu/= packages/patches/hash-extender-test-suite.patch >=20 > And I would consider submitting this patch upstream. Good idea! Thanks for your review! Amended patch pushed as bbeb710de70521010b3d432cb5b4b14ce6e45ca6. --b2rs6mt75gnae7lq Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEE5Xa/ss9usT31cTO54xWnWEYTFWQFAl52A5YACgkQ4xWnWEYT FWQ9BA//SBrN2nsC4FsTea+wmnc0mPcRO9hUTtZYuVPcyGWBGLaaDd4+9XJdboHD OUtka4qUgYx9GYgv3pjBJ2s5CPTE3RlKFwFDjQ67TU4bkImvli9lOgSs3ePPxI8m pebBLvjM6wpoKfJGDd6Mmr5Gkm6FAhT6JMgH/PqCP4nSiaBMv61HrNZh/AFIm6x3 1B+WiyGYW3zTL6gzqj1GsdidTuxdxRHyEUtrhzCUb2x4T2M6ABvLrXgqTV/awdTF ushVxB3GYugw70oZJ/sdrRHpS7UQGLhssLOA3mRtPfy0xdKWNYdiIk9L4MKWAM7x 7vtS1pzahIJOOFzCe8RzB5mVwH3ZXPu0ioYdQHtUodOafDlwoCPEeImjcv9YioKj 83Wb5P/7R4bjvJmCA9lRRUWMEy82/P/HGWpDHQoBl1BEK36EFclsYSAQn950HyCl XJg6Xnkk44vESYWGkDMM6cumnMK2jw7OvpjAnOokQ6HWv87U7kA88M4pDjaM5nWY qSr3BFg4f9LI9IbgluBvV6NnLE3pgPqA1XiTaxdt9VAGJR4FhlS1UqCL5ZfeLKEc hCSYw7r3PihBI5Id5psbRLIQ3ZBQbMTYdQzzM8uHZ83tqbGt5iY+JkEVrnrXN8rB cGbK7U59z+i5xoJzBBd1by/gx5wEoMmb95nk6hOgZfyc7aVhTZw= =Or5S -----END PGP SIGNATURE----- --b2rs6mt75gnae7lq--