From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:470:142:3::10]:36423)
 by lists.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1jFO9a-0005Dg-W3
 for guix-patches@gnu.org; Fri, 20 Mar 2020 16:22:03 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1jFO9Z-0002a2-Ua
 for guix-patches@gnu.org; Fri, 20 Mar 2020 16:22:02 -0400
Received: from debbugs.gnu.org ([209.51.188.43]:39736)
 by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
 (Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
 id 1jFO9Z-0002ZI-OW
 for guix-patches@gnu.org; Fri, 20 Mar 2020 16:22:01 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1jFO9Z-0000ph-Jy
 for guix-patches@gnu.org; Fri, 20 Mar 2020 16:22:01 -0400
Subject: [bug#40154] [PATCH] gnu: Add hash-extender.
Resent-Message-ID: <handler.40154.B40154.15847356723126@debbugs.gnu.org>
Date: Fri, 20 Mar 2020 16:21:03 -0400
From: Leo Famulari <leo@famulari.name>
Message-ID: <20200320202103.GA8474@jasmine.lan>
References: <20200320193250.31290-1-kuba@kadziolka.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20200320193250.31290-1-kuba@kadziolka.net>
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/guix-patches>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Jakub =?UTF-8?Q?K=C4=85dzio=C5=82ka?= <kuba@kadziolka.net>
Cc: 40154@debbugs.gnu.org

On Fri, Mar 20, 2020 at 08:32:49PM +0100, Jakub Kądziołka wrote:
> * gnu/packages/crypto.scm (hash-extender): New variable.

Thanks!

> ---
>  gnu/packages/crypto.scm                       | 39 +++++++++++++++++++
>  .../patches/hash-extender-test-suite.patch    | 12 ++++++

Remember to register the patch file in 'gnu/local.mk' and mention it in
the commit message.

> +           (replace 'install
> +             (lambda* (#:key outputs #:allow-other-keys)
> +               (let* ((outdir (assoc-ref outputs "out"))
> +                      (bindir (string-append outdir "/bin")))
> +                 (install-file "hash_extender" bindir)))))))

Can you install the README.md too? It would go under something like:
(string-append "share/doc/hash-extender" ,version "/")

... so that it fits correctly in the user's profile.

> diff --git a/gnu/packages/patches/hash-extender-test-suite.patch b/gnu/packages/patches/hash-extender-test-suite.patch

And I would consider submitting this patch upstream.