all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Leo Famulari <leo@famulari.name>
To: "Jakub Kądziołka" <kuba@kadziolka.net>
Cc: 40154@debbugs.gnu.org
Subject: [bug#40154] [PATCH] gnu: Add hash-extender.
Date: Fri, 20 Mar 2020 16:21:03 -0400	[thread overview]
Message-ID: <20200320202103.GA8474@jasmine.lan> (raw)
In-Reply-To: <20200320193250.31290-1-kuba@kadziolka.net>

On Fri, Mar 20, 2020 at 08:32:49PM +0100, Jakub Kądziołka wrote:
> * gnu/packages/crypto.scm (hash-extender): New variable.

Thanks!

> ---
>  gnu/packages/crypto.scm                       | 39 +++++++++++++++++++
>  .../patches/hash-extender-test-suite.patch    | 12 ++++++

Remember to register the patch file in 'gnu/local.mk' and mention it in
the commit message.

> +           (replace 'install
> +             (lambda* (#:key outputs #:allow-other-keys)
> +               (let* ((outdir (assoc-ref outputs "out"))
> +                      (bindir (string-append outdir "/bin")))
> +                 (install-file "hash_extender" bindir)))))))

Can you install the README.md too? It would go under something like:
(string-append "share/doc/hash-extender" ,version "/")

... so that it fits correctly in the user's profile.

> diff --git a/gnu/packages/patches/hash-extender-test-suite.patch b/gnu/packages/patches/hash-extender-test-suite.patch

And I would consider submitting this patch upstream.

  reply	other threads:[~2020-03-20 20:22 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-20 19:32 [bug#40154] [PATCH] gnu: Add hash-extender Jakub Kądziołka
2020-03-20 20:21 ` Leo Famulari [this message]
2020-03-21 12:07   ` bug#40154: " Jakub Kądziołka

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200320202103.GA8474@jasmine.lan \
    --to=leo@famulari.name \
    --cc=40154@debbugs.gnu.org \
    --cc=kuba@kadziolka.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.