From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:470:142:3::10]:46225) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jFDDD-0005vj-C4 for guix-patches@gnu.org; Fri, 20 Mar 2020 04:41:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jFDDC-0002RN-5B for guix-patches@gnu.org; Fri, 20 Mar 2020 04:41:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:37971) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1jFDDC-0002RF-1P for guix-patches@gnu.org; Fri, 20 Mar 2020 04:41:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jFDDB-0000j2-Vb for guix-patches@gnu.org; Fri, 20 Mar 2020 04:41:01 -0400 Subject: [bug#40084] [PATCH] gnu: Add v86d. Resent-Message-ID: Received: from eggs.gnu.org ([2001:470:142:3::10]:46164) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jFDCI-0005p8-He for guix-patches@gnu.org; Fri, 20 Mar 2020 04:40:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jFDCH-0001gN-A8 for guix-patches@gnu.org; Fri, 20 Mar 2020 04:40:06 -0400 Received: from pelzflorian.de ([5.45.111.108]:47296 helo=mail.pelzflorian.de) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1jFDCG-0001eu-Qh for guix-patches@gnu.org; Fri, 20 Mar 2020 04:40:05 -0400 Date: Fri, 20 Mar 2020 09:40:00 +0100 From: "pelzflorian (Florian Pelz)" Message-ID: <20200320084000.h56hditmdkqcxekj@pelzflorian.localdomain> References: <20200315214851.30981-1-pelzflorian@pelzflorian.de> <20200319144908.vfhtepo33lpmunhu@gravity> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20200319144908.vfhtepo33lpmunhu@gravity> Content-Transfer-Encoding: quoted-printable List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Jakub =?UTF-8?Q?K=C4=85dzio=C5=82ka?= Cc: 40084@debbugs.gnu.org On Thu, Mar 19, 2020 at 03:49:08PM +0100, Jakub K=C4=85dzio=C5=82ka wrote= : > I don't see why you're decompressing the tarball manually, this seems t= o > work just as well: > [=E2=80=A6] > If it's about efficiency or robustness in some way, I'd suggest leaving > a comment detailing the reason. Either way, I'd bind the path to tar in > a `let', as well as the path to "xorg-server-sources" if we decide to > not decompress separately. >=20 Your review is much appreciated. Having tar do the decompression is much better. Before I had copied the decompression without checking from my earlier patch for nginx-accept-language-module. I think at the time tar for some reason did not do auto-decompression when building. Or maybe manual decompression already was unnecessary back then. I have tested on multiple computers, sufficiently I believe, so I pushed with your changes as e2303e8e375ed2e07c1fd760c86a204eb51fbc6e. I also pushed similar changes to the decompression in nginx-accept-language-module as e84490346d8dac3720a57a331f533ce67ff0da1c. > > + (replace 'configure > > + (lambda* (#:key outputs #:allow-other-keys) > > + (let ((out (assoc-ref outputs "out"))) > > + (setenv "CC" (which "gcc")) > > + (setenv "DESTDIR" out) > > + (invoke "./configure" "--with-x86emu")))) > > + (add-after 'build 'build-testvbe > > + (lambda _ > > + (invoke "make" "testvbe"))) > > + (add-after 'install 'install-testvbe > > + (lambda* (#:key outputs #:allow-other-keys) > > + (let ((testvbe (assoc-ref outputs "testvbe")) > > + (olddest (getenv "DESTDIR"))) > > + (setenv "DESTDIR" testvbe) > > + (invoke "make" "install_testvbe") > > + (setenv "DESTDIR" olddest)))) >=20 > These phases are missing the trailing #t. > I missed the #t for the install-testvbe phase. Thank you! According to the docstring of (define (invoke program . args) "Invoke PROGRAM with the given ARGS. Raise an exception if the exit code is non-zero; otherwise return #t." in guix/build/utils.scm, invoke always returns #t, so I did not change the phases ending in invoke. > I don't know how to test the package, but it passes lint & build, > including --rounds=3D2 to check for reproducibility. >=20 > Regards, > Jakub K=C4=85dzio=C5=82ka The important user of v86d is uvesafb. uvesafb allows me to make Xorg work on multiple computers of mine with #!/bin/sh modprobe uvesafb mode_option=3D1280x800-32 \ v86d=3D/run/current-system/profile/sbin/v86d chmod o+rw /dev/fb0 sleep 1 herd restart xorg-server On many computers, the behavior can be tested when having a service (set-xorg-configuration (xorg-configuration (modules (list xf86-video-fbdev xf86-input-libinput)))) and passing the kernel parameter 'nomodeset' e.g. in GRUB, because then the framebuffer /dev/fb0 is only present when using uvesafb. But I believe I have tested sufficiently. Thank you! Florian