From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:470:142:3::10]:48100) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jDbSN-0000tL-8e for guix-patches@gnu.org; Sun, 15 Mar 2020 18:10:05 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jDbSM-0001CS-6z for guix-patches@gnu.org; Sun, 15 Mar 2020 18:10:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:58028) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1jDbSM-0001BA-3g for guix-patches@gnu.org; Sun, 15 Mar 2020 18:10:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jDbSL-0001qv-T6 for guix-patches@gnu.org; Sun, 15 Mar 2020 18:10:01 -0400 Subject: [bug#37868] [PATCH v6] system: Add kernel-module-packages to operating-system. Resent-Message-ID: Date: Sun, 15 Mar 2020 23:09:04 +0100 From: Danny Milosavljevic Message-ID: <20200315224832.5f2e336c@scratchpost.org> In-Reply-To: <877dzlibaj.fsf@gnu.org> References: <20200226195929.3615-1-dannym@scratchpost.org> <20200227122519.3226-1-dannym@scratchpost.org> <877dzlibaj.fsf@gnu.org> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="Sig_/Iz1xf+8kjDBAUP0p7xi0vGN"; protocol="application/pgp-signature"; micalg=pgp-sha256 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: Mark H Weaver , 37868@debbugs.gnu.org --Sig_/Iz1xf+8kjDBAUP0p7xi0vGN Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Hi Ludo, On Sun, 15 Mar 2020 22:00:04 +0100 Ludovic Court=C3=A8s wrote: > I don=E2=80=99t think #:allow-collisions?, #:locales? and #:relative-syml= inks? > are needed, so I=E2=80=99d recommend removing them. Removing allow-collisions. Otherwise the defaults are different. I'm pretty sure that we don't need locales for Linux kernel modules, for example :) That said, I can do it--but it would increase build dependencies. > > + (let* ((inputs '#$(manifest-inputs manifest)) > > + (module-directories #$(input-files (manifest-inputs= manifest) "/lib/modules")) > > + (directory-entries > > + (lambda (directory-name) > > + (scandir directory-name (lambda (basename) > > + (not (string-prefix? "= ." basename)))))) =20 >=20 > also one-word identifiers are preferred for local > variables. I'd like to do that but it would lose information here. "modules" would be too vague. "directories" would be non-unique. (What "module-directories" means is "'/lib/modules'-directories", literally) "entries" would be too vague too. Entries of what? (Especially since that's a procedure). I'll make it say "directory" instead of "directory-name" there. Note: The "existing-files" procedure exists only in order to allow us to build Linux kernels without any modules (neither in linux-libre nor anywhere else) and have the profile hook succeed. Maybe it's written in an overly general way for that? What do you think? (It's actually kinda bad that I ignore kernel-loadable-modules which have no "/lib/modules" in it (better would be an error)--but I wasn't sure whether manifest-inputs is guaranteed to keep the original order of the entries--which would be: linux-libre first) --Sig_/Iz1xf+8kjDBAUP0p7xi0vGN Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEds7GsXJ0tGXALbPZ5xo1VCwwuqUFAl5up4AACgkQ5xo1VCww uqXoSwf/XSlyTXoS5uD8S9OQwdr8Q0jN9HI6ZX18Buw3mn9ZY6c5rxlIthCvgUaJ eEmd7KONWBHpNzwqLi8miBSkfYziDyv80BHt8qJuiY9sLK4xPl810XL0eMqB5QN2 U1Mpsj8IiIyZ2DzuZKV4FB3Wh+z7f+yWdjpBrbqWVZty9UpQrDrE2rA8JyRgGAxY HShfTtduD82zm6nZg/ChOGe2mixe/eeqcF6cvRDv/o8f5Hzfw2QRpA1TZT3PyZBo Ceejq1UFj7rQ0o7BubcIsrcHMrEbV8y5nMOczB4lf4UaV0wHYJVBmcf4EH99j/YC FYjN3fZN4HhGYnvIOayf6KBmwa7gtg== =Lrsc -----END PGP SIGNATURE----- --Sig_/Iz1xf+8kjDBAUP0p7xi0vGN--