From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:470:142:3::10]:38640) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jDXpu-00081l-2W for guix-patches@gnu.org; Sun, 15 Mar 2020 14:18:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jDXps-0007OA-9M for guix-patches@gnu.org; Sun, 15 Mar 2020 14:18:05 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:57772) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1jDXpq-0007Ig-Po for guix-patches@gnu.org; Sun, 15 Mar 2020 14:18:03 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jDXpq-0003tX-In for guix-patches@gnu.org; Sun, 15 Mar 2020 14:18:02 -0400 Subject: [bug#37868] [PATCH v8] system: Add kernel-module-packages to operating-system. Resent-Message-ID: Date: Sun, 15 Mar 2020 19:17:36 +0100 From: Danny Milosavljevic Message-ID: <20200315191736.33ed8abf@scratchpost.org> In-Reply-To: <877dzlgbe2.fsf@gmail.com> References: <20200227135146.5701-1-dannym@scratchpost.org> <20200227155029.2542-1-dannym@scratchpost.org> <20200314194055.6d857037@scratchpost.org> <877dzlgbe2.fsf@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="Sig_/zPeYuyrtERVkVbl_LBAZ.0R"; protocol="application/pgp-signature"; micalg=pgp-sha256 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Mathieu Othacehe Cc: mhw@netris.org, ludo@gnu.org, 37868@debbugs.gnu.org --Sig_/zPeYuyrtERVkVbl_LBAZ.0R Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable Hi Mathieu, On Sun, 15 Mar 2020 11:28:37 +0100 Mathieu Othacehe wrote: > Yes, "profile-derivation" should use the current system or target if the > #:system and #:target arguments are #f. OK! > In that case, you should use #+kmod instead of #$kmod. This way, when > cross-compiling, the native kmod would be used. > Anyway, if you're willing to wait a few days, I can test your patch does > not break system cross-compilation on core-updates. Sure. > The man page of depmod says that '-F' and '-E' options are mutually > exclusive. Linus Torvalds seems to be in favor of not supporting Module.symvers anymor= e, so let's use "-F"... >=20 > + (let* ((versions (filter (lambda (name) > + (not (string-prefix? "." name)= )) > + (scandir moddir))) > + (version (match versions > + ((x) x)))) >=20 > If versions only contains one element, then you can use find instead of > filtering and matching. I don't really know that it only contains one element. In normal supported operation it should--but if the user does something stupid (put kernel version A and module version B into the operating-system, where A !=3D B), I want it to fail and not depmod half the things (neither all the things, f= or that matter). > As stated above, I think you are fine removing the TODO. Cool! --Sig_/zPeYuyrtERVkVbl_LBAZ.0R Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEds7GsXJ0tGXALbPZ5xo1VCwwuqUFAl5ucUAACgkQ5xo1VCww uqVidgf/a/Q3RJEAZUsFuElmRQuRshz2+gw2JNAwemJKhLQasWPqsDErIqrNfAhU mdrAGGEI3LaFwuPldrgAxZKBTIKCunjmZcgX9s8GqFds2ayQOSPhkqKrLg+vTt8G QXGtWuZuLXY3KPGfb/wXGFy0K3EGvOfRnFC6b29XB8rVb+wFpZ2X9wz6TOpGUZBz c8oaTqq7BulOgoyu+tJTSGGLcju99rlSTYDiVbd+wluUV+P8O5CLn3uxNw521Slg QrbZYmMqr1r6QjdDzGblr+Yub36VN8tSNA13meyu3AJenmoAvFiOaMn/Z6G7SnAm 22QPMZ89z27DCHdSbT73L9gTqtR1iA== =9DR3 -----END PGP SIGNATURE----- --Sig_/zPeYuyrtERVkVbl_LBAZ.0R--