From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:470:142:3::10]:37288)
 by lists.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1jDYIt-0000Pz-JA
 for guix-patches@gnu.org; Sun, 15 Mar 2020 14:48:04 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1jDYIs-0007Bb-IW
 for guix-patches@gnu.org; Sun, 15 Mar 2020 14:48:03 -0400
Received: from debbugs.gnu.org ([209.51.188.43]:57843)
 by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
 (Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
 id 1jDYIs-00079K-Cd
 for guix-patches@gnu.org; Sun, 15 Mar 2020 14:48:02 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1jDYIs-0004kZ-AP
 for guix-patches@gnu.org; Sun, 15 Mar 2020 14:48:02 -0400
Subject: [bug#39292] [PATCH 01/10] gnu: Add python-pymediainfo
Resent-Message-ID: <handler.39292.B39292.158429805718198@debbugs.gnu.org>
Date: Sun, 15 Mar 2020 14:47:28 -0400
From: Leo Famulari <leo@famulari.name>
Message-ID: <20200315184728.GG5561@jasmine.lan>
References: <160809722.12896.1580033265330@office.mailbox.org>
 <20200307151146.2581-1-sschott@mailbox.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20200307151146.2581-1-sschott@mailbox.org>
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/guix-patches>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Sebastian Schott <sschott@mailbox.org>
Cc: 39292@debbugs.gnu.org

On Sat, Mar 07, 2020 at 04:11:37PM +0100, Sebastian Schott wrote:
> * gnu/packages/python-xyz.scm (python-pymediainfo): New variable.

Thanks for this patch series Sebastian! Overall it looks good...

I only have one nitpick:

> +             ;; Skip the only failing test "test_parse_url"
> +             (invoke "pytest" "-vv" "-k" "not test_parse_url")
> +             #t)))))

How does the test fail? We should add comments explaining why tests are
skipped, not just that they are fail so we skip them :)

And while you are adding that comment or fixing the test, can you rebase
the patches on the current master branch? They no longer apply due to
other changes in python-xyz.scm.