From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:470:142:3::10]:34535) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jB8aS-0004JV-D6 for guix-patches@gnu.org; Sun, 08 Mar 2020 22:56:13 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jB8aR-0001dI-9b for guix-patches@gnu.org; Sun, 08 Mar 2020 22:56:12 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:43656) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1jB8aR-0001dC-6g for guix-patches@gnu.org; Sun, 08 Mar 2020 22:56:11 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jB5GA-0000QF-H5 for guix-patches@gnu.org; Sun, 08 Mar 2020 19:23:02 -0400 Subject: bug#39932: [PATCH 1/3] gnu: python-xyz: Add python-distlib. Resent-To: guix-patches@gnu.org Resent-Message-ID: Date: Mon, 9 Mar 2020 00:22:57 +0100 From: Jakub =?UTF-8?Q?K=C4=85dzio=C5=82ka?= Message-ID: <20200308232257.pcwhhzzgetzomayy@gravity> References: <20200305191424.12134-1-kuba@kadziolka.net> <20200305192204.14973-1-kuba@kadziolka.net> <877dzua9dn.fsf@gnu.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="ylai7nkiajsl7ghq" Content-Disposition: inline In-Reply-To: <877dzua9dn.fsf@gnu.org> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: 39932-done@debbugs.gnu.org --ylai7nkiajsl7ghq Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Mar 08, 2020 at 09:18:12PM +0100, Ludovic Court=C3=A8s wrote: > Hello, >=20 > Jakub K=C4=85dzio=C5=82ka skribis: >=20 > > * gnu/packages/python-xyz.scm (python-distlib): New variable. >=20 > [...] >=20 > > + (modify-phases %standard-phases > > + (add-before 'build 'no-/bin/sh > > + (lambda _ > > + (substitute* '("distlib/scripts.py" "tests/test_scripts.p= y") > > + (("/bin/sh") (which "sh"))))) > > + (add-before 'check 'prepare-test-env > > + (lambda _ > > + (setenv "HOME" "/tmp") > > + ;; NOTE: Any value works, the variable just has to be pre= sent. > > + (setenv "SKIP_ONLINE" "1")))))) >=20 > Please return #t from both phases, as is conventional. Argh, I'm always forgetting about that. It would be nice to have a lint for this... > Apart from that, all 3 patches LGTM! Thanks! I pushed the commits, the last one got a hash of 94d57ba3399aeb1b34d52e5e866c609f5a18ec2b --ylai7nkiajsl7ghq Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEE5Xa/ss9usT31cTO54xWnWEYTFWQFAl5lflEACgkQ4xWnWEYT FWQ2ABAA4R3nsog27JMOB2kHBjAoaepafrd+OUziuUa/Ts3aMavfIMiP/NF9wLKN Q8pX7iKR80dzbUolMwElM7BoWb8t9/Migw3AiAlU7HiljTVnOPA2tqGKI/ZlKeta 028jMjEHVaU42coKFJlluNcAF2AtY6IS9N42fhY9zzzvK3PE9qPRlT3DTQsPJzsO E/tOTOpcQwOBXWHoG7Sr6aZMtxIx291xmNOGD6Tkq3mpaabyugVRXAcDHVal0Fn8 cC3HleJ5R2C9WACkgNZdY6Iy6Hlf/wadbdeDSUOvfwWsJeF7rAtLCOVuys4oSKzj 094qUZGO02jLgrNI7vtsDuLGBr2cEzkeBVmSZrGg2XOjjAAdWCeLKMbl9iwoCZPe hgxEzPMYaBKd+aUmYoHK/TUqONGuP4HPLZZDrvyHlxgO7H/UxgFWwX9YOdOaV5Ok 7Nxyd+J/qekjdQVyzk6l75RRPn1aebIkZIQpkAUloNTWqsdii5IGb8Ki5BbrNP7U H61i6YukSw3EoTy789/s2S+6R59VzzhgB8IOeEUzZKZ238OJcF3JqQDutVx/u1Vt gwkkgr7VVbTt/n4qbrPhnPWAs6j/owZMQR6MUhKQmakGVH50r0OdOrSQXOFfsOtT IZp8yPbQ8jFv65RC6X7YNoV34/5sNZrNuh7ou3mYbGua/DrjtlU= =b122 -----END PGP SIGNATURE----- --ylai7nkiajsl7ghq--