From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:470:142:3::10]:44018) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j6YSV-0001Yw-GB for guix-patches@gnu.org; Tue, 25 Feb 2020 06:33:04 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1j6YSU-0008Jf-FM for guix-patches@gnu.org; Tue, 25 Feb 2020 06:33:03 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:48515) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1j6YSU-0008J3-C8 for guix-patches@gnu.org; Tue, 25 Feb 2020 06:33:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1j6YSU-0004lM-82 for guix-patches@gnu.org; Tue, 25 Feb 2020 06:33:02 -0500 Subject: [bug#37868] [PATCH v4] system: Add kernel-module-packages to operating-system. Resent-Message-ID: Date: Tue, 25 Feb 2020 12:32:45 +0100 From: Danny Milosavljevic Message-ID: <20200225123245.724af21e@scratchpost.org> In-Reply-To: <20200225105549.30115-1-dannym@scratchpost.org> References: <20200218094207.6196-1-dannym@scratchpost.org> <20200225105549.30115-1-dannym@scratchpost.org> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="Sig_/PeJicKFwxtHj+vv+0QZHySj"; protocol="application/pgp-signature"; micalg=pgp-sha256 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: 37868@debbugs.gnu.org, ludo@gnu.org, Mark H Weaver --Sig_/PeJicKFwxtHj+vv+0QZHySj Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable Some extra comments: * I have to really really prevent myself from just making the field KERNEL a list. Because that's what happens at runtime anyway. It's just an union of those things, then it runs depmod. The separation into KERNEL and KERNEL-LOADABLE-MODULES is artificial. * There's a collision warning: warning: collision encountered: /gnu/store/3ar8aym8khxh1rdjf5gxqsk0hv7r9p96-linux-module-database/lib/mod= ules/5.4.22-gnu/modules.symbols.bin /gnu/store/4r0fz0f37bp1zqbqclgrq1l4sm1acy4p-linux-libre-5.4.22/lib/module= s/5.4.22-gnu/modules.symbols.bin warning: choosing /gnu/store/3ar8aym8khxh1rdjf5gxqsk0hv7r9p96-linux-module-= database/lib/modules/5.4.22-gnu/modules.symbols.bin I think that's because the Linux kernel linux-libre we build already has th= ose files. Those files in linux-libre are stale cache files when you have extra modules (because they don't list those extra modules). @Ludo: You said I should remove the null? case (check if there are no extra= modules). I did, so actually, these modules.*.bin files in linux-libre are useless si= nce the profile-derivation of linux-module-database will rebuild them anyway (v= ia depmod), also in the case with no extra modules. The reason I had the null? case before is in order to leave the case with no extra modules unchanged from before (defensive programming). But now that we don't do that, should we make linux-libre not invoke depmod? Or should we filter those files out manually in the profile hook? --Sig_/PeJicKFwxtHj+vv+0QZHySj Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEds7GsXJ0tGXALbPZ5xo1VCwwuqUFAl5VBd0ACgkQ5xo1VCww uqVUAwf+NPUCOu7M5UWsbWlGYLoVojKbCORqfO5MP5qUF4JOf2Jyap5YorcbMlV4 KlW9W7qn9K6LB4sXtrWSB/t82kr0LtzRHBElwymeZNopEICPqH86gBFFbAgptPcB 7qZUzaWFVocWM8YaI+uM8Qhta/f3YrJVzWTl14ZExbLNpRBcNGlU4k5sys+ypXki 0p03Je0oUk7LBudvYnhG6h8mCDZScaXEYXGy494NRKN4iWs+qfRbxEjnvuavvJ/3 Vz50+fsRJsWpOTnQ31HOr0ktiMYJM+rfvxzltJJS5894QVvjq39HwJlW/QYZ/Lwq jQaOd0KWgSs3q6oJnyLlBP8detcB4Q== =YwKJ -----END PGP SIGNATURE----- --Sig_/PeJicKFwxtHj+vv+0QZHySj--