From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:470:142:3::10]:43556) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j4sit-0003Y3-4x for guix-patches@gnu.org; Thu, 20 Feb 2020 15:47:04 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1j4sis-0003M6-5h for guix-patches@gnu.org; Thu, 20 Feb 2020 15:47:03 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:39981) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1j4sis-0003M1-2s for guix-patches@gnu.org; Thu, 20 Feb 2020 15:47:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1j4sis-0004So-1Z for guix-patches@gnu.org; Thu, 20 Feb 2020 15:47:02 -0500 Subject: [bug#39647] [PATCH] gnu: Add unoconv. Resent-Message-ID: Received: from eggs.gnu.org ([2001:470:142:3::10]:43540) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j4sin-0003XP-Cz for guix-patches@gnu.org; Thu, 20 Feb 2020 15:46:58 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1j4sim-0003Js-D1 for guix-patches@gnu.org; Thu, 20 Feb 2020 15:46:57 -0500 Received: from pat.zlotemysli.pl ([37.59.186.212]:35828) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1j4sim-0003I3-4F for guix-patches@gnu.org; Thu, 20 Feb 2020 15:46:56 -0500 Date: Thu, 20 Feb 2020 21:47:28 +0100 From: Jakub =?UTF-8?Q?K=C4=85dzio=C5=82ka?= Message-ID: <20200220204728.gzzf7ja4ljmcbkbw@gravity> References: <20200217182509.11993-1-me@tobias.gr> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="xyzpkdglqet2vs2p" Content-Disposition: inline In-Reply-To: <20200217182509.11993-1-me@tobias.gr> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Tobias Geerinckx-Rice Cc: 39647@debbugs.gnu.org --xyzpkdglqet2vs2p Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Hi, I tried to use the package in a `guix environment' and got: ~/guix% unoconv ~/Downloads/scheme-macro-phd.ps -o scheme-macro-phd.pdf unoconv: format [jw4yj39s84jb4fkvqpsqwq-unoconv-0.9.0/bin/.unoconv-real] is not known to unoconv. I feel like this might be an issue with the packaging. Does it work for you? On Mon, Feb 17, 2020 at 07:25:09PM +0100, Tobias Geerinckx-Rice wrote: > + (modify-phases %standard-phases > + (add-after 'unpack 'patch-find_offices I think that the convention is to replace underscores by dashes in names like these. > + ;; find_offices is a convoluted cross-platform treasure hunt. > + ;; Keep things simple and return the correct paths immediately. > + (lambda* (#:key inputs #:allow-other-keys) > + (let* ((libreoffice (assoc-ref inputs "libreoffice"))) > + (substitute* "unoconv" > + (("def find_offices\\(\\):" match) > + (string-append > + match "\n" > + " ret = []\n" > + " office = Office(" > + "'" libreoffice "/lib/libreoffice', " > + "'" libreoffice "/lib/libreoffice/program', " > + "'" libreoffice "/lib/libreoffice/program', " > + "'" libreoffice "/lib/libreoffice/program/pyuno.so', " > + "'" libreoffice "/bin/soffice', " > + "sys.executable, " > + "None)\n" > + " ret.append(office)\n" > + " return ret\n"))) > + #t)))))) Wouldn't it be simpler to do return [Office(...)] ? --xyzpkdglqet2vs2p Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEE5Xa/ss9usT31cTO54xWnWEYTFWQFAl5O8F8ACgkQ4xWnWEYT FWTXdA//bO8ih8C6VSH5thBBkOWh8RPTev3oz38jrJHJykryZHeemjetdOQ7gNYb 4NFJSx9QCTzm04ypixztymx4tGdLr1EcU9JIkPHLrL5vEWCuNBYcaAyB0dm3lPqN cZGpfYPRtMyR8wlZnnAXJKAAMgr6osKmfCCHlTsQum5VfKx0WguclBNLElCis6tW Pfg1NBIKBx1LiG3VJDvi9FoycwinBFGBSgPwHSXHQwu6yZTAkT9QDYFuQk6kZq+v TLIYP84BRmWPiAyfmS66OA8MRVMtF/Pf8prd12w5HAT6Oo9Aj4wv5qfbDHbFymsz XQTnM9RmLdwUHTAjV3J3AaCQk9ocm78P0zvro2jethf13BZ0TM9rzvIW6rmOo1Ey aTGTEVqrOhDwrIHo+TivDuB8P1gclraPEHfcZbqz1IHxqKlORdaoiOAWpyWoWxrr Q0CGAr3Ddbvz5ibxdcRdXxz6E21mj5zEPIK9pJTDe8KpsPuznmxHjiQYo/Zh/Hs4 HhnA58u73hPOtQKcmLSQBrAaPcSuV6XBukbXlmIUSDD82aez0S93b4ufsqOyDtEf 7buUPcvFxjjJmT9K1wWw7JrWMm9s6nPkhFux/wNVm3+ZtelUFLJLdcYcxLkblMKG +HyPsEszCfbzUK4I8mYNOw/p7yKrwFOg2mfnfPfNo/UW7APl4Us= =bXnK -----END PGP SIGNATURE----- --xyzpkdglqet2vs2p--