From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bengt Richter Subject: Re: 01/02: build: gnu-build-system: Don't run configure during bootstrap. Date: Sun, 16 Feb 2020 17:24:22 +0100 Message-ID: <20200216162422.GA5829@LionPure> References: <20200216072616.4957.58376@vcs0.savannah.gnu.org> <20200216072618.88AB021120@vcs0.savannah.gnu.org> <877e0m7gkn.fsf@devup.no> <20200216145517.GE1968@E5400> Reply-To: Bengt Richter Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:470:142:3::10]:44409) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j3MjL-0000Hd-Pr for guix-devel@gnu.org; Sun, 16 Feb 2020 11:25:20 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1j3MjH-0003D4-2I for guix-devel@gnu.org; Sun, 16 Feb 2020 11:25:15 -0500 Received: from imta-36.everyone.net ([216.200.145.36]:53734 helo=imta-38.everyone.net) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1j3MjG-0003CQ-Q0 for guix-devel@gnu.org; Sun, 16 Feb 2020 11:25:11 -0500 Content-Disposition: inline In-Reply-To: <20200216145517.GE1968@E5400> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane-mx.org@gnu.org Sender: "Guix-devel" To: Efraim Flashner Cc: guix-devel@gnu.org Hi Efraim, On +2020-02-16 16:55:17 +0200, Efraim Flashner wrote: > On Sun, Feb 16, 2020 at 03:27:36PM +0100, Marius Bakke wrote: > > guix-commits@gnu.org writes: > >=20 > > > commit 481a0f1a7ceac666a011b28324220584ead07698 > > > Author: Efraim Flashner > > > AuthorDate: Thu Feb 13 10:54:29 2020 +0200 > > > > > > build: gnu-build-system: Don't run configure during bootstrap. > > > =20 > > > * guix/build/gnu-build-system.scm (bootstrap): Add NOCONFIGURE > > > environment variable before running bootstrap scripts. > >=20 > > [...] > >=20 > > > @@ -190,6 +190,7 @@ working directory." > > > (if (executable-file? script) > > > (begin > > > (patch-shebang script) > > > + (setenv "NOCONFIGURE" "true") > > > (invoke script)) > > > (invoke "sh" script))) > > > (if (or (file-exists? "configure.ac") > >=20 > > Should we unset NOCONFIGURE afterwards? Probably at least one packag= e > > uses this variable for something completely different... >=20 > It probably wouldn't hurt to unset it. I've never come across a package > where that's been a problem but best not invite trouble. > With all due respect, I am not comfortable with this kind of rationale :)= =20 If it's never been a problem, unsetting might hide a case where it _would= _ cause a problem -- which IMO it would be better to find out about than no= t. Is there an official policy regarding garbage/dangling environment variab= les? (Or is that just to be expected in the sargasso sea of "undefined behavio= ur"? ;-) So, if in doubt, instead of unsetting, perhaps set it something like "IF_YOU_SEE_THIS_PLEASE_REPORT_HOW_IT_HAPPENED_TO_efraim_AT_flashner.= co.il" ;-P or make it throw an exception somehow, if following processing uses NOCON= FIGURE any way at all before being replaced with a proper meaningful new value. > Also, looking at the snippet, I should move it higher up. If it's not > executable then NOCONFIGURE doesn't get set. >=20 >=20 > --=20 > Efraim Flashner =D7=90=D7=A4=D7=A8=D7=99=D7= =9D =D7=A4=D7=9C=D7=A9=D7=A0=D7=A8 > GPG key =3D A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351 > Confidentiality cannot be guaranteed on emails sent or received unencry= pted Hope I didn't offend anyone :) --=20 Regards, Bengt Richter