all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Thomas Danckaert <post@thomasdanckaert.be>
To: 39576@debbugs.gnu.org
Subject: [bug#39576] qdbm: fix segfault during test
Date: Wed, 12 Feb 2020 16:14:57 +0100 (CET)	[thread overview]
Message-ID: <20200212.161457.1945473684782544947.post@thomasdanckaert.be> (raw)

[-- Attachment #1: Type: Text/Plain, Size: 333 bytes --]

Hi Guix,

at some point, the package qdbm started running into a segfault 
during the test suite.   This small patch fixes that.

If it's ok, I can push the commit myself (I believe I still have 
commit rights), but since I haven't contributed in 2 years, I wanted 
to check if the patch meets all the requirements...

best,

Thomas

[-- Attachment #2: 0001-gnu-qdbm-Fix-segfault-during-tests.patch --]
[-- Type: Text/X-Patch, Size: 1954 bytes --]

From bd557d5f63197712bbe5cde8f4a80e152b7ec586 Mon Sep 17 00:00:00 2001
From: Thomas Danckaert <thomas.danckaert@gmail.com>
Date: Wed, 12 Feb 2020 15:31:49 +0100
Subject: [PATCH] gnu: qdbm: Fix segfault during tests.

gnu/packages/databses.scm (qdbm): Add "CFLAGS=-fPIC" to make-flags.
---
 gnu/packages/databases.scm | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)

diff --git a/gnu/packages/databases.scm b/gnu/packages/databases.scm
index 587d993918..1cec7743b2 100644
--- a/gnu/packages/databases.scm
+++ b/gnu/packages/databases.scm
@@ -19,7 +19,7 @@
 ;;; Copyright © 2016 Danny Milosavljevic <dannym+a@scratchpost.org>
 ;;; Copyright © 2016, 2017, 2018, 2019 Marius Bakke <mbakke@fastmail.com>
 ;;; Copyright © 2017, 2018 Julien Lepiller <julien@lepiller.eu>
-;;; Copyright © 2017 Thomas Danckaert <post@thomasdanckaert.be>
+;;; Copyright © 2017, 2020 Thomas Danckaert <post@thomasdanckaert.be>
 ;;; Copyright © 2017 Jelle Licht <jlicht@fsfe.org>
 ;;; Copyright © 2017 Adriano Peluso <catonano@gmail.com>
 ;;; Copyright © 2017 Arun Isaac <arunisaac@systemreboot.net>
@@ -1060,9 +1060,10 @@ Most public APIs are compatible with @command{mysqlclient} and MySQLdb.")
          "0gmpvhn02pkq280ffmn4da1g4mdr1xxz7l80b7y4n7km1mrzwrml"))))
     (build-system gnu-build-system)
     (arguments
-     `( #:configure-flags (list (string-append "LDFLAGS=-Wl,-rpath="
-                                               (assoc-ref %outputs "out")
-                                               "/lib"))))
+     `(#:configure-flags (list (string-append "LDFLAGS=-Wl,-rpath="
+                                              (assoc-ref %outputs "out")
+                                              "/lib"))
+       #:make-flags '("CFLAGS=-fPIC")))
     (home-page "http://fallabs.com/qdbm")
     (synopsis "Key-value database")
     (description "QDBM is a library of routines for managing a
-- 
2.25.0


             reply	other threads:[~2020-02-12 15:16 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-12 15:14 Thomas Danckaert [this message]
2020-02-12 17:52 ` [bug#39576] qdbm: fix segfault during test Tobias Geerinckx-Rice via Guix-patches via
2020-02-22 16:49 ` bug#39576: qdbm Thomas Danckaert

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200212.161457.1945473684782544947.post@thomasdanckaert.be \
    --to=post@thomasdanckaert.be \
    --cc=39576@debbugs.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.