bug#39449: sane-backends unit test failure on x86_64-linux

bug#39449: sane-backends unit test failure on x86_64-linux

[Danny Milosavljevic]

[-- Attachment #1: Type: text/plain, Size: 5010 bytes --]

FAIL: genesys_unit_tests
============================================================================
Testsuite summary for sane-backends 1.0.29
============================================================================
# TOTAL: 1
# PASS:  0
# SKIP:  0
# XFAIL: 0
# FAIL:  1
# XPASS: 0
# ERROR: 0
============================================================================
See testsuite/backend/genesys/test-suite.log
Please report to sane-devel@alioth-lists.debian.net
============================================================================
make[5]: *** [Makefile:826: test-suite.log] Error 1
make[5]: Leaving directory '/tmp/guix-build-sane-backends-1.0.29.drv-0/sane-backends-1.0.29/testsuite/backend/genesys'
make[4]: *** [Makefile:934: check-TESTS] Error 2
make[4]: Leaving directory '/tmp/guix-build-sane-backends-1.0.29.drv-0/sane-backends-1.0.29/testsuite/backend/genesys'
make[3]: *** [Makefile:1008: check-am] Error 2
make[3]: Leaving directory '/tmp/guix-build-sane-backends-1.0.29.drv-0/sane-backends-1.0.29/testsuite/backend/genesys'
make[2]: *** [Makefile:444: check-recursive] Error 1
make[2]: Leaving directory '/tmp/guix-build-sane-backends-1.0.29.drv-0/sane-backends-1.0.29/testsuite/backend'
make[1]: *** [Makefile:451: check-recursive] Error 1
make[1]: Leaving directory '/tmp/guix-build-sane-backends-1.0.29.drv-0/sane-backends-1.0.29/testsuite'
make: *** [Makefile:597: check-recursive] Error 1

Test suite failed, dumping logs.

--- ./testsuite/backend/genesys/test-suite.log ------------------------------

====================================================================
   sane-backends 1.0.29: testsuite/backend/genesys/test-suite.log
====================================================================

# TOTAL: 1
# PASS:  0
# SKIP:  0
# XFAIL: 0
# FAIL:  1
# XPASS: 0
# ERROR: 0

.. contents:: :depth: 2

FAIL: genesys_unit_tests
========================

SUCCESS at tests_calibration.cpp:123 in test_calibration_roundtrip
SUCCESS at tests_calibration.cpp:127 in test_calibration_roundtrip
SUCCESS at tests_image.cpp:42 in test_get_pixel_from_row
SUCCESS at tests_image.cpp:44 in test_get_pixel_from_row
SUCCESS at tests_image.cpp:46 in test_get_pixel_from_row
SUCCESS at tests_image.cpp:48 in test_get_pixel_from_row
SUCCESS at tests_image.cpp:50 in test_get_pixel_from_row
SUCCESS at tests_image.cpp:52 in test_get_pixel_from_row
SUCCESS at tests_image.cpp:54 in test_get_pixel_from_row
SUCCESS at tests_image.cpp:56 in test_get_pixel_from_row
SUCCESS at tests_image.cpp:58 in test_get_pixel_from_row
SUCCESS at tests_image.cpp:60 in test_get_pixel_from_row
SUCCESS at tests_image.cpp:62 in test_get_pixel_from_row
SUCCESS at tests_image.cpp:64 in test_get_pixel_from_row
SUCCESS at tests_image.cpp:66 in test_get_pixel_from_row
SUCCESS at tests_image.cpp:68 in test_get_pixel_from_row
SUCCESS at tests_image.cpp:70 in test_get_pixel_from_row
SUCCESS at tests_image.cpp:72 in test_get_pixel_from_row
SUCCESS at tests_image.cpp:74 in test_get_pixel_from_row
SUCCESS at tests_image.cpp:76 in test_get_pixel_from_row
SUCCESS at tests_image.cpp:92 in test_set_pixel_to_row
SUCCESS at tests_image.cpp:98 in test_set_pixel_to_row
SUCCESS at tests_image.cpp:104 in test_set_pixel_to_row
SUCCESS at tests_image.cpp:110 in test_set_pixel_to_row
SUCCESS at tests_image.cpp:116 in test_set_pixel_to_row
SUCCESS at tests_image.cpp:122 in test_set_pixel_to_row
FAILURE at tests_image.cpp:128 in test_set_pixel_to_row :
std::vector<T>{     17
    0
    0
    0
    0
    0
    0
    0
    0
    0
    0
    0
}
 != std::vector<T>{     18
    0
    0
    0
    0
    0
    0
    0
    0
    0
    0
    0
}


FAILURE at tests_image.cpp:134 in test_set_pixel_to_row :
std::vector<T>{     0
    0
    17
    0
    0
    0
    0
    0
    0
    0
    0
    0
}
 != std::vector<T>{     0
    0
    18
    0
    0
    0
    0
    0
    0
    0
    0
    0
}


SUCCESS at tests_image.cpp:140 in test_set_pixel_to_row
SUCCESS at tests_image.cpp:146 in test_set_pixel_to_row
SUCCESS at tests_image.cpp:152 in test_set_pixel_to_row
SUCCESS at tests_image.cpp:158 in test_set_pixel_to_row
FAILURE at tests_image.cpp:164 in test_set_pixel_to_row :
std::vector<T>{     51
    18
    0
    0
    0
    0
    0
    0
    0
    0
    0
    0
}
 != std::vector<T>{     52
    18
    0
    0
    0
    0
    0
    0
    0
    0
    0
    0
}

FAILURE at tests_image.cpp:170 in test_set_pixel_to_row :
std::vector<T>{     0
    0
    51
    18
    0
    0
    0
    0
    0
    0
    0
}
 != std::vector<T>{     0
    0
    52
    18
    0
    0
    0
    0
    0
    0
    0
    0
}


$ guix describe
Generation 49   Feb 04 2020 10:55:17    (current)
  guix a42f142
    repository URL: https://git.savannah.gnu.org/git/guix.git
    branch: master
    commit: a42f14204a916e27fdcf87773ecd3779d2e5c9e9

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

bug#39449: [PATCH] gnu: sane-backends: Disable genesys_unit_tests.

[Leo Prikler]

* gnu/packages/scanner.scm (sane-backends)[arguments]<#:phases>:
Add disable-failing-backend-tests.
---
 gnu/packages/scanner.scm | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/gnu/packages/scanner.scm b/gnu/packages/scanner.scm
index 6adaba18cd..3f922a4747 100644
--- a/gnu/packages/scanner.scm
+++ b/gnu/packages/scanner.scm
@@ -131,6 +131,10 @@ package contains the library, but no drivers.")
        ((#:phases phases)
         `(modify-phases ,phases
            (delete 'disable-backends)
+           (add-after 'disable-failing-tests 'disable-failing-backend-tests
+             (lambda _
+               (substitute* "testsuite/backend/genesys/Makefile.in"
+                  ((" genesys_unit_tests\\$\\(EXEEXT\\)") ""))))
            (add-after 'unpack 'add-backends
              (lambda _
                (substitute* "backend/dll.conf.in"
-- 
2.25.0

bug#39449: sane-backends unit test failure on x86_64-linux

[Danny Milosavljevic]

[-- Attachment #1: Type: text/plain, Size: 62 bytes --]

See also https://gitlab.com/sane-project/backends/issues/241

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

bug#39449: [bug#39476] [PATCH] gnu: sane-backends: Disable genesys_unit_tests.

[Ludovic Courtès]

Hi,

Leo Prikler <leo.prikler@student.tugraz.at> skribis:

> * gnu/packages/scanner.scm (sane-backends)[arguments]<#:phases>:
> Add disable-failing-backend-tests.
> ---
>  gnu/packages/scanner.scm | 4 ++++
>  1 file changed, 4 insertions(+)
>
> diff --git a/gnu/packages/scanner.scm b/gnu/packages/scanner.scm
> index 6adaba18cd..3f922a4747 100644
> --- a/gnu/packages/scanner.scm
> +++ b/gnu/packages/scanner.scm
> @@ -131,6 +131,10 @@ package contains the library, but no drivers.")
>         ((#:phases phases)
>          `(modify-phases ,phases
>             (delete 'disable-backends)
> +           (add-after 'disable-failing-tests 'disable-failing-backend-tests
> +             (lambda _
> +               (substitute* "testsuite/backend/genesys/Makefile.in"
> +                  ((" genesys_unit_tests\\$\\(EXEEXT\\)") ""))))

Applied with two things: returning #t, and adding a comment linking to
the bug report.

Danny: this is actually on i686, not on x86_64.  See the build logs:

--8<---------------cut here---------------start------------->8---
$ guix build sane-backends -s i686-linux --log-file --no-grafts
https://ci.guix.gnu.org/log/w150bi6vvqqll31qqy99vm1iwwj4hgm9-sane-backends-1.0.29
$ guix build sane-backends -s x86_64-linux --log-file --no-grafts
https://ci.guix.gnu.org/log/m8mdg866lkzw6jnbgdz8b4spk61mx2y6-sane-backends-1.0.29
$ guix describe
Generacio 128   Feb 10 2020 22:29:47    (nuna)
  guix 8a0dd28
    repository URL: https://git.savannah.gnu.org/git/guix.git
    branch: master
    commit: 8a0dd289c5b201ebfdd5465d412230bb81110e4c
--8<---------------cut here---------------end--------------->8---

Thanks,
Ludo’.

[bug#39476] [PATCH] gnu: sane-backends: Disable genesys_unit_tests.

[Ludovic Courtès]

Hi,

Leo Prikler <leo.prikler@student.tugraz.at> skribis:

> * gnu/packages/scanner.scm (sane-backends)[arguments]<#:phases>:
> Add disable-failing-backend-tests.
> ---
>  gnu/packages/scanner.scm | 4 ++++
>  1 file changed, 4 insertions(+)
>
> diff --git a/gnu/packages/scanner.scm b/gnu/packages/scanner.scm
> index 6adaba18cd..3f922a4747 100644
> --- a/gnu/packages/scanner.scm
> +++ b/gnu/packages/scanner.scm
> @@ -131,6 +131,10 @@ package contains the library, but no drivers.")
>         ((#:phases phases)
>          `(modify-phases ,phases
>             (delete 'disable-backends)
> +           (add-after 'disable-failing-tests 'disable-failing-backend-tests
> +             (lambda _
> +               (substitute* "testsuite/backend/genesys/Makefile.in"
> +                  ((" genesys_unit_tests\\$\\(EXEEXT\\)") ""))))

Applied with two things: returning #t, and adding a comment linking to
the bug report.

Danny: this is actually on i686, not on x86_64.  See the build logs:

--8<---------------cut here---------------start------------->8---
$ guix build sane-backends -s i686-linux --log-file --no-grafts
https://ci.guix.gnu.org/log/w150bi6vvqqll31qqy99vm1iwwj4hgm9-sane-backends-1.0.29
$ guix build sane-backends -s x86_64-linux --log-file --no-grafts
https://ci.guix.gnu.org/log/m8mdg866lkzw6jnbgdz8b4spk61mx2y6-sane-backends-1.0.29
$ guix describe
Generacio 128   Feb 10 2020 22:29:47    (nuna)
  guix 8a0dd28
    repository URL: https://git.savannah.gnu.org/git/guix.git
    branch: master
    commit: 8a0dd289c5b201ebfdd5465d412230bb81110e4c
--8<---------------cut here---------------end--------------->8---

Thanks,
Ludo’.

bug#39449: sane-backends unit test failure on x86_64-linux

[Maxim Cournoyer]

Hi,

Ludovic Courtès <ludo@gnu.org> writes:

> Hi,
>
> Leo Prikler <leo.prikler@student.tugraz.at> skribis:
>
>> * gnu/packages/scanner.scm (sane-backends)[arguments]<#:phases>:
>> Add disable-failing-backend-tests.
>> ---
>>  gnu/packages/scanner.scm | 4 ++++
>>  1 file changed, 4 insertions(+)
>>
>> diff --git a/gnu/packages/scanner.scm b/gnu/packages/scanner.scm
>> index 6adaba18cd..3f922a4747 100644
>> --- a/gnu/packages/scanner.scm
>> +++ b/gnu/packages/scanner.scm
>> @@ -131,6 +131,10 @@ package contains the library, but no drivers.")
>>         ((#:phases phases)
>>          `(modify-phases ,phases
>>             (delete 'disable-backends)
>> +           (add-after 'disable-failing-tests 'disable-failing-backend-tests
>> +             (lambda _
>> +               (substitute* "testsuite/backend/genesys/Makefile.in"
>> +                  ((" genesys_unit_tests\\$\\(EXEEXT\\)") ""))))
>
> Applied with two things: returning #t, and adding a comment linking to
> the bug report.

Great, closing then.

Thanks!

Maxim