From mboxrd@z Thu Jan  1 00:00:00 1970
From: Tanguy Le Carrour <tanguy@bioneland.org>
Subject: Re: WIP gnu: poetry: Update to 1.0.3.
Date: Tue, 4 Feb 2020 09:48:57 +0100
Message-ID: <20200204084857.uxmbpch6rnyqevwe@rafflesia>
References: <20200203153122.llccmfho2fwtr7o7@rafflesia>
 <CAE4v=pjxnY5SK0D7jKL9v4vPKx=EUzLkWkhqE2dL4ywa-b8qeg@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane-mx.org@gnu.org>
Received: from eggs.gnu.org ([2001:470:142:3::10]:33579)
 by lists.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <tanguy@bioneland.org>) id 1iyttG-0005XA-Nl
 for guix-devel@gnu.org; Tue, 04 Feb 2020 03:49:03 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
 (envelope-from <tanguy@bioneland.org>) id 1iyttF-0004ZR-K2
 for guix-devel@gnu.org; Tue, 04 Feb 2020 03:49:02 -0500
Received: from relay7-d.mail.gandi.net ([217.70.183.200]:48987)
 by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)
 (Exim 4.71) (envelope-from <tanguy@bioneland.org>)
 id 1iyttF-0004Vl-DW
 for guix-devel@gnu.org; Tue, 04 Feb 2020 03:49:01 -0500
Content-Disposition: inline
In-Reply-To: <CAE4v=pjxnY5SK0D7jKL9v4vPKx=EUzLkWkhqE2dL4ywa-b8qeg@mail.gmail.com>
List-Id: "Development of GNU Guix and the GNU System distribution."
 <guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
 <mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
 <mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane-mx.org@gnu.org
Sender: "Guix-devel"
 <guix-devel-bounces+gcggd-guix-devel=m.gmane-mx.org@gnu.org>
To: =?utf-8?B?R8OhYm9y?= Boskovits <boskovits@gmail.com>
Cc: Guix <guix-devel@gnu.org>

Hi Gábor!


Le 02/03, Gábor Boskovits a écrit :
> Tanguy Le Carrour <tanguy@bioneland.org> ezt írta (időpont: 2020.
> febr. 3., H, 16:31):
> > I'm working on updating Poetry to version 1.0.3 and I have a problem
> > with the version of a dependency.
> >
> > Poetry now depends on python-keyring >=20.0.0,<21.0.0. In Guix we
> > have python-keyring     21.0.0, so it does not work once installed!
> >
> > What am I supposed to do?
> >
> > I see 3 different ways out of this:
> > - patch the package to make it use our version (I tried but failed [1]);
> > - ask upstream to update dependencies;
> > - declare a new package python-keyring-20.0.0 and use it as an input.
> 
> Asking upstream to update would be great.

As describe here [1][], it might be a little bit "thornier" than that,
as keyring v21.0.0 depends on Python 3.6! :-(

[1]: https://github.com/python-poetry/poetry/issues/1832

So I guess I'll try to patch the code…


> > [1]: attempt to patch setup.py
> > -    (arguments `(#:tests? #f))                    ; tests depend on dbus service
> > +    (arguments
> > +     `(#:tests? #f ;; Pypi does not have tests.
> > +       #:phases
> > +       (modify-phases %standard-phases
> > +         (add-after 'unpack 'change-dependencies
> > +           (lambda _
> > +             ;; Guix has version 21.0.0 of python-keyring
> > +             (invoke "sed" "-i" "-e"
> > +                     "s/keyring>=20.0.1,<21.0.0/keyring>=20.0.1,<22.0.0/"
> > +                     "setup.py")
> > +             #t)))))
> >
> 
> What did not work in this case?

The `setup.py` file was not modified!


> Also, do you think that you could replace invoke sed with substitute*?

I'll definitively give it a try! Thanks!


Regards

-- 
Tanguy