From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:470:142:3::10]:52900) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iyKIp-00037h-Ck for guix-patches@gnu.org; Sun, 02 Feb 2020 13:49:04 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iyKIo-00022e-C8 for guix-patches@gnu.org; Sun, 02 Feb 2020 13:49:03 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:34567) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iyKIo-00022Y-8E for guix-patches@gnu.org; Sun, 02 Feb 2020 13:49:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iyKIo-0005ZN-4U for guix-patches@gnu.org; Sun, 02 Feb 2020 13:49:02 -0500 Subject: [bug#39384] [PATCH] gnu: Add emacs-rg. Resent-Message-ID: Date: Sun, 2 Feb 2020 20:47:57 +0200 From: Efraim Flashner Message-ID: <20200202184757.GH9517@E5400> References: <87v9oqrr0q.fsf@lafreniere.xyz> <878slmc640.fsf@nicolasgoaziou.fr> <87pnexrrwf.fsf@lafreniere.xyz> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="2nTeH+t2PBomgucg" Content-Disposition: inline In-Reply-To: <87pnexrrwf.fsf@lafreniere.xyz> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: "LaFreniere, Joseph" Cc: 39384@debbugs.gnu.org, Nicolas Goaziou --2nTeH+t2PBomgucg Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Feb 02, 2020 at 08:21:52AM -0600, LaFreniere, Joseph wrote: > Thank you for the fast feedback! >=20 > Nicolas Goaziou writes: > > Nitpick: I think the trend is to align `base32' with the string. >=20 > > You may want to lint your package. In particular, the synopsis should be > > akin to "Search tool based ..." >=20 > > The description must start with a full sentence, e.g., "rg.el" is an > > Emacs search package... >=20 > > Texinfo requires two spaces after the full stop. >=20 > > Ditto. Besides, the quote after "users" looks suspicious. You should use > > a regular quote. >=20 > A patch file is attached that addresses all of the above feedback. The > output of `guix lint emacs-rg` is now clean on my system; thank you for > making me aware of that utility. >=20 > The only part of the package I'm uncertain about is declaring ripgrep as a > propagated dependency. ripgrep is not needed for this Emacs package to be > able to byte-compile successfully, but `rg` does not need to be on PATH f= or > the package to be useful at all. So while I imagine the majority of the > uses-cases would want to have ripgrep installed locally, it's definitely > plausible that one could only ever want to use emacs-rg via TRAMP in which > case pulling in ripgrep would be completely unnecessary. >=20 > Please let me know what you think. Is it possible to patch the invocations of `rg` to refer to ripgrep directly? --=20 Efraim Flashner =D7=90=D7=A4=D7=A8=D7=99=D7=9D = =D7=A4=D7=9C=D7=A9=D7=A0=D7=A8 GPG key =3D A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351 Confidentiality cannot be guaranteed on emails sent or received unencrypted --2nTeH+t2PBomgucg Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEoov0DD5VE3JmLRT3Qarn3Mo9g1EFAl43GV0ACgkQQarn3Mo9 g1GUIQ/9EJOzbMqPqV51d9C2DV88GCxzBAeh2iH23f/QMWHdPvJAM24MUdWujbMQ xdRuPFh1+X31Iofs49Albc+979JXBfEhcsBxPkd0vDBxN6W620gZJJRcGxtnLkF4 ADMZkw9IjaWVBWHXYBVJrrFS7FGkT9BH7+5+LC3gzbJwji/R7aQEEenGdaC1VIsK GbyxoeQ3/gy2uf8/xYMWkr+jlhOET23DpSUmgKGbql/c0f1NDkKMRPqQ9H8iYsJU VMf2xi2yDg8CJfYe5aHZk9sanUBJDRfXDU6teB0x56k6Ix00cSJFUMVQodmaqbla LHtJPLzDfHlS+TQBctAmfOC45gsLz72+bP8EhNoHS753e+eCbasGZ3wPSArHIhHu Xg3v6px/4FuL+mo/A9LDzqJHkw/lrMUdj/y8Ed7A33YoqB/xacFFQlnAbdgLnA/r TPLcOmJGkJHMtcLIncQxzC3yVtsvUhpdZxUBipvq31aaFFKMGptetbN/1wlAfNlO wDfh62adJJA2TvbEiHpcLKhbr0RkpqC4dvxYGqHF2l6f57zpy3AGCTI9jmWyK8pn ufIaKODMRvtXjSyXb8G47apxlqmP0XE/slIEG/AwXHhJqU8J+PnaWnxGZOt1C1pn NnBxhXdnbXXXpxDCRXZlJcawpqbpXwOhBZ4jJzfW1cmdWjrPZGY= =rFw6 -----END PGP SIGNATURE----- --2nTeH+t2PBomgucg--