From: Efraim Flashner <efraim@flashner.co.il>
To: John Soo <jsoo1@asu.edu>
Cc: guix-devel@gnu.org
Subject: Re: (not) testing Rust packages?!
Date: Sat, 25 Jan 2020 20:55:46 +0200 [thread overview]
Message-ID: <20200125185546.GN1603@E5400> (raw)
In-Reply-To: <B1C912A2-9C37-41EC-9BAD-682FBB067765@asu.edu>
[-- Attachment #1: Type: text/plain, Size: 1521 bytes --]
On Sat, Jan 25, 2020 at 08:46:48AM -0800, John Soo wrote:
> Hi Hartmut and Martin,
>
> I think it makes sense to run tests now.
>
> > Part of the reason is that bringing tests for a given library can bring in a massive amount of dependencies.
>
> I think that we are getting close to having complete dependencies for most rust packages we have and most are declared in the package definition.
>
> Furthermore since most rust libraries we have are not executables, we could still skip the build and run the tests I think. Aren’t the two phases completely separate for cargo?
>
> Other downsides I see for not skipping the build are really increasing the store size. Would skipping builds but still running tests increase the store size at all?
>
> I like the idea of having tests, too. Plus I’d like to see the cargo build system come closer to the standard package definition.
>
In addition, since we don't actually need any of the results of the
crates, it does provide a quick way to notice if we've provided the
wrong version of a dependency. I also noticed that we're missing
rust-average-0.9 which is definitely needed for rust-rand-0.6 and I'm
sure others.
If we enable building and tests and are lenient with skipping tests,
that alone would be an improvement.
--
Efraim Flashner <efraim@flashner.co.il> אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2020-01-25 18:56 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-25 13:38 (not) testing Rust packages?! Hartmut Goebel
2020-01-25 14:31 ` Martin Becze
2020-01-25 16:46 ` John Soo
2020-01-25 17:45 ` Martin Becze
2020-01-25 22:56 ` Andreas Rottmann
2020-01-27 14:49 ` John Soo
2020-01-29 19:01 ` Andreas Rottmann
2020-01-31 18:50 ` John Soo
2020-02-03 12:22 ` Hartmut Goebel
2020-01-25 18:55 ` Efraim Flashner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200125185546.GN1603@E5400 \
--to=efraim@flashner.co.il \
--cc=guix-devel@gnu.org \
--cc=jsoo1@asu.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.