From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:470:142:3::10]:32932) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iuHAp-0003yo-CA for guix-patches@gnu.org; Wed, 22 Jan 2020 09:40:04 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iuHAo-0001ol-0E for guix-patches@gnu.org; Wed, 22 Jan 2020 09:40:03 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:43351) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iuHAn-0001oa-Sh for guix-patches@gnu.org; Wed, 22 Jan 2020 09:40:01 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iuHAn-0008PX-Op for guix-patches@gnu.org; Wed, 22 Jan 2020 09:40:01 -0500 Subject: [bug#39146] [PATCH] gnu: icecat: Remove about:buildconfig store references. Resent-Message-ID: Date: Wed, 22 Jan 2020 15:39:28 +0100 From: Jakub =?UTF-8?Q?K=C4=85dzio=C5=82ka?= Message-ID: <20200122143928.6cr5vc6vbspjqkrf@zdrowyportier.kadziolka.net> References: <20200122013406.3476-1-me@tobias.gr> <20200122135107.73z6upacjwial3zq@zdrowyportier.kadziolka.net> <87o8uvlgnn.fsf@nckx> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <87o8uvlgnn.fsf@nckx> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Tobias Geerinckx-Rice , 39146@debbugs.gnu.org On Wed, Jan 22, 2020 at 03:19:06PM +0100, Tobias Geerinckx-Rice wrote: > Jakub, > > Did you mean to send this off-list? Either's fine by me. Whoops, not at all. I need to configure mutt to default to reply-to-all... adding the list back into CC. > Jakub Kądziołka 写道： > > Firstly, note that /gnu/store/ is not guaranteed to be the store path, > > since this parameter can be changed by passing --with-store-dir to > > ./configure. > > Er, whoops, of course. I was going to replace that after testing. By the > time they'd finished I'd forgot. > > > I assume you tested this patch? When I tried to do my substitutions > > after the expansion is done, but before the files are packaged into > > a zip-like file, I couldn't find a good place to hook in the build. > > Indeed. The result is stored in lib/icecat/omni.ja, which is an > uncompressed (so GC works) zip file. > > > Also, there's already some code to help with removing references in > > guix/build/utils.scm (remove-store-references), but the result you get > > with what you're proposing seems much more user-friendly. > > Heh, thank you! That's intentional. :-) > > Remove-store-references' length-preservation is great in some cases > (compiled executables, binary data, weird code, …) but this wasn't a good > fit. > > Thanks for taking a look; I'll test & send a (%store-directory) fix. Thanks > for your enthousiastic contributions to Guix in general. A short while after switching to Guix, I read this on Reddit: | If you're looking to just use one of these distros without actively | contributing back, I'd go with NixOS right now. If you're an enthusiast | that wants to contribute to one of these two projects, GuixSD needs more | help to reach critical mass. ( -- https://www.reddit.com/r/NixOS/comments/9zwiee/nixos_vs_guixsd/eb6zqcu/) This, together with the fact that Guix is quite easy to hack on, has inspired me to contribute. > > Looks like you haven't updated your git in a while ;) > > Nope, just other people's. > > My Guix sqlite DB was corrupted beyond repair in December, I've been limping > along using ‘guix pack’s from my build farm ever since, because it was never > the ‘right time’ to reinstall… > > I blame Guix for making that even possible and relatively painless. > > Kind regards, > > T G-R >