From mboxrd@z Thu Jan 1 00:00:00 1970 From: Efraim Flashner Subject: Re: qt-build-system: Add QT_QPA_PLATFORM=offscreen? Date: Wed, 22 Jan 2020 11:24:15 +0200 Message-ID: <20200122092415.GK1603@E5400> References: <20200121212746.16054-1-h.goebel@crazy-compilers.com> <20200121212746.16054-7-h.goebel@crazy-compilers.com> <20200121234321.2e51854b@scratchpost.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="Xsn3knLL3qrmRbVI" Return-path: Received: from eggs.gnu.org ([2001:470:142:3::10]:51946) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iuCFl-00069s-66 for guix-devel@gnu.org; Wed, 22 Jan 2020 04:24:50 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iuCFj-0006dn-TO for guix-devel@gnu.org; Wed, 22 Jan 2020 04:24:49 -0500 Received: from flashner.co.il ([178.62.234.194]:34340) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1iuCFj-0006dS-MX for guix-devel@gnu.org; Wed, 22 Jan 2020 04:24:47 -0500 Content-Disposition: inline In-Reply-To: List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane-mx.org@gnu.org Sender: "Guix-devel" To: Hartmut Goebel Cc: guix-devel , 39229@debbugs.gnu.org --Xsn3knLL3qrmRbVI Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Jan 22, 2020 at 09:44:02AM +0100, Hartmut Goebel wrote: > Hi Danny, >=20 > (forwarding to guix-devel to eventually get more opinions on this) >=20 > Am 21.01.20 um 23:43 schrieb Danny Milosavljevic: > >> + (add-before 'check 'check-setup > >> + (lambda _ > >> + (setenv "QT_QPA_PLATFORM" "offscreen") > >> + #t))))) > > Hmm, would it make sense to do that automatically in qt-build-system ? >=20 I was about to suggest this. (ins)efraim@E5400 ~/workspace/guix$ grep QT_QPA_PLATFORM\" gnu/packages/kde= *scm | wc -l 41 (ins)efraim@E5400 ~/workspace/guix$ grep define-public gnu/packages/kde*scm= | wc -l 124 (ins)efraim@E5400 ~/workspace/guix$ grep qt-build-system gnu/packages/kde*s= cm | wc -l 27 > I would be fine with this, since I find myself adding this snippet quite > often when building Qt/KDE applications. But there *might* be cases, > where tests fail due to this setting. (While I'm not aware of one, I > could imaging some test checks whether it is actually painting.) >=20 > Thus I propose implementing this in some way to easily disable it if > required: Either >=20 > - by adding this a new phase (as in the snippet shown above), so it can > easily be disabled >=20 > - by adding another keyword-argument (proposal: `#:qpa-platform`, > default: "offscreen", if +f, will not be set. >=20 > WDYT? >=20 I like a new phase before the 'check phase. Are there other things we'd want to add? Looking through kde-framworks.scm the only one I'd feel comfortable adding would be the TZ ones. --=20 Efraim Flashner =D7=90=D7=A4=D7=A8=D7=99=D7=9D = =D7=A4=D7=9C=D7=A9=D7=A0=D7=A8 GPG key =3D A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351 Confidentiality cannot be guaranteed on emails sent or received unencrypted --Xsn3knLL3qrmRbVI Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEoov0DD5VE3JmLRT3Qarn3Mo9g1EFAl4oFL8ACgkQQarn3Mo9 g1Fdfg//WfqEIpm15m76/7+63G/424ZVeJ8HiIM62SDSQ6oT+YYIvsxzs9urzse5 XoSW7WDp8w8h9WH8ZndL/3EK/yFZjYBt4GY5EbfMwsTNntO00cxAjyQmd+xSxfQI GQjNr3wmgzK+XkVjiJ/UIb3OrsteT0i00Uf2dIRY0GC4UlqWTRW3Gsf+iHeMxnBl XhUr/W6G2JGKqVBk0l9zII8Bx0fkQ9qzxkx/YXdAGlN8EDmlFkluGwdg4APFwgRZ 0fM+6DMhdWKtjwh9BGSJ82El9wGRafdT8LFcMQJ3W/EIZYa1vaxi0Eu1boGrIzva wJEAG/T2IV30OAXd2TL8HoyjkbTXtghvyF9LKnWPSHnNWKr0APsMJ5PN29ZfsLV2 nBN0j976lJ7PudmiDCPVAZ9ldso2J62a3rtDNcbUsUsd0wHgTFZsFH57AStuzXzc XADuETYMURMOmqXOf6bh9f0Aw2VSeafzEF2x49VidJ9nRDDVAT0kPnzHAkwxDoi6 Bdv9A6y9YNmO7CnaLgBu9rYeHt6XLZm2V46WpKdD6F61/2bzzqNz5DleAclKm5qC yF5SgJ60Prf9jrwxvoHeh4HguPuqIofJBJDdFqManJ0ltwQvwZ9+PbbOZjedvByY YmUEjJTyWyjCCmSWWUuI876iE23x91GteQZXxsTei3bDw6oAuZY= =mrXa -----END PGP SIGNATURE----- --Xsn3knLL3qrmRbVI--