From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:470:142:3::10]:56416) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iquXz-0000TT-NH for guix-patches@gnu.org; Mon, 13 Jan 2020 02:54:05 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iquXx-0005mg-Sw for guix-patches@gnu.org; Mon, 13 Jan 2020 02:54:03 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:52626) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iquXx-0005mB-Ov for guix-patches@gnu.org; Mon, 13 Jan 2020 02:54:01 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iquXx-0008Q3-N1 for guix-patches@gnu.org; Mon, 13 Jan 2020 02:54:01 -0500 Subject: [bug#39102] [PATCH 2/2 staging] gnu: qtbase: Open links properly without xdg-utils in profile Resent-Message-ID: Date: Mon, 13 Jan 2020 09:53:12 +0200 From: Efraim Flashner Message-ID: <20200113075312.GA15806@E5400> References: <20200112154353.3xfdivef3fewlqx4@zdrowyportier.kadziolka.net> <20200112154709.fhxirioephom3zvc@zdrowyportier.kadziolka.net> <87imlgxxw4.fsf@devup.no> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="huq684BweRXVnRxX" Content-Disposition: inline In-Reply-To: <87imlgxxw4.fsf@devup.no> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Marius Bakke Cc: Jakub =?UTF-8?Q?K=C4=85dzio=C5=82ka?= , 39102@debbugs.gnu.org --huq684BweRXVnRxX Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Jan 12, 2020 at 08:44:43PM +0100, Marius Bakke wrote: > Jakub K=C4=85dzio=C5=82ka writes: >=20 > > * gnu/packages/patches/qtbase-use-xdg-open-in-store.patch: New file. > > * gnu/packages/qt.scm (qtbase)[source][patches]: Apply the patch. > > [inputs]: Add a dependency on xdg-utils to get its store path. > > [arguments]: Add a new phase to patch the path into the source code. >=20 > This patch does a lot. :-) >=20 > With this patch, BROWSER and DEFAULT_BROWSER would no longer be > consulted, right? >=20 > Does checkExecutable work with absolute file names? I.e. could we get > away by simply patching "xdg-open" with its store file name? Probably > should change the default browsers while at it, though. :-) >=20 > Wrt the easy substitution, I think we should try and avoid introducing > changes to source code that depend on magic from #:phases. That way > people will still be (mostly) able to build Qt manually using the Guix > source. In this case, maybe defaulting to just "xdg-open" is enough? >=20 > In short, I'm looking for an easier way to achieve the same goal, > without the rather intrusive patch. >=20 > Copying Efraim as our resident Qt expert. I disagree about being a qt expert, I just like fixing packages :) Looking at the patch, I'm not in love with how there's a default list of browsers to look for. Looking at the code, it seems that if there's xdg-open available then open browser from the pre-defined list. What is the code around m_documentLauncher? Does that really need to be removed? I think our best bet would be to substitute xdg-open with the actual xdg-open binary around line 130 and to change the list of *browsers[] to ones we actually have in Guix. If we switched the list to {"icecat", "next", "chromium", "netsurf"} and made the substitution on xdg-open we'd be in a much better place than we are now. As it currently stands I know I don't have BROWSER or DEFAULT_BROWSER defined and we don't have any Debian-like package named 'default-browser' or similar that we could throw in. --=20 Efraim Flashner =D7=90=D7=A4=D7=A8=D7=99=D7=9D = =D7=A4=D7=9C=D7=A9=D7=A0=D7=A8 GPG key =3D A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351 Confidentiality cannot be guaranteed on emails sent or received unencrypted --huq684BweRXVnRxX Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEoov0DD5VE3JmLRT3Qarn3Mo9g1EFAl4cIeQACgkQQarn3Mo9 g1GEbg/9F21IjnrThvmPXIREqwVlZ2u/+wxXa6qg6992RSvLdKyZUlricmOgQ0Oz gz1ayp8sR7J82oFOFNjlV2sBW//njNGcWQFVNFISjf7pcrIT7RBjR9yhGhI3iyv8 8TMnbgC6ZRfEXX3qk5RfCo4XAR2W7GlzXpwq155fNEmWY+HZAOlXsRFzOeh4VoHs GmgVZ0oAfYqRijUBBL2tCbkKZum278k47EcwgWu1eTbuWhweCQGL57qfN6GNSf99 Ez3TdhoQTMLrchwU4M5aU7EXHpsQzmG+70/N48OqimLOtamlZmlHObPbEA0PfhFv 45Yiu8Rn7L8RkQESE8fVYwEV+IWx5KxjKCJBwNW6hXHeM1UcQ/sgVdn4iQoMJADP vVlEJVGguRSsLktCCLgo8mMYZFm7S1JFyYo/IgvuzXHNa/Cowbts97RjXgFAm8oV V7Itn0LtTMsuwE686ls/iIhz0hu+5fjIoTtas98pYldR98F01W8/gsH+FfI4Hdfw vryGHFKt9xXF6ab5qGdROAREgUPPgKBnQyDIK17+foor1dNsxm/c3epq+eBTZwWu +2qkwCWNJIA9O7mVS5ndaV1Sg+vtNDR9FtogxjjZ/Hq1bFQ3LQe9uj9LFCZxV8mb Eg6WNghuOkokYXKsHH2IIDGXJo7k66zedGxVCvSecoOglvsHhMw= =u5ei -----END PGP SIGNATURE----- --huq684BweRXVnRxX--