[bug#38904] gnu: Add gnome-color-manager.

[bug#38904] gnu: Add gnome-color-manager.

[Raghav Gururajan]

[-- Attachment #1.1: Type: text/plain, Size: 92 bytes --]

Hello Guix!

Please find the attached patch to add gnome-color-manager.

Regards,
RG.

[-- Attachment #1.2: gnome-color-manager.patch --]
[-- Type: text/x-patch, Size: 2257 bytes --]

From 30098cf561ab3fb902a08718c159ad2f6820df32 Mon Sep 17 00:00:00 2001
From: Raghav Gururajan <raghavgururajan@disroot.org>
Date: Fri, 3 Jan 2020 14:10:04 -0500
Subject: [PATCH] gnu: Add gnome-color-manager.

* gnu/packages/gnome.scm (gnome-color-manager): New variable.
---
 gnu/packages/gnome.scm | 39 +++++++++++++++++++++++++++++++++++++++
 1 file changed, 39 insertions(+)

diff --git a/gnu/packages/gnome.scm b/gnu/packages/gnome.scm
index 757091790d..102f679b53 100644
--- a/gnu/packages/gnome.scm
+++ b/gnu/packages/gnome.scm
@@ -246,6 +246,45 @@ Desktop.  It is designed to be as simple as possible and has some unique
 features to enable users to create their discs easily and quickly.")
     (license license:gpl2+)))
 
+(define-public gnome-color-manager
+  (package
+   (name "gnome-color-manager")
+   (version "3.32.0")
+   (source (origin
+            (method url-fetch)
+            (uri (string-append "mirror://gnome/sources/" name "/"
+                                (version-major+minor version) "/"
+                                name "-" version ".tar.xz"))
+            (sha256
+             (base32
+              "1vpxa2zjz3lkq9ldjg0fl65db9s6b4kcs8nyaqfz3jygma7ifg3w"))))
+   (build-system meson-build-system)
+   (arguments
+    `(#:tests? #f)) ;;gcm-self-test fails due to no active display server
+   (native-inputs
+    `(("gettext" ,gettext-minimal)
+      ("glib:bin" ,glib "bin")
+      ("gtk+:bin" ,gtk+ "bin")
+      ("pkg-config" ,pkg-config)))
+   (inputs
+    `(("adwaita-icon-theme" ,adwaita-icon-theme)
+      ("appstream-glib" ,appstream-glib)
+      ("colord-gtk" ,colord-gtk)
+      ("desktop-file-utils" ,desktop-file-utils)
+      ("exiv2" ,exiv2)
+      ("gnome-desktop" ,gnome-desktop)
+      ("itstool" ,itstool)
+      ("libcanberra" ,libcanberra)
+      ("libexif" ,libexif)
+      ("libtiff" ,libtiff)
+      ("vte" ,vte)))
+   (synopsis "Color profile manager for the GNOME desktop")
+   (description "GNOME Color Manager is a session framework that makes
+it easy to manage, install and generate color profiles
+in the GNOME desktop.")
+   (home-page "https://gitlab.gnome.org/GNOME/gnome-color-manager")
+   (license license:gpl2)))
+
 (define-public gssdp
   (package
    (name "gssdp")
-- 
2.24.1


[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

[bug#38904] gnu: Add gnome-color-manager.

[Danny Milosavljevic]

[-- Attachment #1: Type: text/plain, Size: 300 bytes --]

Hi RG,

>+    `(#:tests? #f)) ;;gcm-self-test fails due to no active display server

Trailing comments should have only one semicolon.

But better yet, since Guix packages build in a container, just start a display
server yourself.

For examples, search for "Xvfb" in the Guix source code.

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

[bug#38904] gnu: Add gnome-color-manager.

[Raghav Gururajan]

[-- Attachment #1.1: Type: text/plain, Size: 339 bytes --]

Hello Danny!

> Trailing comments should have only one semicolon.
> 
> But better yet, since Guix packages build in a container, just start
> a display
> server yourself.
> 
> For examples, search for "Xvfb" in the Guix source code.

Thanks for the tip. Please find the revised patch attached with this
email.

Regards,
RG.

[-- Attachment #1.2: gnome-color-manager.patch --]
[-- Type: text/x-patch, Size: 2674 bytes --]

From 6b961ef1d336b9c8016432bf172713ae16568476 Mon Sep 17 00:00:00 2001
From: Raghav Gururajan <raghavgururajan@disroot.org>
Date: Mon, 6 Jan 2020 00:51:19 -0500
Subject: [PATCH] gnu: Add gnome-color-manager.

* gnu/packages/gnome.scm (gnome-color-manager): New variable.
---
 gnu/packages/gnome.scm | 53 ++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 53 insertions(+)

diff --git a/gnu/packages/gnome.scm b/gnu/packages/gnome.scm
index 6aed46b3b2..45a85d6035 100644
--- a/gnu/packages/gnome.scm
+++ b/gnu/packages/gnome.scm
@@ -246,6 +246,59 @@ Desktop.  It is designed to be as simple as possible and has some unique
 features to enable users to create their discs easily and quickly.")
     (license license:gpl2+)))
 
+(define-public gnome-color-manager
+  (package
+   (name "gnome-color-manager")
+   (version "3.32.0")
+   (source (origin
+            (method url-fetch)
+            (uri (string-append "mirror://gnome/sources/" name "/"
+                                (version-major+minor version) "/"
+                                name "-" version ".tar.xz"))
+            (sha256
+             (base32
+              "1vpxa2zjz3lkq9ldjg0fl65db9s6b4kcs8nyaqfz3jygma7ifg3w"))))
+   (build-system meson-build-system)
+   (arguments
+    `(#:glib-or-gtk? #t
+      #:phases
+       (modify-phases %standard-phases
+        (add-before
+         'check 'pre-check
+         (lambda _
+           ;; Tests require a running X server.
+           (system "Xvfb :1 &")
+           (setenv "DISPLAY" ":1")
+           #t)))))
+   (native-inputs
+    `(("gettext" ,gettext-minimal)
+      ("glib:bin" ,glib "bin")
+      ("gtk+:bin" ,gtk+ "bin")
+      ("pkg-config" ,pkg-config)))
+   (inputs
+    `(("adwaita-icon-theme" ,adwaita-icon-theme)
+      ("appstream-glib" ,appstream-glib)
+      ("colord-gtk" ,colord-gtk)
+      ("desktop-file-utils" ,desktop-file-utils)
+      ("exiv2" ,exiv2)
+      ("gnome-desktop" ,gnome-desktop)
+      ("itstool" ,itstool)
+      ("libcanberra" ,libcanberra)
+      ("libexif" ,libexif)
+      ("libtiff" ,libtiff)
+      ("libxrandr" ,libxrandr)
+      ("libxtst" ,libxtst)
+      ("libxxf86vm" ,libxxf86vm)
+      ("vte" ,vte)
+      ("xorgproto" ,xorgproto)
+      ("xorg-server" ,xorg-server-for-tests)))
+   (synopsis "Color profile manager for the GNOME desktop")
+   (description "GNOME Color Manager is a session framework that makes
+it easy to manage, install and generate color profiles
+in the GNOME desktop.")
+   (home-page "https://gitlab.gnome.org/GNOME/gnome-color-manager")
+   (license license:gpl2)))
+
 (define-public gnome-online-miners
   (package
     (name "gnome-online-miners")
-- 
2.24.1


[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

[bug#38904] v3

[Raghav Gururajan]

[-- Attachment #1.1: Type: text/plain, Size: 4 bytes --]

v3

[-- Attachment #1.2: gnome-color-manager.patch --]
[-- Type: text/x-patch, Size: 2825 bytes --]

From 45ae7606289e5382a7b9b9373d5920b9730d97c5 Mon Sep 17 00:00:00 2001
From: Raghav Gururajan <raghavgururajan@disroot.org>
Date: Wed, 8 Jan 2020 09:47:19 -0500
Subject: [PATCH] gnu: Add gnome-color-manager

* gnu/packages/gnome.scm (gnome-color-manager): New variable.
---
 gnu/packages/gnome.scm | 56 ++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 56 insertions(+)

diff --git a/gnu/packages/gnome.scm b/gnu/packages/gnome.scm
index e71cc2fee2..612fe6fae6 100644
--- a/gnu/packages/gnome.scm
+++ b/gnu/packages/gnome.scm
@@ -246,6 +246,62 @@ Desktop.  It is designed to be as simple as possible and has some unique
 features to enable users to create their discs easily and quickly.")
     (license license:gpl2+)))
 
+(define-public gnome-color-manager
+  (package
+   (name "gnome-color-manager")
+   (version "3.32.0")
+   (source (origin
+            (method url-fetch)
+            (uri (string-append "mirror://gnome/sources/" name "/"
+                                (version-major+minor version) "/"
+                                name "-" version ".tar.xz"))
+            (sha256
+             (base32
+              "1vpxa2zjz3lkq9ldjg0fl65db9s6b4kcs8nyaqfz3jygma7ifg3w"))))
+   (build-system meson-build-system)
+   (arguments
+    `(#:glib-or-gtk? #t
+      #:phases
+       (modify-phases %standard-phases
+        (add-before
+         'check 'pre-check
+         (lambda _
+           ;; Tests require a running X server.
+           (system "Xvfb :1 &")
+           (setenv "DISPLAY" ":1")
+           #t)))))
+   (native-inputs
+    `(("gettext" ,gettext-minimal)
+      ("glib:bin" ,glib "bin")
+      ("gtk+:bin" ,gtk+ "bin")
+      ("pkg-config" ,pkg-config)))
+   (inputs
+    `(("adwaita-icon-theme" ,adwaita-icon-theme)
+      ("appstream-glib" ,appstream-glib)
+      ("colord-gtk" ,colord-gtk)
+      ("desktop-file-utils" ,desktop-file-utils)
+      ("exiv2" ,exiv2)
+      ("glib" ,glib)
+      ("gnome-desktop" ,gnome-desktop)
+      ("gobject-introspection" ,gobject-introspection)
+      ("gtk+" ,gtk+)
+      ("itstool" ,itstool)
+      ("libcanberra" ,libcanberra)
+      ("libexif" ,libexif)
+      ("libtiff" ,libtiff)
+      ("libxrandr" ,libxrandr)      ; for tests
+      ("libxtst" ,libxtst)
+      ("libxxf86vm" ,libxxf86vm)      ; for tests
+      ("vte" ,vte)
+      ("xorgproto" ,xorgproto)      ; for tests
+      ("xorg-server" ,xorg-server-for-tests)))      ; for tests
+   (synopsis "Color profile manager for the GNOME desktop")
+   (description "GNOME Color Manager is a session framework that makes
+it easy to manage, install and generate color profiles
+in the GNOME desktop.")
+   (home-page "https://gitlab.gnome.org/GNOME/gnome-color-manager")
+   (license license:gpl2)))
+
 (define-public gnome-menus
   (package
     (name "gnome-menus")
-- 
2.24.1


[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

[bug#38904] gnu: Add gnome-color-manager.

[Danny Milosavljevic]

[-- Attachment #1: Type: text/plain, Size: 303 bytes --]

Hi Raghav,

Some questions:

* Why is adwaita-icon-theme an input?

Some comments:

* xorg-server-for-tests should definitely be a native-input if it is used.
* desktop-file-utils should definitely be a native-input if it is used.
* itstool should definitely be a native-input if it is used.

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

[bug#38904] gnu: Add gnome-color-manager.

[Raghav Gururajan]

[-- Attachment #1: Type: text/plain, Size: 671 bytes --]

Hi Danny!

> Some questions:
> 
> * Why is adwaita-icon-theme an input?

I believe this application retrives some information about graphical
properties of a-i-t from a-i-t package.

> Some comments:
> 
> * xorg-server-for-tests should definitely be a native-input if it is
> used.
> * desktop-file-utils should definitely be a native-input if it is
> used.
> * itstool should definitely be a native-input if it is used.

Yes, even I believe so. Would it be okay if I leave things as it is for
now? Because soon I will revising+testing all gnome packages one-by-
one, so I will be moving any unnessessary inputs to native-inputs. :-)

Regards,
RG.

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

bug#38904: gnu: Add gnome-color-manager.

[Danny Milosavljevic]

[-- Attachment #1: Type: text/plain, Size: 1141 bytes --]

Hi Raghav,

On Thu, 09 Jan 2020 10:26:31 -0500
Raghav Gururajan <raghavgururajan@disroot.org> wrote:

> I believe this application retrives some information about graphical
> properties of a-i-t from a-i-t package.

To find out, I've removed it from the inputs and it built just fine and
gcm-viewer also started up fine.  What was the reason that you added it?

> Would it be okay if I leave things as it is for now?

You are free to leave it as is on your computer.  When merging it to
guix master there have to be some standards--otherwise master would be
perpetually broken.

In this specific case, some other packages in (gnu packages gnome) also have
adwaita-icon-theme as input.  Even when there is that input that is unused it
will not cause problems (however, it will also not do what you wanted
it to do--whatever that is).  Also, nothing depends on gnome-color-manager.
Therefore, applied to guix master as commit
29ae18db0578bbdbc0119703f7412fe91927e80e.

But really, having one specific theme (which is by definition a user-selectable
thing) as an input is weird.  Let's fix that everywhere eventually.

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

[bug#38904] gnu: Add gnome-color-manager.

[Raghav Gururajan]

[-- Attachment #1: Type: text/plain, Size: 1295 bytes --]

Hi Danny!

> To find out, I've removed it from the inputs and it built just fine
> and
> gcm-viewer also started up fine.  What was the reason that you added
> it?

The upstream mentioned it as a required dependency. Please view 
https://gitlab.gnome.org/GNOME/gnome-build-meta/blob/master/elements/core/gnome-color-manager.bst
.

> > Would it be okay if I leave things as it is for now?
> 
> You are free to leave it as is on your computer.  When merging it to
> guix master there have to be some standards--otherwise master would
> be
> perpetually broken.

I understand :-)

> In this specific case, some other packages in (gnu packages gnome)
> also have
> adwaita-icon-theme as input.  Even when there is that input that is
> unused it
> will not cause problems (however, it will also not do what you wanted
> it to do--whatever that is).  Also, nothing depends on gnome-color-
> manager.
> Therefore, applied to guix master as commit
> 29ae18db0578bbdbc0119703f7412fe91927e80e.

Thank you!

> But really, having one specific theme (which is by definition a user-
> selectable
> thing) as an input is weird.  Let's fix that everywhere eventually.

IIRC, gnome uses adwaita icon theme as default. I'll try look into what
can be done.

Regards,
RG.


[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 488 bytes --]